Page MenuHomePhabricator
Create Task
Maniphest T364254

Use @color-inverted-fixed instead of @color-inverted for progressive/destructive button icons (CSS)
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • I'm using a CSS only, progressive button w/ icon.
  • I'm specifying the classes cdx-button cdx-button--weight-primary cdx-button--action-progressive.
  • I'm using dark mode

What happens?:

  • The icon is black next to the white button text on progressive blue background
  • .cdx-button:enabled.cdx-button--weight-primary.cdx-button--action-progressive .cdx-button__icon, .cdx-button.cdx-button--fake-button--enabled.cdx-button--weight-primary.cdx-button--action-progressive .cdx-button__icon applies and sets background-color: var(--color-inverted,#fff)

What should have happened instead?:

  • The icon should be white as the button text
  • background-color: var(--color-inverted-fixed) should be applied instead

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): Codex 1.5.0

Other information (browser name/version, screenshots, etc.):

Screen Shot 2024-05-05 at 00.12.40.png (88×298 px, 5 KB)

Workaround: specify notheme class on the icon.

Details

SubjectRepoBranchLines +/-
Revert "Fix Codex icon on progressive buttons in dark mode"mediawiki/extensions/MultimediaViewermaster+2 -4
Update Codex from 1.5.0 to 1.6.0mediawiki/coremaster+2 K -1 K
styles: prog/dest prim buttons should not invert icons in dark modedesign/codexmain+6 -6
Fix Codex icon on progressive buttons in dark modemediawiki/extensions/MultimediaViewermaster+4 -2
Customize query in gerrit

Event Timeline

simon04 created this task.Sat, May 4, 9:16 PM
Restricted Application added a project: Design-System-Team. · View Herald TranscriptSat, May 4, 9:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Sat, May 4, 9:17 PM

Change #1027250 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Fix Codex icon on progressive buttons in dark mode

https://gerrit.wikimedia.org/r/1027250

gerritbot added a project: Patch-For-Review.Sat, May 4, 9:17 PM
Jdlrobson added a comment.Sun, May 5, 6:05 AM

For now, as a a workaround we're adding the notheme class to these buttons - but it doesn't seem like the best solution. Would be great for someone in DST to look at the fix here and suggest a better long term fix. Thanks in advance!

gerritbot added a comment.Sun, May 5, 6:16 AM

Change #1027250 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Fix Codex icon on progressive buttons in dark mode

https://gerrit.wikimedia.org/r/1027250

Maintenance_bot removed a project: Patch-For-Review.Sun, May 5, 6:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).Sun, May 5, 7:00 AM
gerritbot added a comment.Mon, May 6, 9:21 AM

Change #1028385 had a related patch set uploaded (by TheDJ; author: TheDJ):

[design/codex@main] Dark mode: prog/dest prim buttons should not invert icons

https://gerrit.wikimedia.org/r/1028385

gerritbot added a project: Patch-For-Review.Mon, May 6, 9:21 AM
CCiufo-WMF moved this task from Inbox to Triaging on the Design-System-Team board.Tue, May 7, 5:06 PM
CCiufo-WMF subscribed.

@TheDJ thanks for the Codex patch! @egardner is out right now so I'll see if someone else can review.

Volker_E edited projects, added Design-System-Team (DST-Sprint-22 (2024-04-29 to 2024-05-10)); removed Design-System-Team.Wed, May 8, 4:36 AM
Volker_E moved this task from Committed to Pending Release on the Design-System-Team (DST-Sprint-22 (2024-04-29 to 2024-05-10)) board.
gerritbot added a comment.Wed, May 8, 4:39 AM

Change #1028585 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MultimediaViewer@master] Revert "Fix Codex icon on progressive buttons in dark mode"

https://gerrit.wikimedia.org/r/1028585

gerritbot added a comment.Wed, May 8, 4:46 AM

Change #1028385 merged by jenkins-bot:

[design/codex@main] styles: prog/dest prim buttons should not invert icons in dark mode

https://gerrit.wikimedia.org/r/1028385

Catrope assigned this task to TheDJ.Mon, May 13, 5:07 PM
Volker_E added a project: CSS.Mon, May 13, 5:48 PM
gerritbot added a comment.Thu, May 16, 12:48 AM

Change #1032095 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from 1.5.0 to 1.6.0

https://gerrit.wikimedia.org/r/1032095

gerritbot added a comment.Thu, May 16, 1:57 AM

Change #1032095 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from 1.5.0 to 1.6.0

https://gerrit.wikimedia.org/r/1032095

Volker_E closed this task as Resolved.Thu, May 16, 2:08 AM
Volker_E removed a project: Patch-For-Review.
Volker_E set the point value for this task to 1.
gerritbot added a comment.Thu, May 16, 11:19 PM

Change #1028585 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Revert "Fix Codex icon on progressive buttons in dark mode"

https://gerrit.wikimedia.org/r/1028585

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.6; 2024-05-21); removed MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).Fri, May 17, 12:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL