Page MenuHomePhabricator

[S] Time-box new feature announcement
Open, LowPublic

Description

Background

As part of releasing the new suggested edit Add an Image in iOS, we added a new feature announcement modal: T358894. We do not want to show this modal indefinitely for new installs, and overwhelm users with too many modals. We will add a time-limit for the announcement for the first few months after release.

Current behavior:

We persist a struct (WKImageRecommendationsDataController.OnboardingStatus that contains a flag hasPresentedFeatureAnnouncementModal which is defaulted to false. Upon Explore feed appearance or foregrounding, we check to see if the Suggested Edits card is in the Explore feed, as well as confirm the Explore feed isn't already presenting something. If both checks pass, and hasPresentedFeatureAnnouncementModal is false, we present the feature announcement modal. Upon presentation we set the flag to true and persist, which allows it to not present again for that app install.

For new users that fresh install the app and existing users that upgrade to version 7.5.0, the announcement will always show once.

Requirements
  • Proactively set the new feature announcement for "Add an image" so that it hides if the date is after October 4, 2024
Engineering notes

We could add an additional check in presentImageRecommendationsFeatureAnnouncementIfNeeded to exit early once the current date is past October 2024. That can be released as soon as possible.

We could then create a cleanup task to clean out all image recommendations announcement code and persistence. This work should not be picked up and released until October 2024.

Event Timeline

HNordeenWMF raised the priority of this task from Low to Needs Triage.May 7 2024, 7:38 PM
HNordeenWMF updated the task description. (Show Details)
Tsevener renamed this task from Time-box new feature announcement to [S] Time-box new feature announcement.May 14 2024, 5:09 PM

Hi all! Just pushed this PR that solves the task.

Added a couple of TODO comments for helping the cleanup later too.

Thanks!

Hi @varaniOS or whoever does code-review here: could we please change the expiration date to be October 4?

Reasoning: we are planning to run the Alt text experiment roughly August 20 - September 20. As a part of that, we'll lift the 50+ edit requirement for "Add an Image" temporarily in select languages. I'd like to make sure the folks who are newly eligible for "Add an image" during that time see the new feature announcement.

Hi @HNordeenWMF! Sure, thanks for the context! I just changed the expiration date on the PR

Let me know if I can help with anything else