Page MenuHomePhabricator
Create Task
Maniphest T364539

Protocol-relative URL in sidebar now interpreted as title (Query Service link in Wikidata sidebar broken)
Closed, ResolvedPublic
Actions

Description

The “Query Service” link in the Wikidata sidebar (wayback machine) currently points to https://www.wikidata.org/wiki///query.wikidata.org/, rather than https://query.wikidata.org/.

As far as I can tell, neither the sidebar definition (wikibase-queryservice-url|wikibase-queryservice) nor the wikibase-queryservice-url itself have been changed recently, so presumably MediaWiki is now interpreting the sidebar URL //query.wikidata.org/ differently, as a local title rather than a protocol-relative URL.

Details

SubjectRepoBranchLines +/-
Skin: Fix UrlUtils callsmediawiki/corewmf/1.43.0-wmf.4+30 -2
Skin: Fix UrlUtils callsmediawiki/coremaster+30 -2
Revert "Replace deprecated url functions in Skin class"mediawiki/coremaster+6 -13
Customize query in gerrit

Related Objects

Event Timeline

LucasWerkmeister created this task.Thu, May 9, 12:04 PM
Restricted Application added a project: Internet-Archive. · View Herald TranscriptThu, May 9, 12:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
LucasWerkmeister updated the task description. (Show Details)Thu, May 9, 12:06 PM
LucasWerkmeister added subscribers: WMDE-Fisch, Addshore.

I can reproduce the issue locally and reverting Replace deprecated url functions in Skin class fixes it, so I guess the replacement functions work slightly differently.

LucasWerkmeister added a subscriber: Nikki.Thu, May 9, 12:10 PM

@Nikki points out that the donate link is also affected (points to https://www.wikidata.org/wiki///donate.wikimedia.org/wiki/Special:FundraiserRedirector%3Futm_source%3Ddonate%26utm_medium%3Dsidebar%26utm_campaign%3DC13_wikidata.org%26uselang%3Den).

gerritbot added a comment.Thu, May 9, 12:11 PM

Change #1029264 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[mediawiki/core@master] Revert "Replace deprecated url functions in Skin class"

https://gerrit.wikimedia.org/r/1029264

gerritbot added a project: Patch-For-Review.Thu, May 9, 12:11 PM
LucasWerkmeister mentioned this in T361398: 1.43.0-wmf.4 deployment blockers.Thu, May 9, 12:12 PM
gerritbot added a comment.Thu, May 9, 12:18 PM

Change #1029522 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[mediawiki/core@master] Skin: Fix UrlUtils calls

https://gerrit.wikimedia.org/r/1029522

Lydia_Pintscher added a comment.Thu, May 9, 12:37 PM

I fixed the links locally until this is fixed. These edits should be undone once the underlying issue is fixed:

gerritbot added a comment.Thu, May 9, 12:37 PM

Change #1029264 abandoned by Lucas Werkmeister:

[mediawiki/core@master] Revert "Replace deprecated url functions in Skin class"

Reason:

superseded by I050ed65624

https://gerrit.wikimedia.org/r/1029264

Bawolff subscribed.Thu, May 9, 3:02 PM

Also broke the techblog link on mediawiki.org

gerritbot added a comment.Thu, May 9, 5:24 PM

Change #1029522 merged by jenkins-bot:

[mediawiki/core@master] Skin: Fix UrlUtils calls

https://gerrit.wikimedia.org/r/1029522

gerritbot added a comment.Thu, May 9, 5:27 PM

Change #1029552 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[mediawiki/core@wmf/1.43.0-wmf.4] Skin: Fix UrlUtils calls

https://gerrit.wikimedia.org/r/1029552

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).Thu, May 9, 6:00 PM
gerritbot added a comment.Thu, May 9, 8:47 PM

Change #1029552 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.4] Skin: Fix UrlUtils calls

https://gerrit.wikimedia.org/r/1029552

Stashbot added a comment.Thu, May 9, 8:47 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-09T20:47:22Z] <jhuneidi@deploy1002> Started scap: Backport for [[gerrit:1029552|Skin: Fix UrlUtils calls (T364539)]]

Stashbot added a comment.Thu, May 9, 8:49 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-09T20:49:51Z] <jhuneidi@deploy1002> jhuneidi and lucaswerkmeister: Backport for [[gerrit:1029552|Skin: Fix UrlUtils calls (T364539)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.4; 2024-05-07); removed MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).Thu, May 9, 9:00 PM
Stashbot added a comment.Thu, May 9, 9:11 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-09T21:11:04Z] <jhuneidi@deploy1002> Finished scap: Backport for [[gerrit:1029552|Skin: Fix UrlUtils calls (T364539)]] (duration: 23m 42s)

LucasWerkmeister added a comment.Thu, May 9, 9:14 PM

This should be fixed now, but the sidebar is cached for one day, so we should only delete the overrides tomorrow (or later). Let’s leave the task open until then, IMHO.

Maintenance_bot removed a project: Patch-For-Review.Thu, May 9, 9:31 PM
LucasWerkmeister added a comment.Mon, May 13, 6:15 PM
In T364539#9783142, @Lydia_Pintscher wrote:

I fixed the links locally until this is fixed. These edits should be undone once the underlying issue is fixed:

I think it would be okay to undo those edits now.

Lydia_Pintscher added a comment.Mon, May 13, 6:20 PM

Done!

LucasWerkmeister closed this task as Resolved.Mon, May 13, 6:21 PM
LucasWerkmeister claimed this task.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL