Page MenuHomePhabricator
Create Task
Maniphest T361398

1.43.0-wmf.4 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jnuche
Release Version
1.43.0-wmf.4
Release Date
May 6 2024, 12:00 AM

2024 week 19 1.43-wmf.4 Changes wmf/1.43.0-wmf.4

This MediaWiki Train Deployment is scheduled for the week of Monday, May 6th:

Monday May 6thTuesday, May 7thWednesday, May 8thThursday, May 9thFriday
Backports only.Branch wmf.4 and deploy to Group 0 Wikis.Deploy wmf.4 to Group 1 Wikis.Deploy wmf.4 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.4 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.43.0-wmf.3
Next: 1.43.0-wmf.5
SubjectRepoBranchLines +/-
group2 wikis to 1.43.0-wmf.4operations/mediawiki-configmaster+336 -336
group1 wikis to 1.43.0-wmf.4operations/mediawiki-configmaster+553 -553
group0 wikis to 1.43.0-wmf.4operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.43.0-wmf.4operations/mediawiki-configmaster+132 -132
group0 wikis to 1.43.0-wmf.4operations/mediawiki-configmaster+132 -132
Partial cherry-pick of I9d8409fdbd757emediawiki/corewmf/1.43.0-wmf.3+15 -3
testwikis wikis to 1.43.0-wmf.4operations/mediawiki-configmaster+3 -3
testwikis wikis to 1.43.0-wmf.4operations/mediawiki-configmaster+3 -3
Branch commit for wmf/1.43.0-wmf.4mediawiki/corewmf/1.43.0-wmf.4+1 K -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Mar 29 2024, 8:42 PM
Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptMar 29 2024, 8:42 PM
Jdlrobson mentioned this in T363373: Verify 1.43.0-wmf.4 deployment.Apr 24 2024, 6:10 PM
thcipriani assigned this task to jeena.May 1 2024, 3:42 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jnuche.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog ๐Ÿ“ฅ).
SecurityPatchBot added a subtask: T338419: CVE-2024-40609: Wikimedia\RequestTimeout\RequestTimeoutException on Special:Investigate timeline mode.May 2 2024, 12:00 AM
SecurityPatchBot mentioned this in T338419: CVE-2024-40609: Wikimedia\RequestTimeout\RequestTimeoutException on Special:Investigate timeline mode.
ihurbain mentioned this in T364024: CTT tasks week of 2024-05-03.May 2 2024, 4:12 PM
Jdforrester-WMF subscribed.May 2 2024, 7:38 PM
Risky Patch! ๐Ÿš‚๐Ÿ”ฅ
  • Change: https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/73
  • Summary: Addition of new extension (unloaded) to scap's manifest ahead of Beta Cluster enablement โ€“ T364034
  • Test plan: If scap works, it's fine
  • Places to monitor: scap errors
  • Revert plan: Revert patch, re-roll scap
  • Affected wikis: All (or rather, hopefully, none)
  • IRC contact: James_F
  • UBN Task Projects/tags: Automoderator
  • Would you like to backport this change rather than ride the train?: N/A
Reedy subscribed.May 5 2024, 2:11 PM

NB hackathon preceded this train. Lots of changes.

Feel free to ping me and others to help :)

Jdforrester-WMF removed a subtask: T338419: CVE-2024-40609: Wikimedia\RequestTimeout\RequestTimeoutException on Special:Investigate timeline mode.May 5 2024, 8:03 PM
Ladsgroup subscribed.May 6 2024, 12:21 PM

First of all, my condolences to Jeena for being the train conductor this week.

Risky Patch! ๐Ÿš‚๐Ÿ”ฅ
  • Change: https://gerrit.wikimedia.org/r/1020948
  • Summary: This changes how addresses to blob store for new revisions are being stored and retrieved
  • Test plan: Edits should show up after edit is done.
  • Places to monitor: logstash errors, people screaming
  • Revert plan: ---
  • Affected wikis: All
  • IRC contact: Amir1
  • UBN Task Projects/tags: DBA
  • Would you like to backport this change rather than ride the train?: N/A

Note: This change is not forward compatible, so if you need to roll back the train, accessing revisoins that are made in between the time will be broken. I will try to make a forward-compat patch and deploy it to wmf.3

gerritbot added a comment.May 7 2024, 1:08 AM

Change #1027481 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.43.0-wmf.4] Branch commit for wmf/1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1027481

gerritbot added a project: Patch-For-Review.May 7 2024, 1:08 AM
gerritbot added a comment.May 7 2024, 1:28 AM

Change #1027481 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.4] Branch commit for wmf/1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1027481

Maintenance_bot removed a project: Patch-For-Review.May 7 2024, 1:30 AM
gerritbot added a comment.May 7 2024, 3:01 AM

Change #1028611 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1028611

gerritbot added a project: Patch-For-Review.May 7 2024, 3:01 AM
gerritbot added a comment.May 7 2024, 9:10 AM

Change #1028765 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1028765

gerritbot added a comment.May 7 2024, 9:11 AM

Change #1028765 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1028765

Stashbot added a comment.May 7 2024, 9:11 AM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T09:11:39Z] <jnuche@deploy1002> Started scap: testwikis wikis to 1.43.0-wmf.4 refs T361398

gerritbot added a comment.May 7 2024, 9:12 AM

Change #1028611 abandoned by Zabe:

[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.4

Reason:

https://gerrit.wikimedia.org/r/1028611

Maintenance_bot removed a project: Patch-For-Review.May 7 2024, 9:30 AM
Stashbot added a comment.May 7 2024, 9:55 AM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T09:55:17Z] <jnuche@deploy1002> sync-world aborted: testwikis wikis to 1.43.0-wmf.4 refs T361398 (duration: 43m 38s)

Stashbot added a comment.May 7 2024, 9:56 AM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T09:56:43Z] <jnuche@deploy1002> Started scap: testwikis wikis to 1.43.0-wmf.4 refs T361398

Stashbot added a comment.May 7 2024, 10:16 AM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T10:16:05Z] <jnuche@deploy1002> Finished scap: testwikis wikis to 1.43.0-wmf.4 refs T361398 (duration: 19m 22s)

jnuche subscribed.May 7 2024, 10:17 AM
In T361398#9776835, @Stashbot wrote:

Mentioned in SAL (#wikimedia-operations) [2024-05-07T09:55:17Z] <jnuche@deploy1002> sync-world aborted: testwikis wikis to 1.43.0-wmf.4 refs T361398 (duration: 43m 38s)

That was an accident.

gerritbot added a comment.May 7 2024, 4:26 PM

Change #1028865 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@wmf/1.43.0-wmf.3] Partial cherry-pick of I9d8409fdbd757e

https://gerrit.wikimedia.org/r/1028865

gerritbot added a project: Patch-For-Review.May 7 2024, 4:26 PM
gerritbot added a comment.May 7 2024, 7:18 PM

Change #1028865 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.3] Partial cherry-pick of I9d8409fdbd757e

https://gerrit.wikimedia.org/r/1028865

Stashbot mentioned this in T362566: Stop growth of text table by storing ES addresses in content table.May 7 2024, 7:18 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T19:18:53Z] <jhuneidi@deploy1002> Started scap: Backport for [[gerrit:1028865|Partial cherry-pick of I9d8409fdbd757e (T361398 T362566)]]

Stashbot added a comment.May 7 2024, 7:21 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T19:21:29Z] <jhuneidi@deploy1002> ladsgroup and jhuneidi: Backport for [[gerrit:1028865|Partial cherry-pick of I9d8409fdbd757e (T361398 T362566)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.May 7 2024, 7:31 PM
Stashbot added a comment.May 7 2024, 7:34 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T19:34:33Z] <jhuneidi@deploy1002> Finished scap: Backport for [[gerrit:1028865|Partial cherry-pick of I9d8409fdbd757e (T361398 T362566)]] (duration: 15m 39s)

gerritbot added a comment.May 7 2024, 7:43 PM

Change #1028888 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1028888

gerritbot added a project: Patch-For-Review.May 7 2024, 7:43 PM

Change #1028888 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1028888

Stashbot added a comment.May 7 2024, 7:59 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T19:59:18Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.43.0-wmf.4 refs T361398

jeena added a subtask: T364428: InvalidArgumentException: Wikimedia\Rdbms\JoinGroupBase::table: $table must be either string, JoinGroup or SelectQueryBuilder (via IndexPager).May 7 2024, 8:01 PM
gerritbot added a comment.May 7 2024, 8:03 PM

Change #1028891 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1028891

gerritbot added a comment.May 7 2024, 8:04 PM

Change #1028891 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1028891

Stashbot added a comment.May 7 2024, 8:04 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T20:04:48Z] <jhuneidi@deploy1002> Started scap: testwikis wikis to 1.43.0-wmf.4 refs T361398

jeena added a comment.May 7 2024, 8:08 PM

I rolled back to testwikis due to errors caused by T364428.

Stashbot added a comment.May 7 2024, 8:19 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T20:19:51Z] <jhuneidi@deploy1002> Finished scap: testwikis wikis to 1.43.0-wmf.4 refs T361398 (duration: 15m 03s)

Maintenance_bot removed a project: Patch-For-Review.May 7 2024, 8:31 PM
Michael subscribed.May 8 2024, 7:20 AM
Ladsgroup closed subtask T364428: InvalidArgumentException: Wikimedia\Rdbms\JoinGroupBase::table: $table must be either string, JoinGroup or SelectQueryBuilder (via IndexPager) as Resolved.May 8 2024, 10:49 AM
thcipriani moved this task from Priority Backlog ๐Ÿ“ฅ to Yakisfaction on the Release-Engineering-Team board.May 8 2024, 3:43 PM
thcipriani edited projects, added Release-Engineering-Team (Yakisfaction); removed Release-Engineering-Team (Priority Backlog ๐Ÿ“ฅ).
thcipriani moved this task from Backlog to In progress on the Release-Engineering-Team (Yakisfaction) board.May 8 2024, 3:51 PM
gerritbot added a comment.May 8 2024, 6:06 PM

Change #1029239 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1029239

gerritbot added a project: Patch-For-Review.May 8 2024, 6:06 PM

Change #1029239 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1029239

Stashbot added a comment.May 8 2024, 6:24 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-08T18:23:59Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.43.0-wmf.4 refs T361398

Maintenance_bot removed a project: Patch-For-Review.May 8 2024, 6:30 PM
gerritbot added a comment.May 8 2024, 6:33 PM

Change #1029242 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1029242

gerritbot added a project: Patch-For-Review.May 8 2024, 6:33 PM

Change #1029242 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1029242

Stashbot added a comment.May 8 2024, 6:49 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-08T18:49:46Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.43.0-wmf.4 refs T361398

Maintenance_bot removed a project: Patch-For-Review.May 8 2024, 7:31 PM
Aklapper added a subtask: T364522: Internal error when trying to mark a page for translation not yet in translation system.May 9 2024, 9:27 AM
taavi added a subtask: T364536: Fatal exception of type "Flow\Exception\WikitextException".May 9 2024, 11:55 AM
Aklapper added a subtask: T364499: Flow\Exception\WikitextException: Conversion from 'wikitext' to 'topic-title-wikitext' was requested, but this is not supported..May 9 2024, 11:56 AM
Aklapper removed a subtask: T364536: Fatal exception of type "Flow\Exception\WikitextException".
LucasWerkmeister subscribed.May 9 2024, 12:12 PM

Probably not a train blocker since we should be able to work around it in the MediaWiki: namespace, but FYI: T364539: Protocol-relative URL in sidebar now interpreted as title (Query Service link in Wikidata sidebar broken)

Ladsgroup closed subtask T364538: Voting in U4C election is not possible anymore as Resolved.May 9 2024, 12:40 PM
thcipriani added a subtask: T364556: RuntimeException: Database serialization may cause problems, since the connection is not restored on wakeup.May 9 2024, 4:00 PM
Jdforrester-WMF closed subtask T364522: Internal error when trying to mark a page for translation not yet in translation system as Resolved.May 9 2024, 5:32 PM
matmarex closed subtask T364499: Flow\Exception\WikitextException: Conversion from 'wikitext' to 'topic-title-wikitext' was requested, but this is not supported. as Resolved.May 9 2024, 8:02 PM
gerritbot added a comment.May 9 2024, 8:02 PM

Change #1029704 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group2 wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1029704

gerritbot added a project: Patch-For-Review.May 9 2024, 8:02 PM

Change #1029704 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.43.0-wmf.4

https://gerrit.wikimedia.org/r/1029704

Stashbot added a comment.May 9 2024, 8:18 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-09T20:18:13Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.43.0-wmf.4 refs T361398

Maintenance_bot removed a project: Patch-For-Review.May 9 2024, 8:31 PM
Ladsgroup added a comment.May 10 2024, 9:31 AM

Funnily enough most (all?) of train blockers were not because of the hackathon

thcipriani closed this task as Resolved.May 10 2024, 6:21 PM
In T361398#9785389, @Ladsgroup wrote:

Funnily enough most (all?) of train blockers were not because of the hackathon

Success :)

It was a little bumpy this week, but wmf.4 is live everywhere now! Thanks all <3

thcipriani added a comment.May 10 2024, 11:19 PM

๐Ÿ“ˆ ๐“‡๐’ถ๐“ƒ๐’น๐‘œ๐“‚ ๐Ÿ…Ÿ๐Ÿ…ž๐Ÿ…ข๐Ÿ…ฃ-๐™ƒ๐˜ผ๐˜พ๐™†๐˜ผ๐™๐™ƒ๐™Š๐™‰ ๐Ÿ†‚๐Ÿ†ƒ๐Ÿ…ฐ๐Ÿ†ƒ๐Ÿ†‚

  • 487 Patches in 70 repos by 106 authors
  • 169 more patches than the previous week (53% increase)
  • 32% more patches than our average train
  • 4th most unique patch authors for any train since March 2016
Tacsipacsi mentioned this in T364681: Issues with translatable pages on Wikidata due to revision id overflow.May 11 2024, 6:51 PM
Aklapper moved this task from In progress to Done on the Release-Engineering-Team (Yakisfaction) board.May 13 2024, 9:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. ยท Wikimedia Foundation ยท Privacy Policy ยท Code of Conduct ยท Terms of Use ยท Disclaimer ยท CC-BY-SA ยท GPL ยท Credits