Internal error when trying to mark a page for translation not yet in translation system
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.43.0-wmf.4
reqId: e34e0aba-1d86-499a-9e29-a04d63b9661f
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   Error: Call to a member function makeGroupKeys() on null

exception.trace

from /srv/mediawiki/php-1.43.0-wmf.4/extensions/Translate/src/PageTranslation/TranslatablePageMarker.php(324)
#0 /srv/mediawiki/php-1.43.0-wmf.4/extensions/Translate/src/PageTranslation/PageTranslationSpecialPage.php(295): MediaWiki\Extension\Translate\PageTranslation\TranslatablePageMarker->markForTranslation(MediaWiki\Extension\Translate\PageTranslation\TranslatablePageMarkOperation, MediaWiki\Extension\Translate\PageTranslation\TranslatablePageSettings, MediaWiki\User\User)
#1 /srv/mediawiki/php-1.43.0-wmf.4/extensions/Translate/src/PageTranslation/PageTranslationSpecialPage.php(157): MediaWiki\Extension\Translate\PageTranslation\PageTranslationSpecialPage->onActionMark(MediaWiki\Title\Title, integer)
#2 /srv/mediawiki/php-1.43.0-wmf.4/includes/specialpage/SpecialPage.php(719): MediaWiki\Extension\Translate\PageTranslation\PageTranslationSpecialPage->execute(NULL)
#3 /srv/mediawiki/php-1.43.0-wmf.4/includes/specialpage/SpecialPageFactory.php(1672): MediaWiki\SpecialPage\SpecialPage->run(NULL)
#4 /srv/mediawiki/php-1.43.0-wmf.4/includes/actions/ActionEntryPoint.php(502): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#5 /srv/mediawiki/php-1.43.0-wmf.4/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#6 /srv/mediawiki/php-1.43.0-wmf.4/includes/MediaWikiEntryPoint.php(199): MediaWiki\Actions\ActionEntryPoint->execute()
#7 /srv/mediawiki/php-1.43.0-wmf.4/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#8 /srv/mediawiki/w/index.php(3): require(string)
#9 {main}

Impact

Pages not previously marked for translation cannot be marked for translation.

Notes

Steps to replicate the issue (include links if applicable):

Set up a page with Translate extension code
Attempt to mark for translation

What happens?:
Internal error:

What should have happened instead?:
Completion of setting up for translation.

Other information (browser name/version, screenshots, etc.):
Attempted in both Firefox and Safari for these two pages with same result:

Does not appear to be a problem with existing pages:

https://meta.wikimedia.org/w/index.php?title=Wikimedia_Foundation/Communications&diff=prev&oldid=26745341

Details

	Subject	Repo	Branch	Lines +/-
	Fix error when marking a new page for translations	mediawiki/extensions/Translate	wmf/1.43.0-wmf.4	+12 -8
	Fix error when marking a new page for translations	mediawiki/extensions/Translate	master	+12 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jeena	T361398 1.43.0-wmf.4 deployment blockers
		Resolved	PRODUCTION ERROR	abi_	T364522 Internal error when trying to mark a page for translation not yet in translation system

Event Timeline

Varnent created this task.May 9 2024, 5:58 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2024, 5:58 AM

Varnent triaged this task as Unbreak Now! priority.May 9 2024, 5:58 AM

Same issue on Meta-Wiki: https://meta.wikimedia.org/wiki/User:GVarnum-WMF/sandbox3

But not with this existing page: https://meta.wikimedia.org/w/index.php?title=Wikimedia_Foundation/Communications&diff=prev&oldid=26745341

Does happen on Meta-Wiki with "new" version of same page: https://meta.wikimedia.org/wiki/User:GVarnum-WMF/sandbox4

Varnent renamed this task from Internal error when trying to mark a page on Governance Wiki for translation to Internal error when trying to mark a page for translation not yet in translation system.May 9 2024, 6:02 AM

Varnent updated the task description. (Show Details)

Nikerabbit changed the subtype of this task from "Bug Report" to "Production Error".May 9 2024, 6:03 AM

Restricted Application added a project: Wikimedia-production-error. · View Herald TranscriptMay 9 2024, 6:03 AM

Nikerabbit updated the task description. (Show Details)May 9 2024, 6:04 AM

Nikerabbit added a project: Language-Team (Language-2024-April-June).

Thank you, @Nikerabbit, for quick response. Greatly appreciated! :)

I did wait like an hour between first seeing error, trying again, and reporting. So does not appear to be "momentary blip" - although could obviously be some sort of temporary server-side issue (although - sort of seems unlikely?)

Change #1029438 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Fix error when marking a new page for translations

https://gerrit.wikimedia.org/r/1029438

gerritbot added a project: Patch-For-Review.May 9 2024, 7:05 AM

Change #1029257 had a related patch set uploaded (by Abijeet Patro; author: Nikerabbit):

[mediawiki/extensions/Translate@wmf/1.43.0-wmf.4] Fix error when marking a new page for translations

https://gerrit.wikimedia.org/r/1029257

Nikerabbit updated the task description. (Show Details)May 9 2024, 7:18 AM

Change #1029438 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Fix error when marking a new page for translations

https://gerrit.wikimedia.org/r/1029438

Change #1029257 merged by jenkins-bot:

[mediawiki/extensions/Translate@wmf/1.43.0-wmf.4] Fix error when marking a new page for translations

https://gerrit.wikimedia.org/r/1029257

Mentioned in SAL (#wikimedia-operations) [2024-05-09T07:43:03Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:1029257|Fix error when marking a new page for translations (T364522)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-09T07:45:42Z] <zabe@deploy1002> zabe and abi: Backport for [[gerrit:1029257|Fix error when marking a new page for translations (T364522)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 9 2024, 8:00 AM

Mentioned in SAL (#wikimedia-operations) [2024-05-09T08:02:32Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:1029257|Fix error when marking a new page for translations (T364522)]] (duration: 19m 28s)

Hi @Varnent, thanks for reporting this issue. A fix has been deployed, and I verified from my side that it works. Let me know if you are still blocked.

abi_ moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.May 9 2024, 8:19 AM

Maintenance_bot removed a project: Patch-For-Review.May 9 2024, 8:31 AM

Aklapper added a parent task: T361398: 1.43.0-wmf.4 deployment blockers.May 9 2024, 9:27 AM

abi_ mentioned this in T364549: Argument 2 passed to TranslationPage::__construct() must be an instance of WikiPageMessageGroup, null given.May 9 2024, 2:29 PM

Jdforrester-WMF closed this task as Resolved.May 9 2024, 5:32 PM

Jdforrester-WMF claimed this task.

abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2024-April-June) board.May 10 2024, 9:27 AM

That worked - thank you! :)

Nikerabbit reassigned this task from Jdforrester-WMF to abi_.May 13 2024, 4:09 PM

Nikerabbit added a subscriber: Jdforrester-WMF.

Nikerabbit moved this task from Backlog to Translatable pages (LH1) on the Localization Infrastructure FY2023-24 board.May 30 2024, 12:42 PM

Pginer-WMF added a project: Regression.Jun 4 2024, 8:40 AM