Page MenuHomePhabricator

[QA task] UploadWizard - testing Describe step
Open, Needs TriagePublic

Assigned To
None
Authored By
Etonkovidova
May 9 2024, 11:43 PM
Referenced Files
F54258644: Screen Shot 2024-05-23 at 4.17.06 PM.png
May 23 2024, 11:35 PM
F54258637: Screen Shot 2024-05-23 at 4.16.51 PM.png
May 23 2024, 11:35 PM
F54255171: categories_draggable.gif
May 23 2024, 10:02 PM
F54254941: Screen Shot 2024-05-23 at 1.42.07 PM.png
May 23 2024, 10:02 PM
F54254561: Screen Shot 2024-05-23 at 1.45.04 PM.png
May 23 2024, 10:02 PM
F54254272: Screen Shot 2024-05-23 at 1.45.04 PM.png
May 23 2024, 10:02 PM
F54254105: Screen Shot 2024-05-23 at 2.28.50 PM.png
May 23 2024, 10:02 PM
F52011994: Screen Shot 2024-05-10 at 6.17.33 PM.png
May 11 2024, 1:24 AM

Description

(3) MediaWiki:Titleblacklist-forbidden-edit the text is not rendered correctly in the warning popup
Steps:

  • in the Describe step on Special:UploadWizard, enter one of the entries listed on MediaWiki:Titleblacklist in # Bad encoding or in # Spams in Korean sections.
  • the warning ""Please write a more informative title" appears. Click on "See examples"
  • the text in the popup warning displays not rendered text:
    Screen Shot 2024-05-23 at 1.45.04 PM.png (1×2 px, 1 MB)

(4) The documentation page - https://commons.wikimedia.org/wiki/Commons:First_steps/Uploading_files has a large font.

Screen Shot 2024-05-23 at 1.42.07 PM.png (1×2 px, 610 KB)

(5) Categories titles can be dragged - see the animated gif below

categories_draggable.gif (819×1 px, 107 KB)


DONE (addressed/resolved/discussed)

(1) ✅ RESOLVED (also added to T365662) The map icon is not aligned with the row (and is not displayed on a separate row as in commons wmf.6 (production))
I'm almost positive that on commons production the map icon was displayed on the same line as the text boxes for coordinates (under the label 'Optional'). Now, the map icon on commons production is displayed on a separate line - seems ok too.

beta commonscommons wmf.6 - current production
Screen Shot 2024-05-23 at 4.16.51 PM.png (1×1 px, 158 KB)
Screen Shot 2024-05-23 at 4.17.06 PM.png (1×1 px, 146 KB)

(2) ✅ RESOLVED (also see T365720: Typing quotes in filename prompt wrong error message in UploadWizard) The message "Please write a more informative title" is a generic message that is displayed to users for all kinds of non-informative titles. As it was reported Commons:Upload_Wizard_feedback#Some_glitches, it might be confusing for users to realize what needs to be done to make a title informative.
Steps

  • a user types a pair of single quotes around a title or some words in a title (keeping in mind the wiki markup for italic).
  • a user gets "Please write a more informative title" warning

Screen Shot 2024-05-23 at 2.28.50 PM.png (1×2 px, 885 KB)

  • if users do not click on the link in the warning "See examples" , the issue with writing a more informative title cannot be resolved. The popup provides clear instructions to remove apostrophes (consecutive single quotes).

Screen Shot 2024-05-23 at 1.45.04 PM.png (1×2 px, 1 MB)

What should happen: The warning message should be more specific in giving users guidance what to do.

(6) ✅ (filed as T364659 ) Add a caption in another language ** is displayed in blue not as in figma design

figma designcommons beta
Screen Shot 2024-05-09 at 4.16.45 PM.png (222×607 px, 13 KB)
Screen Shot 2024-05-09 at 4.19.32 PM.png (476×1 px, 39 KB)

(7) ✅ (this is expected behavior )Tip is displayed in red

figma designcommons beta
Screen Shot 2024-05-09 at 3.14.43 PM.png (806×1 px, 90 KB)
Screen Shot 2024-05-09 at 3.13.38 PM.png (538×1 px, 149 KB)

(8) ✅ (the popup was removed ) The popup wording doesn't quite match the new workflow

  • a user uploads a file vis Special:UploadWizard
  • an automatically assigned title doesn't produce a warning for providing more descriptive title
  • a user fills in Caption (and Description if "Same as Caption" checkbox is not checked)
  • other fields are optional, so a user hits "Publish files"
  • a warning appears and suggests to correct warnings
    Screen Shot 2024-05-10 at 6.17.33 PM.png (1×1 px, 170 KB)
  • a user checks and sees no warnings present

Event Timeline

@Etonkovidova thanks for capturing these details. The first one should be fixed. But second one is correct it was changed to all red after Marco informed me that having two different styling in the same line was not easily feasible. I updated my wireframes now too. Sorry for not updating it earlier.

@Etonkovidova thanks for capturing these details. The first one should be fixed. But second one is correct it was changed to all red after Marco informed me that having two different styling in the same line was not easily feasible. I updated my wireframes now too. Sorry for not updating it earlier.

Thank you, @Sneha! I filed #1 as T364659: [S] UploadWizard - Describe step: change font color for 'Add a caption in another language' buttons

@Etonkovidova Regarding #3, I did not know about this warning so thanks for capturing this. Since we are clearly saying categories are optional it does not make sense to have this warning and dialog. I added a note on the categories ticket to make sure to remove. See comment here.

Re: the comment below, I think if the warning is not being shown after hitting next on the describe step then it should be filed as a bug. Unless the algorithm to detect descriptive title does not work as expected then it is a different issue and different bug.

an automatically assigned title doesn't produce a warning for providing more descritive title

@Etonkovidova Regarding #3, I did not know about this warning so thanks for capturing this. Since we are clearly saying categories are optional it does not make sense to have this warning and dialog. I added a note on the categories ticket to make sure to remove. See comment here.

Thx, @Sneha!

Re: the comment below, I think if the warning is not being shown after hitting next on the describe step then it should be filed as a bug. Unless the algorithm to detect descriptive title does not work as expected then it is a different issue and different bug.

an automatically assigned title doesn't produce a warning for providing more descriptive title

It could be a sort of limitation on commons beta. However, I agree that it should be filed as a separate bug - filed as T364794: [beta] UploadWizard - Describe step: the warning about a title not being descriptive enough should be present.