Night mode exclude list doesn't appear to be working with various pages (including Special:AbuseLog or diff pages)
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Izno
	May 15 2024, 11:42 PM

Project Tags

Referenced Files

	F54576923: screenshot 380.png
	May 28 2024, 11:59 PM

	F54577092: screenshot 385.png
	May 28 2024, 11:59 PM

	F54577084: screenshot 384.png
	May 28 2024, 11:59 PM

	F54577080: screenshot 383.png
	May 28 2024, 11:59 PM

	F54577073: screenshot 382.png
	May 28 2024, 11:59 PM

	F54577064: screenshot 381.png
	May 28 2024, 11:59 PM

	F54576919: screenshot 379.png
	May 28 2024, 11:59 PM

	F54576909: screenshot 378.png
	May 28 2024, 11:59 PM

Subscribers

Description

Despite this page being configured to disable night mode, it still appears with the night mode option available:
https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/c3fad820c45104565739853cef9c6c03a4e4a269/wmf-config/skin-Minerva.php#160

Steps to replicate the issue (include links if applicable):

Set $wgMinervaNightModeOptions['exclude']['pagetitles'] = [ 'Special:AbuseLog' ];
Visit https://en.wikipedia.org/wiki/Special:AbuseLog/37755352 or other abuselog entry

What happens?:
The page appears in night mode.

Action parameters unreadable

What should have happened instead?:
Night mode should be disabled on this page (as it features OOUI elements which is blocked on T363849)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Also applies to:

Requirement

Ensure that night mode is correctly excluded from specified pages including Special:AbuseLog, diff pages, and other special pages to maintain readability and usability.

BDD

Feature: Exclude Night Mode from Specified Pages

  Scenario: Night mode excluded on Special:AbuseLog
    Given the user is viewing the Special:AbuseLog page
    When night mode is enabled
    Then night mode should be disabled on this page

  Scenario: Night mode excluded on diff pages
    Given the user is viewing a diff page
    When night mode is enabled
    Then night mode should be disabled on this page

  Scenario: Night mode excluded on specified special pages
    Given the user is viewing a specified special page
    When night mode is enabled
    Then night mode should be disabled on the following pages:
      | https://en.wikipedia.org/w/index.php?title=Special:Watchlist    |
      | https://en.wikipedia.org/wiki/Special:ProtectedPages            |
      | https://en.wikipedia.org/wiki/Special:Recentchanges             |
      | https://en.wikipedia.org/wiki/Special:Recentchangeslinked       |
      | https://en.wikipedia.org/wiki/Special:AllMessages               |
      | https://en.wikipedia.org/wiki/Special:EditWatchlist             |
    And night mode should be enabled on the following pages:
      | https://en.wikipedia.org/wiki/Special:ProtectedTitles            |

Test Steps

Test Case 1: Night Mode Excluded on Special:AbuseLog

Ensure night mode is enabled.
Open the URL for Special:AbuseLog: https://en.wikipedia.org/wiki/Special:AbuseLog/37755352.
AC1 Confirm that night mode is disabled on the Special:AbuseLog page.

Test Case 2: Night Mode Excluded on Diff Pages

Ensure night mode is enabled.
Open the URL for a diff page: https://en.wikipedia.org/w/index.php?title=Main_Page&diff=1223300368&oldid=1212457119.
AC2 Confirm that night mode is disabled on the diff page.

Test Case 3: Night Mode Excluded on Specified Special Pages

Ensure night mode is enabled.
Open the following URLs one by one:

We will keep the following pages with dark mode since they have no color contrast issues:

- https://en.wikipedia.org/wiki/Special:ProtectedTitles
AC3 Confirm that night mode is disabled on each of these pages (ProtectedTitles should be enabled).

QA Results - Prod

AC	Status	Details
1	✅	T365084#9840543
2	✅	T365084#9840543
3	✅	T365084#9840543

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
Cleanup night mode exclude list	Jdlrobson	operations/mediawiki-config	master	+12 -59
Fix exclude list for dark mode	Mabualruz	operations/mediawiki-config	master	+10 -5
Correct behaviour of ConfigHelper, add tests	Mabualruz	mediawiki/skins/Vector	wmf/1.43.0-wmf.4	+47 -14
Correct behaviour of ConfigHelper, add tests	Mabualruz	mediawiki/skins/Vector	wmf/1.43.0-wmf.5	+47 -14
Correct behaviour of ConfigHelper, add tests	Jdlrobson	mediawiki/skins/Vector	master	+47 -14

Customize query in gerrit

Related Objects

Mentioned In: T365071: Special:NewPagesFeed colors are not adjusted for DarkMode
Mentioned Here: T363849: [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens

Event Timeline

Izno created this task.May 15 2024, 11:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2024, 11:42 PM

Looks like we missed this page as one of the pages where dark mode should have been disabled.

Seawolf35 subscribed.May 15 2024, 11:54 PM

Jdlrobson renamed this task from Edit filter needs dark cleanup to Night mode exclude list doesn't work with subpages..May 15 2024, 11:54 PM

Jdlrobson edited projects, added: Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4); removed: AbuseFilter.

Jdlrobson updated the task description. (Show Details)

Do you intend to enable it at some point...? I am generally finding the color flip outside of mainspace to be annoying.

I updated description with details - basically OOUI still hasn't been ported to dark mode so any OOUI interface is broken by default. We're working on it and this page should have been disabled until that happened. I'm not sure why this is not working as expected and that's troubling... but thanks for bug report. We'll look into it.

Jdlrobson renamed this task from Night mode exclude list doesn't appear to be working with Special:AbuseLog to Night mode exclude list doesn't appear to be working with Special:AbuseLog or diff pages.May 16 2024, 12:59 AM

Jdlrobson updated the task description. (Show Details)

Jdlrobson renamed this task from Night mode exclude list doesn't appear to be working with Special:AbuseLog or diff pages to Night mode exclude list doesn't appear to be working with various pages (including Special:AbuseLog or diff pages).May 16 2024, 4:04 AM

Jdlrobson updated the task description. (Show Details)

Change #1032115 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032115

gerritbot added a project: Patch-For-Review.May 16 2024, 4:25 AM

Change #1032126 had a related patch set uploaded (by Mabualruz; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.5] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032126

Change #1032126 abandoned by Mabualruz:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.5] Correct behaviour of ConfigHelper, add tests

Reason:

Wrong target branch

https://gerrit.wikimedia.org/r/1032126

Change #1032128 had a related patch set uploaded (by Mabualruz; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.4] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032128

Change #1032126 restored by Mabualruz:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.5] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032126

Change #1032115 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032115

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 16 2024, 7:00 AM

Change #1032126 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.5] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032126

Mentioned in SAL (#wikimedia-operations) [2024-05-16T07:26:40Z] <mabualruz@deploy1002> Started scap: Backport for [[gerrit:1032126|Correct behaviour of ConfigHelper, add tests (T365084)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-16T07:29:59Z] <mabualruz@deploy1002> mabualruz: Backport for [[gerrit:1032126|Correct behaviour of ConfigHelper, add tests (T365084)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-16T07:44:11Z] <mabualruz@deploy1002> Finished scap: Backport for [[gerrit:1032126|Correct behaviour of ConfigHelper, add tests (T365084)]] (duration: 17m 31s)

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14); removed: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 16 2024, 8:00 AM

Change #1032128 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.4] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032128

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07); removed: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 16 2024, 9:00 AM

Change #1032398 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[operations/mediawiki-config@master] Add Watchlist to exclude list from dark mode

https://gerrit.wikimedia.org/r/1032398

Jdlrobson updated the task description. (Show Details)May 16 2024, 1:44 PM

ovasileva edited projects, added: Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 3); removed: Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4).May 16 2024, 3:39 PM

ovasileva set the point value for this task to 1.May 16 2024, 5:19 PM

Jdlrobson assigned this task to Edtadros.May 16 2024, 5:37 PM

Jdlrobson moved this task from Backlog to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 3) board.

Change #1032398 merged by jenkins-bot:

[operations/mediawiki-config@master] Fix exclude list for dark mode

https://gerrit.wikimedia.org/r/1032398

Mentioned in SAL (#wikimedia-operations) [2024-05-16T20:08:26Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1032398|Fix exclude list for dark mode (T365084)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-16T20:11:04Z] <jdrewniak@deploy1002> jdrewniak and mabualruz: Backport for [[gerrit:1032398|Fix exclude list for dark mode (T365084)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-16T20:31:03Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1032398|Fix exclude list for dark mode (T365084)]] (duration: 22m 36s)

Edtadros updated the task description. (Show Details)May 20 2024, 4:55 PM

Jdlrobson edited projects, added: Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4); removed: Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 3).May 20 2024, 5:29 PM

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4) board.May 20 2024, 5:29 PM

Test Result - Prod

Status: ❌ FAIL
Environment: Prod
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Night Mode Excluded on Special:AbuseLog

Ensure night mode is enabled.
Open the URL for Special:AbuseLog: https://en.wikipedia.org/wiki/Special:AbuseLog/37755352.
✅ AC1 Confirm that night mode is disabled on the Special:AbuseLog page.

screenshot 76.mov.gif (1,296×944 px, 785 KB)

Test Case 2: Night Mode Excluded on Diff Pages

Ensure night mode is enabled.
Open the URL for a diff page: https://en.wikipedia.org/w/index.php?title=Main_Page&diff=1223300368&oldid=1212457119.
✅ AC2 Confirm that night mode is disabled on the diff page.

screenshot 77.mov.gif (1,296×944 px, 934 KB)

Test Case 3: Night Mode Excluded on Specified Special Pages

Ensure night mode is enabled.
Open the following URLs one by one:
❌ AC3 Confirm that night mode is disabled on each of these pages.

✅ https://en.wikipedia.org/w/index.php?title=Special:Watchlist

screenshot 78.mov.gif (1,296×944 px, 1 MB)

❌ https://en.wikipedia.org/wiki/Special:ProtectedPages

screenshot 79.mov.gif (1,296×944 px, 1 MB)

❌ https://en.wikipedia.org/wiki/Special:ProtectedTitles

screenshot 84.mov.gif (1,296×944 px, 1 MB)

✅ https://en.wikipedia.org/wiki/Special:Recentchanges

screenshot 80.mov.gif (1,296×944 px, 1 MB)

✅ https://en.wikipedia.org/wiki/Special:Recentchangeslinked

screenshot 81.mov.gif (1,296×944 px, 1 MB)

❌ https://en.wikipedia.org/wiki/Special:AllMessages

screenshot 82.mov.gif (1,296×944 px, 1 MB)

✅ https://en.wikipedia.org/wiki/Special:EditWatchlist

screenshot 83.mov.gif (1,296×944 px, 1 MB)

Jdlrobson claimed this task.May 21 2024, 4:26 PM

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4) board.

Jdlrobson updated the task description. (Show Details)May 21 2024, 4:38 PM

Change #1034545 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Cleanup night mode exclude list

https://gerrit.wikimedia.org/r/1034545

Jdlrobson mentioned this in T365071: Special:NewPagesFeed colors are not adjusted for DarkMode.May 21 2024, 5:23 PM

Jdlrobson moved this task from Backlog to Excluded experiences on the FY2023-24-WE 2.1 Typography and palette customizations board.

Jdlrobson moved this task from Excluded experiences to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.

Change #1034545 merged by jenkins-bot:

[operations/mediawiki-config@master] Cleanup night mode exclude list

https://gerrit.wikimedia.org/r/1034545

Mentioned in SAL (#wikimedia-operations) [2024-05-21T20:08:10Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:1034545|Cleanup night mode exclude list (T365084)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-21T20:10:53Z] <jforrester@deploy1002> jforrester and jdlrobson: Backport for [[gerrit:1034545|Cleanup night mode exclude list (T365084)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Jdlrobson moved this task from Doing to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4) board.May 21 2024, 8:20 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-21T20:27:42Z] <jforrester@deploy1002> Finished scap: Backport for [[gerrit:1034545|Cleanup night mode exclude list (T365084)]] (duration: 19m 32s)

Jdlrobson reassigned this task from Jdlrobson to Edtadros.May 23 2024, 4:56 PM

Test Result - Prod

Status: ✅ Pass
Environment: Prod
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Night Mode Excluded on Special:AbuseLog

Ensure night mode is enabled.
Open the URL for Special:AbuseLog: https://en.wikipedia.org/wiki/Special:AbuseLog/37755352.
✅ AC1 Confirm that night mode is disabled on the Special:AbuseLog page.

screenshot 377.png (1,489×719 px, 177 KB)

Test Case 2: Night Mode Excluded on Diff Pages

Ensure night mode is enabled.
Open the URL for a diff page: https://en.wikipedia.org/w/index.php?title=Main_Page&diff=1223300368&oldid=1212457119.
✅ AC2 Confirm that night mode is disabled on the diff page.