Page MenuHomePhabricator

Night mode exclude list doesn't appear to be working with various pages (including Special:AbuseLog or diff pages)
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Assigned To
Authored By
Izno
May 15 2024, 11:42 PM
Referenced Files
F54576923: screenshot 380.png
Tue, May 28, 11:59 PM
F54577092: screenshot 385.png
Tue, May 28, 11:59 PM
F54577084: screenshot 384.png
Tue, May 28, 11:59 PM
F54577080: screenshot 383.png
Tue, May 28, 11:59 PM
F54577073: screenshot 382.png
Tue, May 28, 11:59 PM
F54577064: screenshot 381.png
Tue, May 28, 11:59 PM
F54576919: screenshot 379.png
Tue, May 28, 11:59 PM
F54576909: screenshot 378.png
Tue, May 28, 11:59 PM

Description

Despite this page being configured to disable night mode, it still appears with the night mode option available:
https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/c3fad820c45104565739853cef9c6c03a4e4a269/wmf-config/skin-Minerva.php#160

Steps to replicate the issue (include links if applicable):

What happens?:
The page appears in night mode.

image.png (366×1 px, 43 KB)

Action parameters unreadable
image.png (373×1 px, 24 KB)

What should have happened instead?:
Night mode should be disabled on this page (as it features OOUI elements which is blocked on T363849)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Also applies to:

Requirement

Ensure that night mode is correctly excluded from specified pages including Special:AbuseLog, diff pages, and other special pages to maintain readability and usability.

BDD

Feature: Exclude Night Mode from Specified Pages

  Scenario: Night mode excluded on Special:AbuseLog
    Given the user is viewing the Special:AbuseLog page
    When night mode is enabled
    Then night mode should be disabled on this page

  Scenario: Night mode excluded on diff pages
    Given the user is viewing a diff page
    When night mode is enabled
    Then night mode should be disabled on this page

  Scenario: Night mode excluded on specified special pages
    Given the user is viewing a specified special page
    When night mode is enabled
    Then night mode should be disabled on the following pages:
      | https://en.wikipedia.org/w/index.php?title=Special:Watchlist    |
      | https://en.wikipedia.org/wiki/Special:ProtectedPages            |
      | https://en.wikipedia.org/wiki/Special:Recentchanges             |
      | https://en.wikipedia.org/wiki/Special:Recentchangeslinked       |
      | https://en.wikipedia.org/wiki/Special:AllMessages               |
      | https://en.wikipedia.org/wiki/Special:EditWatchlist             |
    And night mode should be enabled on the following pages:
      | https://en.wikipedia.org/wiki/Special:ProtectedTitles            |

Test Steps

Test Case 1: Night Mode Excluded on Special:AbuseLog

  1. Ensure night mode is enabled.
  2. Open the URL for Special:AbuseLog: https://en.wikipedia.org/wiki/Special:AbuseLog/37755352.
  3. AC1 Confirm that night mode is disabled on the Special:AbuseLog page.

Test Case 2: Night Mode Excluded on Diff Pages

  1. Ensure night mode is enabled.
  2. Open the URL for a diff page: https://en.wikipedia.org/w/index.php?title=Main_Page&diff=1223300368&oldid=1212457119.
  3. AC2 Confirm that night mode is disabled on the diff page.

Test Case 3: Night Mode Excluded on Specified Special Pages

  1. Ensure night mode is enabled.
  2. Open the following URLs one by one:

We will keep the following pages with dark mode since they have no color contrast issues:

  1. AC3 Confirm that night mode is disabled on each of these pages (ProtectedTitles should be enabled).

QA Results - Prod

ACStatusDetails
1T365084#9840543
2T365084#9840543
3T365084#9840543

Event Timeline

Looks like we missed this page as one of the pages where dark mode should have been disabled.

Jdlrobson renamed this task from Edit filter needs dark cleanup to Night mode exclude list doesn't work with subpages..May 15 2024, 11:54 PM
Jdlrobson updated the task description. (Show Details)

Do you intend to enable it at some point...? I am generally finding the color flip outside of mainspace to be annoying.

Jdlrobson renamed this task from Night mode exclude list doesn't work with subpages. to Night mode exclude list doesn't appear to be working with Special:AbuseLog.May 15 2024, 11:56 PM
Jdlrobson triaged this task as High priority.
Jdlrobson updated the task description. (Show Details)

I updated description with details - basically OOUI still hasn't been ported to dark mode so any OOUI interface is broken by default. We're working on it and this page should have been disabled until that happened. I'm not sure why this is not working as expected and that's troubling... but thanks for bug report. We'll look into it.

Jdlrobson renamed this task from Night mode exclude list doesn't appear to be working with Special:AbuseLog to Night mode exclude list doesn't appear to be working with Special:AbuseLog or diff pages.May 16 2024, 12:59 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from Night mode exclude list doesn't appear to be working with Special:AbuseLog or diff pages to Night mode exclude list doesn't appear to be working with various pages (including Special:AbuseLog or diff pages).May 16 2024, 4:04 AM
Jdlrobson updated the task description. (Show Details)

Change #1032115 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032115

Change #1032126 had a related patch set uploaded (by Mabualruz; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.5] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032126

Change #1032126 abandoned by Mabualruz:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.5] Correct behaviour of ConfigHelper, add tests

Reason:

Wrong target branch

https://gerrit.wikimedia.org/r/1032126

Change #1032128 had a related patch set uploaded (by Mabualruz; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.4] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032128

Change #1032126 restored by Mabualruz:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.5] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032126

Change #1032115 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032115

Change #1032126 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.5] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032126

Mentioned in SAL (#wikimedia-operations) [2024-05-16T07:26:40Z] <mabualruz@deploy1002> Started scap: Backport for [[gerrit:1032126|Correct behaviour of ConfigHelper, add tests (T365084)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-16T07:29:59Z] <mabualruz@deploy1002> mabualruz: Backport for [[gerrit:1032126|Correct behaviour of ConfigHelper, add tests (T365084)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-16T07:44:11Z] <mabualruz@deploy1002> Finished scap: Backport for [[gerrit:1032126|Correct behaviour of ConfigHelper, add tests (T365084)]] (duration: 17m 31s)

Change #1032128 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.4] Correct behaviour of ConfigHelper, add tests

https://gerrit.wikimedia.org/r/1032128

Change #1032398 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[operations/mediawiki-config@master] Add Watchlist to exclude list from dark mode

https://gerrit.wikimedia.org/r/1032398

ovasileva set the point value for this task to 1.May 16 2024, 5:19 PM

Change #1032398 merged by jenkins-bot:

[operations/mediawiki-config@master] Fix exclude list for dark mode

https://gerrit.wikimedia.org/r/1032398

Mentioned in SAL (#wikimedia-operations) [2024-05-16T20:08:26Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1032398|Fix exclude list for dark mode (T365084)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-16T20:11:04Z] <jdrewniak@deploy1002> jdrewniak and mabualruz: Backport for [[gerrit:1032398|Fix exclude list for dark mode (T365084)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-16T20:31:03Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1032398|Fix exclude list for dark mode (T365084)]] (duration: 22m 36s)

Edtadros subscribed.

Test Result - Prod

Status: ❌ FAIL
Environment: Prod
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Night Mode Excluded on Special:AbuseLog

  1. Ensure night mode is enabled.
  2. Open the URL for Special:AbuseLog: https://en.wikipedia.org/wiki/Special:AbuseLog/37755352.
  3. AC1 Confirm that night mode is disabled on the Special:AbuseLog page.

screenshot 76.mov.gif (944×1 px, 785 KB)

Test Case 2: Night Mode Excluded on Diff Pages

  1. Ensure night mode is enabled.
  2. Open the URL for a diff page: https://en.wikipedia.org/w/index.php?title=Main_Page&diff=1223300368&oldid=1212457119.
  3. AC2 Confirm that night mode is disabled on the diff page.

screenshot 77.mov.gif (944×1 px, 934 KB)

Test Case 3: Night Mode Excluded on Specified Special Pages

  1. Ensure night mode is enabled.
  2. Open the following URLs one by one:
  3. AC3 Confirm that night mode is disabled on each of these pages.

https://en.wikipedia.org/w/index.php?title=Special:Watchlist

screenshot 78.mov.gif (944×1 px, 1 MB)

https://en.wikipedia.org/wiki/Special:ProtectedPages
screenshot 79.mov.gif (944×1 px, 1 MB)

https://en.wikipedia.org/wiki/Special:ProtectedTitles
screenshot 84.mov.gif (944×1 px, 1 MB)

https://en.wikipedia.org/wiki/Special:Recentchanges
screenshot 80.mov.gif (944×1 px, 1 MB)

https://en.wikipedia.org/wiki/Special:Recentchangeslinked
screenshot 81.mov.gif (944×1 px, 1 MB)

https://en.wikipedia.org/wiki/Special:AllMessages
screenshot 82.mov.gif (944×1 px, 1 MB)

https://en.wikipedia.org/wiki/Special:EditWatchlist
screenshot 83.mov.gif (944×1 px, 1 MB)

Change #1034545 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Cleanup night mode exclude list

https://gerrit.wikimedia.org/r/1034545

Change #1034545 merged by jenkins-bot:

[operations/mediawiki-config@master] Cleanup night mode exclude list

https://gerrit.wikimedia.org/r/1034545

Mentioned in SAL (#wikimedia-operations) [2024-05-21T20:08:10Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:1034545|Cleanup night mode exclude list (T365084)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-21T20:10:53Z] <jforrester@deploy1002> jforrester and jdlrobson: Backport for [[gerrit:1034545|Cleanup night mode exclude list (T365084)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-21T20:27:42Z] <jforrester@deploy1002> Finished scap: Backport for [[gerrit:1034545|Cleanup night mode exclude list (T365084)]] (duration: 19m 32s)

Test Result - Prod

Status: ✅ Pass
Environment: Prod
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Night Mode Excluded on Special:AbuseLog

  1. Ensure night mode is enabled.
  2. Open the URL for Special:AbuseLog: https://en.wikipedia.org/wiki/Special:AbuseLog/37755352.
  3. AC1 Confirm that night mode is disabled on the Special:AbuseLog page.

screenshot 377.png (719×1 px, 177 KB)

Test Case 2: Night Mode Excluded on Diff Pages

  1. Ensure night mode is enabled.
  2. Open the URL for a diff page: https://en.wikipedia.org/w/index.php?title=Main_Page&diff=1223300368&oldid=1212457119.
  3. AC2 Confirm that night mode is disabled on the diff page.

screenshot 378.png (719×1 px, 177 KB)

Test Case 3: Night Mode Excluded on Specified Special Pages

  1. Ensure night mode is enabled.
  2. Open the following URLs one by one:
  3. AC3 Confirm that night mode is disabled on each of these pages.

https://en.wikipedia.org/w/index.php?title=Special:Watchlist

screenshot 379.png (719×1 px, 202 KB)

https://en.wikipedia.org/wiki/Special:ProtectedPages
screenshot 381.png (719×1 px, 131 KB)

https://en.wikipedia.org/wiki/Special:Recentchanges
screenshot 382.png (719×1 px, 230 KB)

https://en.wikipedia.org/wiki/Special:Recentchangeslinked
screenshot 383.png (719×1 px, 147 KB)

https://en.wikipedia.org/wiki/Special:AllMessages
screenshot 384.png (719×1 px, 132 KB)

https://en.wikipedia.org/wiki/Special:EditWatchlist
screenshot 385.png (719×1 px, 169 KB)

✅ This page should be in darkmode: https://en.wikipedia.org/wiki/Special:ProtectedTitles
screenshot 380.png (719×1 px, 138 KB)

Edtadros updated the task description. (Show Details)