Page MenuHomePhabricator

Special:NewPagesFeed colors are not adjusted for DarkMode
Open, MediumPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to Special:NewPagesFeed with dark mode enabled (Beta Features -> Accessibility for Reading (Vector 2022) --> Color --> Dark)

https://test.wikipedia.org/wiki/Special:NewPagesFeed

What happens?:

Screenshot from 2024-05-15 17-06-17.png (412×1 px, 94 KB)

What should have happened instead?:
Colors should be adjusted for dark mode

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Might be because we're not using a Codex token for that color. Reverting https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/988152 might fix this, but would cause T351460#9392444 again.

Note, as part of T365084 night theme has been disabled on this page in production. We do not disable night theme on test Wikipedia or beta cluster, to support preparing it. Let us know when the page is ready for the night theme and we can change the configuration.

Jdlrobson triaged this task as Medium priority.Fri, May 31, 4:49 PM
Jdlrobson updated the task description. (Show Details)

@Novem_Linguae we are aiming to deploy dark mode to all wikis on 16th July. Do you need any help working out what to do for this ticket?

@Novem_Linguae we are aiming to deploy dark mode to all wikis on 16th July. Do you need any help working out what to do for this ticket?

I believe we are at a bit of a technical impasse with this one, the color that we need is a darker shade of grey (the exact color that we need is darken( @background-color-interactive-subtle, 1% )). However, that is currently impossible since the less variables are all CSS variables and not exact colors. Any guidance on this would be great.

@Novem_Linguae we are aiming to deploy dark mode to all wikis on 16th July. Do you need any help working out what to do for this ticket?

I believe we are at a bit of a technical impasse with this one, the color that we need is a darker shade of grey (the exact color that we need is darken( @background-color-interactive-subtle, 1% )). However, that is currently impossible since the less variables are all CSS variables and not exact colors. Any guidance on this would be great.

Why is that exact color needed? Are there social or technical reasons it cannot be changed to @background-color-interactive-subtle? It wasn't clear to me from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/988152/ ("I could barely distinguish the old color from white.")

I think you could achieve the same end result by mixing opacity with @background-color-interactive-subtle?

Alternatively, if you feel strongly about using the hardcoded value you can just add the following CSS to limit the use of the token to dark mode:

html.skin-theme-clientpref-night {
    .mwe-vue-pt-article-row-even {
        background: @background-color-interactive-subtle;
    }
}
@media (prefers-color-scheme: dark) {
  html.skin-theme-clientpref-os {
    .mwe-vue-pt-article-row-even {
        background: @background-color-interactive-subtle;
    }
  }
}

If you are able to post a patch for this by end of day Monday, I can personally make sure it will go into the initial dark mode release!

Change #1050299 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Make odd-even banding compatible with dark mode

https://gerrit.wikimedia.org/r/1050299

Change #1050299 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Make odd-even banding compatible with dark mode

https://gerrit.wikimedia.org/r/1050299

Change #1049975 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable special pages in dark mode (1.43.0-wmf.12)

https://gerrit.wikimedia.org/r/1049975

Change #1049975 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)

Reason:

Moved into https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1050671?usp=search

https://gerrit.wikimedia.org/r/1049975