Page MenuHomePhabricator
Create Task
Maniphest T365107

UploadWizard gives the same automatic number when uploading medias with same name
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • I upload medias through UploadWizard
  • I put the same name to them, counting on the fact that automatic numeration would tell them apart

What happens?:
The Wizard gives the same number to all the medias, triggering a "duplicate file name" error.

What should have happened instead?:
The Wizard should have given automatic numeration to the medias.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Wikimedia Commons

Other information (browser name/version, screenshots, etc.):
Reformulated by this discussion.

Details

SubjectRepoBranchLines +/-
Fix automatic numbering of copied titlesmediawiki/extensions/UploadWizardwmf/1.43.0-wmf.5+4 -3
Fix automatic numbering of copied titlesmediawiki/extensions/UploadWizardmaster+4 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sannita created this task.Thu, May 16, 8:55 AM
gerritbot added a comment.Fri, May 17, 7:43 AM

Change #1032635 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Fix automatic numbering of copied titles

https://gerrit.wikimedia.org/r/1032635

gerritbot added a project: Patch-For-Review.Fri, May 17, 7:43 AM
matthiasmullie claimed this task.Fri, May 17, 7:43 AM
matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Mon, May 20, 9:18 AM

Change #1032635 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Fix automatic numbering of copied titles

https://gerrit.wikimedia.org/r/1032635

Maintenance_bot removed a project: Patch-For-Review.Mon, May 20, 9:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).Mon, May 20, 10:00 AM
Cparle moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Mon, May 20, 3:31 PM
gerritbot added a comment.Mon, May 20, 6:51 PM

Change #1032823 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@wmf/1.43.0-wmf.5] Fix automatic numbering of copied titles

https://gerrit.wikimedia.org/r/1032823

gerritbot added a project: Patch-For-Review.Mon, May 20, 6:51 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Mon, May 20, 7:33 PM
Etonkovidova subscribed.

Works as expected on commons beta.
Note to clarify the steps:

  • Upload multiple files
  • In the Describe step, fill in a title for the first uploaded file
  • Click on "Copy information to all uploads following...", make sure that " Copy title (with automatic numbering)" is checked

The file titles in the upload should display the same title as the first file but with numbering.
Currently, in production (commons wmf.5) checking " Copy title (with automatic numbering)" will assign the same title to all files in the upload.

gerritbot added a comment.Tue, May 21, 7:46 AM

Change #1032823 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@wmf/1.43.0-wmf.5] Fix automatic numbering of copied titles

https://gerrit.wikimedia.org/r/1032823

Stashbot added a comment.Tue, May 21, 7:47 AM

Mentioned in SAL (#wikimedia-operations) [2024-05-21T07:47:10Z] <mlitn@deploy1002> Started scap: Backport for [[gerrit:1032823|Fix automatic numbering of copied titles (T365107)]]

Stashbot added a comment.Tue, May 21, 7:49 AM

Mentioned in SAL (#wikimedia-operations) [2024-05-21T07:49:50Z] <mlitn@deploy1002> mlitn: Backport for [[gerrit:1032823|Fix automatic numbering of copied titles (T365107)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.5; 2024-05-14); removed MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).Tue, May 21, 8:00 AM
Stashbot added a comment.Tue, May 21, 8:04 AM

Mentioned in SAL (#wikimedia-operations) [2024-05-21T08:04:13Z] <mlitn@deploy1002> Finished scap: Backport for [[gerrit:1032823|Fix automatic numbering of copied titles (T365107)]] (duration: 17m 02s)

Maintenance_bot removed a project: Patch-For-Review.Tue, May 21, 8:30 AM
AUgolnikova-WMF added a parent task: T358765: [EPIC] Describe step UX improvements in the UW on Commons.Wed, May 22, 1:12 PM
Etonkovidova closed this task as Resolved.Thu, May 23, 12:53 AM

Checked in commons wmf.6 - the issue is fixed.

Kritzolina subscribed.Fri, May 31, 12:52 PM

I still experience this issue on my Windows laptop running on Windows 10 pro.

Etonkovidova added a comment.Fri, May 31, 11:00 PM
In T365107#9849977, @Kritzolina wrote:

I still experience this issue on my Windows laptop running on Windows 10 pro.

Thank you, @Kritzolina for reporting! Could you provide the steps you used?

The test scenario that was checked for this task:

  • multiple files are uploaded
  • in the Describe step, a title is entered (or an automatically generated title is left without changes) for the first file
  • then, the next action is clicking on "Copy information to all uploads following..." and making sure that "Copy title (with automatic numbering)" is enabled (it should be checked)
  • after that click on the Copy button - the "Copied!" confirmation appears. The files' titles will have the added numbering, i.e. 02, 03 etc are added to the the first file title.

Screen Shot 2024-05-31 at 3.56.46 PM.png (1×1 px, 505 KB)

Kritzolina added a comment.EditedSat, Jun 1, 2:34 PM

Hi @Etonkovidova,

these are exactly the steps I usually take -

  1. I upload 2 - 20 files that have the same subject, so they should have the same file name with added numbers
  2. I enter the appropriate title in the title field, choose a caption and description, categories and whatever else is needed
  3. I click on "Copy information to all uploads following..." and check if all relevant boxes are checked, including the "Copy title (with automatic numbering)" box and then click on copy

After processing I get the same file name for all the images, including the same (the highest) number. E.g. I uploaded 7 files showing the same person at an event this morning, all had the title "Stella Nyanzi at Republica 2024 07" and I had to manually change the numbers. I just tried it without the 2024 and the same thing happened with two files, both called "Saskia Esken at Republica 02", until I manually called one of them "Saskia Esken at Republica 01".

This happened with all my uploads since the error first occurred - I saw you were working on it, but missed the message that is was marked resolved. For me it is definitely not resolved, sorry to say. Thank you very much for looking into it!

Kritzolina added a comment.Sun, Jun 2, 2:54 PM

... and after an update this morning the issue seems to be resolved, sorry for bothering you!

Etonkovidova added a comment.Mon, Jun 3, 5:57 PM
In T365107#9852706, @Kritzolina wrote:

... and after an update this morning the issue seems to be resolved, sorry for bothering you!

Perfect! Thank you so much for confirming that the fix is in place.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL