Page MenuHomePhabricator

UploadWizard gives the same automatic number when uploading medias with same name
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • I upload medias through UploadWizard
  • I put the same name to them, counting on the fact that automatic numeration would tell them apart

What happens?:
The Wizard gives the same number to all the medias, triggering a "duplicate file name" error.

What should have happened instead?:
The Wizard should have given automatic numeration to the medias.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Wikimedia Commons

Other information (browser name/version, screenshots, etc.):
Reformulated by this discussion.

Event Timeline

Change #1032635 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Fix automatic numbering of copied titles

https://gerrit.wikimedia.org/r/1032635

Change #1032635 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Fix automatic numbering of copied titles

https://gerrit.wikimedia.org/r/1032635

Change #1032823 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@wmf/1.43.0-wmf.5] Fix automatic numbering of copied titles

https://gerrit.wikimedia.org/r/1032823

Etonkovidova subscribed.

Works as expected on commons beta.
Note to clarify the steps:

  • Upload multiple files
  • In the Describe step, fill in a title for the first uploaded file
  • Click on "Copy information to all uploads following...", make sure that " Copy title (with automatic numbering)" is checked

The file titles in the upload should display the same title as the first file but with numbering.
Currently, in production (commons wmf.5) checking " Copy title (with automatic numbering)" will assign the same title to all files in the upload.

Change #1032823 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@wmf/1.43.0-wmf.5] Fix automatic numbering of copied titles

https://gerrit.wikimedia.org/r/1032823

Mentioned in SAL (#wikimedia-operations) [2024-05-21T07:47:10Z] <mlitn@deploy1002> Started scap: Backport for [[gerrit:1032823|Fix automatic numbering of copied titles (T365107)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-21T07:49:50Z] <mlitn@deploy1002> mlitn: Backport for [[gerrit:1032823|Fix automatic numbering of copied titles (T365107)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-21T08:04:13Z] <mlitn@deploy1002> Finished scap: Backport for [[gerrit:1032823|Fix automatic numbering of copied titles (T365107)]] (duration: 17m 02s)

Checked in commons wmf.6 - the issue is fixed.

I still experience this issue on my Windows laptop running on Windows 10 pro.

I still experience this issue on my Windows laptop running on Windows 10 pro.

Thank you, @Kritzolina for reporting! Could you provide the steps you used?

The test scenario that was checked for this task:

  • multiple files are uploaded
  • in the Describe step, a title is entered (or an automatically generated title is left without changes) for the first file
  • then, the next action is clicking on "Copy information to all uploads following..." and making sure that "Copy title (with automatic numbering)" is enabled (it should be checked)
  • after that click on the Copy button - the "Copied!" confirmation appears. The files' titles will have the added numbering, i.e. 02, 03 etc are added to the the first file title.

Screen Shot 2024-05-31 at 3.56.46 PM.png (1×1 px, 505 KB)

Hi @Etonkovidova,

these are exactly the steps I usually take -

  1. I upload 2 - 20 files that have the same subject, so they should have the same file name with added numbers
  2. I enter the appropriate title in the title field, choose a caption and description, categories and whatever else is needed
  3. I click on "Copy information to all uploads following..." and check if all relevant boxes are checked, including the "Copy title (with automatic numbering)" box and then click on copy

After processing I get the same file name for all the images, including the same (the highest) number. E.g. I uploaded 7 files showing the same person at an event this morning, all had the title "Stella Nyanzi at Republica 2024 07" and I had to manually change the numbers. I just tried it without the 2024 and the same thing happened with two files, both called "Saskia Esken at Republica 02", until I manually called one of them "Saskia Esken at Republica 01".

This happened with all my uploads since the error first occurred - I saw you were working on it, but missed the message that is was marked resolved. For me it is definitely not resolved, sorry to say. Thank you very much for looking into it!

... and after an update this morning the issue seems to be resolved, sorry for bothering you!

... and after an update this morning the issue seems to be resolved, sorry for bothering you!

Perfect! Thank you so much for confirming that the fix is in place.