Page MenuHomePhabricator

Blocked participants can see the meeting link via EventDetails but not the event page
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Register for an online event with a meeting URL
  • Get sitewide blocked
  • Go to the event page and open the more details dialog
  • Note that the meeting and chat links aren't shown
  • Next, go to Special:EventDetails for the same event

What happens?:
You can see both links.

What should have happened instead?:
The links should be hidden, and the user sees the following message: "Your account is blocked. You do not have access to this."

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): master

Event Timeline

The event address is also shown on both event details special page and event details modal on the event page, I think we should also hide them

cmelo set the point value for this task to 2.
cmelo changed the point value for this task from 2 to 3.May 21 2024, 1:51 PM

Change #1034845 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Fix blocked participants can see the meeting link on EventDetails

https://gerrit.wikimedia.org/r/1034845

Change #1034845 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix blocked participants can see the meeting link on EventDetails

https://gerrit.wikimedia.org/r/1034845

Special:EventDetails Event page dialog
Screenshot 2024-05-22 at 2.17.40 PM.png (1×1 px, 160 KB)
Screenshot 2024-05-22 at 2.18.42 PM.png (1×1 px, 158 KB)

✅ Online event link and Chat group link are both hidden currently for blocked users.

@gonyeahialam right now as you can see in the images above, there is a message to the user on meeting and chat links for Special:EventDetails, while no text is shown at all to blocked users for meeting and chat links in the Event page dialog. Checking with you to see if this is okay?

@vaughnwalters I think we should have a specific message for blocked users, something like:
You do not have access to view this or You are blocked from viewing this or any other similar messaging used on Wiki for such scenarios.

@vaughnwalters I think we should have a specific message for blocked users, something like:
You do not have access to view this or You are blocked from viewing this or any other similar messaging used on Wiki for such scenarios.

Thanks, @vaughnwalters and @gonyeahialam, @gonyeahialam can you check with @ifried which message to use and update the AC?

At Engineering - Design meeting, we decided to go with a simple message and create a new task to explorer a more informative message(but concise) that can tell the user what type of block and how to resolve it incase it was done in error or link them to where to go for more info.

My suggested simple message is: Your account is blocked. You do not have access to this. cc @ifried

Thanks for providing this explanation & suggestion, @gonyeahialam! The message works for me. I will update the AC.

Change #1038342 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add a custom message for blocked users on event details

https://gerrit.wikimedia.org/r/1038342

Heya @cmelo I am not seeing the Your account is blocked. You do not have access to this. message on Special:EventDetails or on the Event details dialog for a blocked user

Event page dialogEvent details page
Screenshot 2024-06-25 at 4.45.22 PM.png (1×2 px, 223 KB)
Screenshot 2024-06-25 at 4.50.07 PM.png (1×2 px, 301 KB)

@vaughnwalters Sorry, there have been CI issues earlier today and the page didn't get merged. I also just made a couple more tweaks to the patch, hence moving this back to code review.

Change #1038342 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add a custom message for blocked users on event details

https://gerrit.wikimedia.org/r/1038342

✅The links should be hidden, and the user sees the following message: "Your account is blocked. You do not have access to this."

Event Details pageEvent page dialog
Screenshot 2024-07-01 at 1.19.08 PM.png (1×2 px, 183 KB)
Screenshot 2024-07-01 at 1.24.37 PM.png (1×2 px, 232 KB)

❌ If though there is no information provided by the organizer in the online event field and chat fields then the following notice will show in the meeting and chat links to the blocked user:

Event page dialogEvent Details page
Screenshot 2024-07-01 at 1.45.01 PM.png (1×1 px, 150 KB)
{F56137757}

When it should show the "Your account is blocked. You do not have access to this." regardless of whether the organizer adds in the link or not.



❓ Also, if the event is an in person or online and in-person event, the blocked event message does not display. I think this message should also display in these instances as well (regardless of whether the field is left blank by the organizer or not).

Event page dialog, In-person and onlineEvent page, In-person and online
Screenshot 2024-07-01 at 1.41.16 PM.png (1×2 px, 237 KB)
Screenshot 2024-07-01 at 1.35.49 PM.png (1×1 px, 179 KB)
Event page dialog, In-personEvent page, In-person
Screenshot 2024-07-01 at 1.39.09 PM.png (1×1 px, 164 KB)
Screenshot 2024-07-01 at 1.38.29 PM.png (1×1 px, 187 KB)

Thoughts? Should I make a new ticket for this part of it?

❌ If though there is no information provided by the organizer in the online event field and chat fields then the following notice will show in the meeting and chat links to the blocked user:

Event page dialogEvent Details page
Screenshot 2024-07-01 at 1.45.01 PM.png (1×1 px, 150 KB)
{F56137757}

When it should show the "Your account is blocked. You do not have access to this." regardless of whether the organizer adds in the link or not.



❓ Also, if the event is an in person or online and in-person event, the blocked event message does not display. I think this message should also display in these instances as well (regardless of whether the field is left blank by the organizer or not).

Event page dialog, In-person and onlineEvent page, In-person and online
Screenshot 2024-07-01 at 1.41.16 PM.png (1×2 px, 237 KB)
Screenshot 2024-07-01 at 1.35.49 PM.png (1×1 px, 179 KB)
Event page dialog, In-personEvent page, In-person
Screenshot 2024-07-01 at 1.39.09 PM.png (1×1 px, 164 KB)
Screenshot 2024-07-01 at 1.38.29 PM.png (1×1 px, 187 KB)

Thoughts? Should I make a new ticket for this part of it?

Hi @vaughnwalters, we have discussed it in code review and in a meeting, but I did not update the AC, sorry, the decision was to only show the blocked message if the organizer has provided the chat link and meeting link.

So when the account is blocked, but there is no link at all, we will use the existing behavior (saying that there's no link) @ifried @gonyeahialam

Yes, the existing behavior is fine, @cmelo. We discussed this topic in our team meeting today and made this decision.

Yes, the existing behavior is fine, @cmelo. We discussed this topic in our team meeting today and made this decision.

Okay, since existing behavior is expected, I am moving this to design sign off.