Page MenuHomePhabricator
Create Task
Maniphest T365695

SuggestedEditsSchema uses unsupported nested defaults
Open, HighPublic
Actions

Description

JsonSchema::DEFAULT is documented to be "only supported on the root-level. Defaults for objects need to be defined at their root level". This decision was made, because nested defaults are trickier to support, and can be easily self-contradictory (nested and root-level default might differ and provide arbitrarily many different default values, and such a conflict would need to be resolved in a predictable way).

However, Growth's SuggestedEditsSchema violates this rule, and attempts to use defaults in referenced items. For this reason, the defaults do not work as intended, and are not applied at all. This should be fixed by making SuggestedEditsSchema use defaults at the root level, as documented by CommunityConfiguration.

Details

SubjectRepoBranchLines +/-
JsonSchemaBuilder: Process nested defaultsmediawiki/extensions/CommunityConfigurationmaster+53 -12
SuggestedEditsSchema: Add defaults for missing fieldsmediawiki/extensions/GrowthExperimentsmaster+21 -0
SuggestedEditsSchema: Define defaults at the root levelmediawiki/extensions/GrowthExperimentsmaster+52 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Thu, May 23, 11:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, May 23, 11:57 AM
gerritbot added a comment.Thu, May 23, 12:22 PM

Change #1035380 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] SuggestedEditsSchema: Define defaults at the root level

https://gerrit.wikimedia.org/r/1035380

gerritbot added a project: Patch-For-Review.Thu, May 23, 12:22 PM
Urbanecm_WMF mentioned this in T365653: [beta - eswiki] every page displays Console error - BadMethodCallException: Sessions are disabled for load entry point.Thu, May 23, 10:15 PM
Urbanecm_WMF added a project: MediaWiki-extensions-CommunityConfiguration.Thu, May 23, 10:21 PM
Michael added a parent task: T365653: [beta - eswiki] every page displays Console error - BadMethodCallException: Sessions are disabled for load entry point.Fri, May 24, 6:31 AM
Urbanecm_WMF triaged this task as High priority.Fri, May 24, 8:33 AM
Urbanecm_WMF added a subtask: T365045: Not possible to set default values for TYPE_OBJECT properties.Fri, May 24, 8:35 AM
Urbanecm_WMF moved this task from Backlog to Needed before pilot release on the MediaWiki-extensions-CommunityConfiguration board.Fri, May 24, 8:38 AM
Michael mentioned this in T365142: Empty state of Special:CommunityConfiguration/GrowthSuggestedEdits is confusing.Fri, May 24, 5:29 PM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 15 (Growth Team)); removed Growth-Team (Sprint 14 (Growth Team)).Tue, May 28, 4:08 PM
Urbanecm_WMF moved this task from Incoming to Doing on the Growth-Team (Sprint 15 (Growth Team)) board.Tue, May 28, 4:44 PM
Urbanecm_WMF edited projects, added CommunityConfiguration-Adoption; removed MediaWiki-extensions-CommunityConfiguration.Wed, Jun 5, 10:49 AM
Michael subscribed.Wed, Jun 5, 2:25 PM

Quoting from the commit message of JsonSchemaBuilder: Accept arrays as defaults for TYPE_OBJECT by @Urbanecm_WMF

This is intentionally not accounting for "objects in objects", or "objects in arrays". For that, we might want to reconsider the "defaults only at the top level" approach, and instead use something like JsonSchemaTrait::getDefaultFromJsonSchema is doing for objects in objects. Since we do not need objects in objects now, this is left as a future improvement, to give enough time for the discussion.

The approach of JsonSchemaTrait::getDefaultFromJsonSchema is looking good enough to me, if it works. Implementing this functionality seems essential to me for properly preventing the underlying issue that triggered T365653: saving a schema with partial values for objects.

KStoller-WMF moved this task from Sprint 15 (Growth Team) to Sprint 16 (Growth Team) on the Growth-Team board.Tue, Jun 11, 6:52 PM
KStoller-WMF edited projects, added Growth-Team (Sprint 16 (Growth Team)); removed Growth-Team (Sprint 15 (Growth Team)).
Etonkovidova closed subtask T365045: Not possible to set default values for TYPE_OBJECT properties as Resolved.Tue, Jun 11, 7:45 PM
gerritbot added a comment.Fri, Jun 14, 1:21 PM

Change #1043774 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] JsonSchemaBuilder: Process nested defaults

https://gerrit.wikimedia.org/r/1043774

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 16 (Growth Team)) board.Fri, Jun 14, 1:28 PM
gerritbot added a comment.Fri, Jun 14, 1:28 PM

Change #1035380 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] SuggestedEditsSchema: Define defaults at the root level

Reason:

in favour of I44131013b53d16627175f18410e18fcf6c272015

https://gerrit.wikimedia.org/r/1035380

gerritbot added a comment.Mon, Jun 17, 11:58 AM

Change #1046638 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] SuggestedEditsSchema: Add defaults for missing fields

https://gerrit.wikimedia.org/r/1046638

gerritbot added a comment.Tue, Jun 18, 8:03 AM

Change #1046638 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SuggestedEditsSchema: Add defaults for missing fields

https://gerrit.wikimedia.org/r/1046638

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Tue, Jun 18, 9:00 AM
gerritbot added a comment.Tue, Jun 18, 1:29 PM

Change #1043774 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] JsonSchemaBuilder: Process nested defaults

https://gerrit.wikimedia.org/r/1043774

Urbanecm mentioned this in rECOM5d580582fe46: JsonSchemaBuilder: Process nested defaults.Tue, Jun 18, 1:29 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 18, 1:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL