Page MenuHomePhabricator

Uneven spacing around blockquote
Closed, ResolvedPublic

Description

When paragraph bottom margin was switched to padding, the rule which removes bottom margin from the last child in blockquote was not updated to also remove the padding.

This was "fixed" on en.wiki's Template:Quote_box by adding a <p style="padding-bottom: 0">: https://en.wikipedia.org/w/index.php?title=Template%3AQuote_box&diff=1209709036&oldid=1205466757 however this has the side effect of always rendering a paragraph even if there is no author.

Event Timeline

Change #1035415 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Remove bottom padding from last paragraph in blockquote

https://gerrit.wikimedia.org/r/1035415

This will become unnecessary once T361767 is fixed, but it is not a duplicate.

Given the rollback of paragraph padding may take some time, I don't think we should block more fixes in the meantime (there are already many across various repos and gadgets that may need to get cleaned up).

Jdlrobson subscribed.

We are still finalizing the design for paragraphs as part of T362939. It's complicated and we don't want to rush any changes here.

It's more of a duplicate of T358921. But maybe keep one task around to make sure templates stabilize when the new changes arrive.