Page MenuHomePhabricator

Excessive space after p tags is causing new spacing issues
Closed, DuplicatePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • See T352875 for precursor discussions

What happens?:
Something possibly related to this series of changes messed up the symmetry of the padding at two en.WP templates. See https://en.wikipedia.org/w/index.php?title=Template_talk:Quote_box&oldid=1209709062#bottom-of-box_sizing and https://en.wikipedia.org/w/index.php?title=Template_talk:Talk_quote_block&oldid=1209711889#Ugly_bottom_padding

Also see https://en.wikipedia.org/w/index.php?title=Template_talk:Markup&oldid=1211286676#Row_height

What should have happened instead?:
Spacing at the bottom of these templates should not have been affected.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

As for paragraphs inside blockquote, resources/skins.vector.styles/typography.less$164 still has margin-bottom: 0; for .mw-body blockquote > :last-child, whereas paragraphs now use padding-bottom instead of margin-bottom.

Additional vertical spacing problems, this time excessive padding around blockquote tags, has been reported at https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&curid=3252662&diff=1211600813&oldid=1211518868#Excessive_indentation_of_block_quotations

It looks like the development team working on these vertical spacing issues needs a much more varied set of test cases.

Additional vertical spacing problems, this time excessive padding around blockquote tags, has been reported at https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&curid=3252662&diff=1211600813&oldid=1211518868#Excessive_indentation_of_block_quotations

That's basically the same case as T358893: For consideration: Spacing between code blocks and paragraph seems a little big, but for blockquote.

It looks like the development team working on these vertical spacing issues needs a much more varied set of test cases.

That's for sure.

It looks like the development team working on these vertical spacing issues needs a much more varied set of test cases.

MediaWiki engineers cannot possibly test every single template across all our projects - that doesn't scale well. I think in general it's a good idea to specify in the template exactly how it should be rendered and not rely on browser or skin defaults which can change any time. That ensures the design is future proof to changes.

It looks like the development team working on these vertical spacing issues needs a much more varied set of test cases.

MediaWiki engineers cannot possibly test every single template across all our projects - that doesn't scale well. I think in general it's a good idea to specify in the template exactly how it should be rendered and not rely on browser or skin defaults which can change any time. That ensures the design is future proof to changes.

Of course, but when someone highlights an edge case, it should be easy to add it to a suite of test cases. That's what I do on Wikipedia. There is no way to account for the endless creativity of editors, who use and misuse template parameters in all sorts of ways, but a nice suite of test cases can at least test for all of the unusual conditions that have been noticed in the past.

As for specifying in a template exactly how it should render, that can leave it vulnerable to malfunctioning across different skins, or in dark mode, or when editors change their browser settings for reasons of accessibility. You can't really win.

(The issue here aren't really templates, it's HTML elements. And while all templates can't be accounted for, widely used HTML elements pretty much can.)