Page MenuHomePhabricator
Create Task
Maniphest T365757

Help remove usage of JsonBodyValidator from 3rd party extensions
Closed, ResolvedPublic
Actions

Description

Per T358560 we want to deprecate BodyValidator and everything associated with it soon, ideally in MW 1.43.
Per the stable interface policy we should help third parties to replace their usage of the deprecated code.

For each of the extensions, we should propose a patch or file a ticket in the appropriate location.

Affected extesions mainteained by HalloWelt:

Other affected 3rd party extesions:

This task is considered complete when a reasonable patch is proposed for each extension. It is not necessary to wait for these patches to be merged, especially if there are test failures unrelated to the change.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use body parameters instead of JSON body validatormediawiki/extensions/BlueSpiceExtendedSearchREL1_39+14 -21
Use body parameters instead of JSON body validatormediawiki/extensions/BlueSpiceExtendedSearchREL1_39-4.5.x+14 -21
Use body parameters instead of post parametersmediawiki/extensions/ContentStabilizationREL1_39+11 -18
Use body parameters instead of post parametersmediawiki/extensions/ContentStabilizationREL1_39-2.1.x+11 -18
Use body parameters instead of JSON body validatormediawiki/extensions/TuleapWikiFarmREL1_39+67 -87
Use body parameters instead of JSON body validatormediawiki/extensions/MenuEditorREL1_39-2.1.x+0 -13
Use body parameters instead of JSON body validatormediawiki/extensions/MenuEditorREL1_39+0 -13
Use body parameters instead of post parametersmediawiki/extensions/ChecklistsREL1_39-1.0.x+18 -21
Use body parameters instead of post parametersmediawiki/extensions/ChecklistsREL1_39+18 -21
Use body parameters instead of JSON body validatormediawiki/extensions/WorkflowsREL1_39-2.1.x+14 -28
Use body parameters instead of JSON body validatormediawiki/extensions/WorkflowsREL1_39+14 -28
Use body parameters instead of post parametersmediawiki/extensions/Checklistsmaster+18 -21
Use body parameters instead of JSON body validatormediawiki/extensions/MenuEditormaster+0 -13
Use body parameters instead of JSON body validatormediawiki/extensions/TuleapWikiFarmmaster+61 -87
Use body parameters instead of post parametersmediawiki/extensions/ContentStabilizationmaster+11 -18
Use body parameters instead of JSON body validatormediawiki/extensions/Workflowsmaster+14 -28
Use body parameters instead of JSON body validatormediawiki/extensions/BlueSpiceExtendedSearchmaster+14 -21
Use body parameters instead of JSON body validatormediawiki/extensions/Adiutormaster+13 -26
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.May 23 2024, 7:26 PM
daniel updated the task description. (Show Details)May 23 2024, 7:31 PM
BPirkle triaged this task as Medium priority.May 30 2024, 3:50 PM
BPirkle moved this task from Incoming (Needs Triage) to Backlog (Triaged and Ready) on the MW-Interfaces-Team board.
• FJoseph-WMF mentioned this in T361995: Remove usage of JsonBodyValidator from extensions.Jun 6 2024, 2:48 PM
daniel added a parent task: T366833: REST: Request Body Validation (tracking).Jun 6 2024, 7:02 PM
• FGoodwin changed the task status from Open to In Progress.Jun 14 2024, 3:54 PM
• FGoodwin claimed this task.
• FGoodwin moved this task from Backlog (Triaged and Ready) to In Progress on the MW-Interfaces-Team board.
gerritbot added a comment.Jun 17 2024, 8:48 AM

Change #1043823 had a related patch set uploaded (by Daniel Kinzler; author: Fgoodwin):

[mediawiki/extensions/Checklists@master] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1043823

gerritbot added a project: Patch-For-Review.Jun 17 2024, 8:48 AM
daniel updated the task description. (Show Details)Jun 17 2024, 8:53 AM
daniel updated the task description. (Show Details)
gerritbot added a comment.Jun 17 2024, 4:31 PM

Change #1046727 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/TuleapWikiFarm@master] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1046727

gerritbot added a comment.Jun 17 2024, 5:50 PM

Change #1046739 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/ContentStabilization@master] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1046739

daniel added a project: BlueSpice.Jun 18 2024, 7:58 AM

Tagging BlueSpice for awareness.

gerritbot added a comment.Jun 18 2024, 5:26 PM

Change #1047144 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/Workflows@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047144

gerritbot added a comment.Jun 18 2024, 5:57 PM

Change #1047153 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047153

gerritbot added a comment.Jun 18 2024, 6:05 PM

Change #1047154 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/MenuEditor@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047154

gerritbot added a comment.Jun 18 2024, 6:23 PM

Change #1047156 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/Adiutor@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047156

gerritbot added a comment.Jun 18 2024, 6:58 PM

Change #1047156 merged by Abaris:

[mediawiki/extensions/Adiutor@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047156

• FGoodwin mentioned this in rEADI90bfa0e2e54d: Use body parameters instead of JSON body validator.Jun 18 2024, 6:59 PM
Dogu updated the task description. (Show Details)Jun 18 2024, 7:01 PM
• FGoodwin updated the task description. (Show Details)Jun 20 2024, 8:39 PM
daniel updated the task description. (Show Details)Jun 21 2024, 7:38 AM
• FGoodwin updated the task description. (Show Details)Jun 21 2024, 7:08 PM
• FGoodwin closed this task as Resolved.Jun 21 2024, 7:11 PM

Patches are proposed on each extension. There are unrelated test failures on Workflows, BlueSpiceExtendedSearch, Checklists, ContentStabilization and MenuEditor.

gerritbot added a comment.Jul 29 2024, 5:48 AM

Change #1057425 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/BlueSpiceExtendedSearch@REL1_39] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057425

gerritbot added a comment.Jul 29 2024, 5:54 AM

Change #1047153 merged by Zoranzoki21:

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047153

gerritbot added a comment.Jul 29 2024, 5:55 AM

Change #1057425 merged by Zoranzoki21:

[mediawiki/extensions/BlueSpiceExtendedSearch@REL1_39] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057425

gerritbot added a comment.Jul 29 2024, 5:55 AM

Change #1057426 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/BlueSpiceExtendedSearch@REL1_39-4.5.x] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057426

gerritbot added a comment.Jul 29 2024, 5:55 AM

Change #1057426 merged by Zoranzoki21:

[mediawiki/extensions/BlueSpiceExtendedSearch@REL1_39-4.5.x] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057426

Kizule mentioned this in rEBSES0c506e37e893: Use body parameters instead of JSON body validator.Jul 29 2024, 5:57 AM
Kizule mentioned this in rEBSES1c036efe4c8a: Use body parameters instead of JSON body validator.
Kizule mentioned this in rEBSES014e047ce56f: Use body parameters instead of JSON body validator.
gerritbot added a comment.Jul 29 2024, 6:01 AM

Change #1047144 merged by Zoranzoki21:

[mediawiki/extensions/Workflows@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047144

gerritbot added a comment.Jul 29 2024, 6:01 AM

Change #1057428 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/Workflows@REL1_39] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057428

gerritbot added a comment.Jul 29 2024, 6:01 AM

Change #1057429 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/Workflows@REL1_39-2.1.x] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057429

gerritbot added a comment.Jul 29 2024, 6:04 AM

Change #1057428 merged by Zoranzoki21:

[mediawiki/extensions/Workflows@REL1_39] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057428

gerritbot added a comment.Jul 29 2024, 6:04 AM

Change #1057429 merged by Zoranzoki21:

[mediawiki/extensions/Workflows@REL1_39-2.1.x] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057429

gerritbot added a comment.Jul 29 2024, 6:07 AM

Change #1046739 merged by Zoranzoki21:

[mediawiki/extensions/ContentStabilization@master] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1046739

gerritbot added a comment.Jul 29 2024, 6:07 AM

Change #1057430 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/ContentStabilization@REL1_39] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1057430

gerritbot added a comment.Jul 29 2024, 6:07 AM

Change #1057431 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/ContentStabilization@REL1_39-2.1.x] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1057431

• FGoodwin mentioned this in rEOSAa0fb8e4ea407: Use body parameters instead of post parameters.Jul 29 2024, 6:07 AM
gerritbot added a comment.Jul 29 2024, 6:09 AM

Change #1057430 merged by Zoranzoki21:

[mediawiki/extensions/ContentStabilization@REL1_39] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1057430

gerritbot added a comment.Jul 29 2024, 6:10 AM

Change #1057431 merged by Zoranzoki21:

[mediawiki/extensions/ContentStabilization@REL1_39-2.1.x] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1057431

Kizule mentioned this in rEOSAcebba0d22f56: Use body parameters instead of post parameters.Jul 29 2024, 6:10 AM
Kizule mentioned this in rEOSA804911dbac9d: Use body parameters instead of post parameters.
gerritbot added a comment.Jul 29 2024, 6:11 AM

Change #1046727 merged by Zoranzoki21:

[mediawiki/extensions/TuleapWikiFarm@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1046727

gerritbot added a comment.Jul 29 2024, 6:11 AM

Change #1057433 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/TuleapWikiFarm@REL1_39] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057433

gerritbot added a comment.Jul 29 2024, 6:18 AM

Change #1057433 merged by jenkins-bot:

[mediawiki/extensions/TuleapWikiFarm@REL1_39] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057433

gerritbot added a comment.Jul 29 2024, 6:20 AM

Change #1047154 merged by Zoranzoki21:

[mediawiki/extensions/MenuEditor@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047154

gerritbot added a comment.Jul 29 2024, 6:20 AM

Change #1057488 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/MenuEditor@REL1_39] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057488

gerritbot added a comment.Jul 29 2024, 6:20 AM

Change #1057491 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/MenuEditor@REL1_39-2.1.x] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057491

• FGoodwin mentioned this in rEMEE2e84fd6d32a1: Use body parameters instead of JSON body validator.Jul 29 2024, 6:21 AM
gerritbot added a comment.Jul 29 2024, 6:23 AM

Change #1057491 merged by Zoranzoki21:

[mediawiki/extensions/MenuEditor@REL1_39-2.1.x] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057491

Kizule mentioned this in rEMEEbc5a66c0bd23: Use body parameters instead of JSON body validator.Jul 29 2024, 6:23 AM
gerritbot added a comment.Jul 29 2024, 6:25 AM

Change #1057488 merged by jenkins-bot:

[mediawiki/extensions/MenuEditor@REL1_39] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1057488

gerritbot added a comment.Jul 29 2024, 6:25 AM

Change #1043823 merged by Zoranzoki21:

[mediawiki/extensions/Checklists@master] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1043823

daniel mentioned this in rECHKa95a6caf8871: Use body parameters instead of post parameters.Jul 29 2024, 6:25 AM
Kizule mentioned this in rEMEE702a0923538e: Use body parameters instead of JSON body validator.Jul 29 2024, 6:25 AM
gerritbot added a comment.Jul 29 2024, 6:25 AM

Change #1057593 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/Checklists@REL1_39] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1057593

gerritbot added a comment.Jul 29 2024, 6:25 AM

Change #1057597 had a related patch set uploaded (by Zoranzoki21; author: Fgoodwin):

[mediawiki/extensions/Checklists@REL1_39-1.0.x] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1057597

Kizule mentioned this in rEWRK98aa47058ec1: Use body parameters instead of JSON body validator.Jul 29 2024, 6:25 AM
Kizule mentioned this in rEWRKc52fd36173e6: Use body parameters instead of JSON body validator.
• FGoodwin mentioned this in rEWRK6876ffa98fdf: Use body parameters instead of JSON body validator.Jul 29 2024, 6:25 AM
gerritbot added a comment.Jul 29 2024, 6:31 AM

Change #1057597 merged by Zoranzoki21:

[mediawiki/extensions/Checklists@REL1_39-1.0.x] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1057597

Kizule mentioned this in rECHKaf5a7071b4d0: Use body parameters instead of post parameters.Jul 29 2024, 6:31 AM
gerritbot added a comment.Jul 29 2024, 6:36 AM

Change #1057593 merged by jenkins-bot:

[mediawiki/extensions/Checklists@REL1_39] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1057593

Kizule mentioned this in rECHK2a6a85c52baa: Use body parameters instead of post parameters.Jul 29 2024, 6:37 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 29 2024, 7:30 AM
Kizule mentioned this in rETWF565173f669dd: Use body parameters instead of JSON body validator.Jul 29 2024, 9:51 AM
• FGoodwin mentioned this in rETWFdedc608ad027: Use body parameters instead of JSON body validator.Jul 29 2024, 9:51 AM
Hslater mentioned this in rENOM57ced642a7da: Use body parameters instead of post parameters.Feb 4 2025, 6:00 AM
dvogel mentioned this in rENOMf0fee15fc071: Use body parameters instead of post parameters.Feb 4 2025, 6:01 AM
Osnard mentioned this in rEAIE5f560adc09d6: Use body parameters instead of post parameters.Feb 12 2025, 10:10 AM
Hslater mentioned this in rEAIEbbeb7916fdfb: Use body parameters instead of post parameters.Feb 12 2025, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits