Page MenuHomePhabricator
Create Task
Maniphest T365757

Help remove usage of JsonBodyValidator from 3rd party extensions
Closed, ResolvedPublic
Actions

Description

Per T358560 we want to deprecate BodyValidator and everything associated with it soon, ideally in MW 1.43.
Per the stable interface policy we should help third parties to replace their usage of the deprecated code.

For each of the extensions, we should propose a patch or file a ticket in the appropriate location.

Affected extesions mainteained by HalloWelt:

Other affected 3rd party extesions:

This task is considered complete when a reasonable patch is proposed for each extension. It is not necessary to wait for these patches to be merged, especially if there are test failures unrelated to the change.

Details

SubjectRepoBranchLines +/-
Use body parameters instead of post parametersmediawiki/extensions/ContentStabilizationmaster+18 -23
Use body parameters instead of JSON body validatormediawiki/extensions/TuleapWikiFarmmaster+61 -87
Use body parameters instead of JSON body validatormediawiki/extensions/MenuEditormaster+0 -13
Use body parameters instead of JSON body validatormediawiki/extensions/Workflowsmaster+16 -28
Use body parameters instead of JSON body validatormediawiki/extensions/BlueSpiceExtendedSearchmaster+13 -21
Use body parameters instead of JSON body validatormediawiki/extensions/Adiutormaster+13 -26
Use body parameters instead of post parametersmediawiki/extensions/Checklistsmaster+18 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.May 23 2024, 7:26 PM
daniel updated the task description. (Show Details)May 23 2024, 7:31 PM
BPirkle triaged this task as Medium priority.Thu, May 30, 3:50 PM
BPirkle moved this task from Incoming (Needs Triage) to Backlog (Triaged and Ready) on the MW-Interfaces-Team board.
FJoseph-WMF mentioned this in T361995: Remove usage of JsonBodyValidator from extensions.Thu, Jun 6, 2:48 PM
daniel added a parent task: T366833: REST: Request Body Validation (tracking).Thu, Jun 6, 7:02 PM
FGoodwin changed the task status from Open to In Progress.Fri, Jun 14, 3:54 PM
FGoodwin claimed this task.
FGoodwin moved this task from Backlog (Triaged and Ready) to In Progress on the MW-Interfaces-Team board.
gerritbot added a comment.Mon, Jun 17, 8:48 AM

Change #1043823 had a related patch set uploaded (by Daniel Kinzler; author: Fgoodwin):

[mediawiki/extensions/Checklists@master] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1043823

gerritbot added a project: Patch-For-Review.Mon, Jun 17, 8:48 AM
daniel updated the task description. (Show Details)Mon, Jun 17, 8:53 AM
daniel updated the task description. (Show Details)
gerritbot added a comment.Mon, Jun 17, 4:31 PM

Change #1046727 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/TuleapWikiFarm@master] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1046727

gerritbot added a comment.Mon, Jun 17, 5:50 PM

Change #1046739 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/ContentStabilization@master] Use body parameters instead of post parameters

https://gerrit.wikimedia.org/r/1046739

daniel added a project: BlueSpice.Tue, Jun 18, 7:58 AM

Tagging BlueSpice for awareness.

gerritbot added a comment.Tue, Jun 18, 5:26 PM

Change #1047144 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/Workflows@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047144

gerritbot added a comment.Tue, Jun 18, 5:57 PM

Change #1047153 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047153

gerritbot added a comment.Tue, Jun 18, 6:05 PM

Change #1047154 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/MenuEditor@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047154

gerritbot added a comment.Tue, Jun 18, 6:23 PM

Change #1047156 had a related patch set uploaded (by Fgoodwin; author: Fgoodwin):

[mediawiki/extensions/Adiutor@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047156

gerritbot added a comment.Tue, Jun 18, 6:58 PM

Change #1047156 merged by Abaris:

[mediawiki/extensions/Adiutor@master] Use body parameters instead of JSON body validator

https://gerrit.wikimedia.org/r/1047156

FGoodwin mentioned this in rEADI90bfa0e2e54d: Use body parameters instead of JSON body validator.Tue, Jun 18, 6:59 PM
Dogu updated the task description. (Show Details)Tue, Jun 18, 7:01 PM
FGoodwin updated the task description. (Show Details)Thu, Jun 20, 8:39 PM
daniel updated the task description. (Show Details)Fri, Jun 21, 7:38 AM
FGoodwin updated the task description. (Show Details)Fri, Jun 21, 7:08 PM
FGoodwin closed this task as Resolved.Fri, Jun 21, 7:11 PM

Patches are proposed on each extension. There are unrelated test failures on Workflows, BlueSpiceExtendedSearch, Checklists, ContentStabilization and MenuEditor.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits