Page MenuHomePhabricator
Create Task
Maniphest T366833

REST: Request Body Validation (tracking)
Open, In Progress, HighPublic
Actions

Description

Tracking ticket for tasks related to validating request bodies in the REST framework.

Related Objects
Search...

StatusSubtypeAssignedTask
 In ProgressNoneT366833 REST: Request Body Validation (tracking)
 In ProgressAtienoT366349 Refactor ArrayDef::validate and ConfigSchemaAggregator::validateValue
 DeclinedNoneT350053 Create a JsonBodyValidator if getParamSettings() returns body params
 OpenNoneT357909 Clarify Handler::getValidatedBody error states
 ResolveddanielT305973 JsonBodyValidator does not validate the parameter types
 Resolved• codebugT358557 Rest router should provide parsed body data to handler.
 ResolveddanielT358850 Rest: make getValidatedBody return body parameters
 ResolveddanielT360434 REST: request body validation should fail if unexpected fields are present
 ResolveddanielT358560 Rest: Deprecate BodyValidator
ResolvedAtienoT358558 Rest ParamValidator should support validation of fields in the request body
 ResolvedAtienoT357025 Add getParsedBody to RequestInterface in the REST framework
 Resolved• codebugT361995 Remove usage of JsonBodyValidator from extensions
 Resolved• codebugT365526 Remove usage of JsonBodyValidator from CampaignEvents
 Resolved• codebugT365527 Remove usage of JsonBodyValidator from WikimediaCampaignEvents
 Resolved• FGoodwinT365757 Help remove usage of JsonBodyValidator from 3rd party extensions
 ResolvedAtienoT362108 Implement JSON schema validation in ArrayDef
 ResolvedAtienoT366289 Apply default values from the schema if not set
 ResolvedAtienoT367394 REST: Stop using getParamSettings for body parameters
 ResolvedOllie.Shotton_WMDET363084 Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API
 DuplicateNoneT367395 Wikibase: stop using JsonBodyValidator in REST handlers
 ResolveddanielT352742 OpenAPI spec validation test fails for SecurePoll and causes CI failures for other repos
 ResolvedBPirkleT368131 ArrayDef: add convenience methods for generating schemas
 Resolved• FGoodwinT368132 REST: Make PARAM_ISMULTI require arrays in JSON
 Resolved• codebugT368133 REST: add structure test that checks if param schemas are valid

Event Timeline

daniel created this task.Jun 6 2024, 6:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2024, 6:28 PM
daniel added a project: MediaWiki-REST-API.Jun 6 2024, 6:30 PM
daniel triaged this task as High priority.Jun 6 2024, 6:54 PM
daniel added subtasks: T362108: Implement JSON schema validation in ArrayDef, T358560: Rest: Deprecate BodyValidator , T366349: Refactor ArrayDef::validate and ConfigSchemaAggregator::validateValue, T366289: Apply default values from the schema if not set.Jun 6 2024, 7:01 PM
daniel added subtasks: T365757: Help remove usage of JsonBodyValidator from 3rd party extensions, T305973: JsonBodyValidator does not validate the parameter types, T363084: Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API, T350053: Create a JsonBodyValidator if getParamSettings() returns body params, T340185: The MW Rest API does not normalize its string request parameters, T357909: Clarify Handler::getValidatedBody error states, T352742: OpenAPI spec validation test fails for SecurePoll and causes CI failures for other repos.
daniel closed subtask T350053: Create a JsonBodyValidator if getParamSettings() returns body params as Declined.Jun 6 2024, 7:04 PM
daniel changed the task status from Open to In Progress.Jun 6 2024, 7:08 PM
daniel moved this task from Incoming (Needs Triage) to In Progress on the MW-Interfaces-Team board.
daniel added a subtask: T365513: REST: improve CSRF token handling.Jun 6 2024, 7:22 PM
daniel added a subtask: T367394: REST: Stop using getParamSettings for body parameters.Jun 13 2024, 10:33 AM
daniel added a subtask: T367395: Wikibase: stop using JsonBodyValidator in REST handlers.Jun 13 2024, 10:39 AM
Atieno closed subtask T362108: Implement JSON schema validation in ArrayDef as Resolved.Jun 13 2024, 10:48 AM
Atieno changed the status of subtask T366289: Apply default values from the schema if not set from Open to In Progress.Jun 13 2024, 2:59 PM
• FJoseph-WMF changed the status of subtask T367394: REST: Stop using getParamSettings for body parameters from Open to In Progress.Jun 13 2024, 3:28 PM
• FGoodwin changed the status of subtask T365757: Help remove usage of JsonBodyValidator from 3rd party extensions from Open to In Progress.Jun 14 2024, 3:54 PM
daniel closed subtask T352742: OpenAPI spec validation test fails for SecurePoll and causes CI failures for other repos as Resolved.Jun 20 2024, 7:48 AM
daniel removed a subtask: T340185: The MW Rest API does not normalize its string request parameters.Jun 20 2024, 3:17 PM
• FGoodwin closed subtask T365757: Help remove usage of JsonBodyValidator from 3rd party extensions as Resolved.Jun 21 2024, 7:11 PM
BPirkle changed the status of subtask T368131: ArrayDef: add convenience methods for generating schemas from Open to In Progress.Jun 24 2024, 5:20 PM
BPirkle changed the status of subtask T368132: REST: Make PARAM_ISMULTI require arrays in JSON from Open to In Progress.Jun 27 2024, 3:18 PM
daniel changed the status of subtask T368133: REST: add structure test that checks if param schemas are valid from Open to In Progress.Jul 8 2024, 3:47 PM
Ollie.Shotton_WMDE closed subtask T363084: Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API as Resolved.Jul 9 2024, 9:53 AM
• FJoseph-WMF closed subtask T367394: REST: Stop using getParamSettings for body parameters as Resolved.Jul 11 2024, 2:36 PM
• FJoseph-WMF closed subtask T305973: JsonBodyValidator does not validate the parameter types as Resolved.
Atieno changed the status of subtask T366349: Refactor ArrayDef::validate and ConfigSchemaAggregator::validateValue from Open to In Progress.Jul 18 2024, 3:05 PM
BPirkle closed subtask T368133: REST: add structure test that checks if param schemas are valid as Resolved.Jul 25 2024, 3:15 PM
BPirkle closed subtask T368132: REST: Make PARAM_ISMULTI require arrays in JSON as Resolved.
BPirkle closed subtask T368131: ArrayDef: add convenience methods for generating schemas as Resolved.Jul 25 2024, 8:05 PM
BPirkle closed subtask T366289: Apply default values from the schema if not set as Resolved.Jul 30 2024, 3:38 PM
BPirkle changed the status of subtask T365513: REST: improve CSRF token handling from Open to In Progress.Aug 1 2024, 3:09 PM
BPirkle removed a subscriber: • FJoseph-WMF.Aug 21 2024, 9:24 PM
BPirkle closed subtask T358560: Rest: Deprecate BodyValidator as Resolved.Aug 22 2024, 3:39 PM
aaron moved this task from In Progress to Epics in progress on the MW-Interfaces-Team board.Oct 24 2024, 3:36 PM
HCoplin-WMF moved this task from Epics in progress to MWI-Roadmap on the MW-Interfaces-Team board.Jan 9 2025, 3:06 PM
HCoplin-WMF edited projects, added MW-Interfaces-Team (MWI-Roadmap); removed MW-Interfaces-Team.
HCoplin-WMF moved this task from Now to Parking Lot on the MW-Interfaces-Team (MWI-Roadmap) board.
HCoplin-WMF removed a subtask: T365513: REST: improve CSRF token handling.Aug 20 2025, 8:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits