Help icon is not inverted on WhatLinksHere and other pages
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	May 31 2024, 3:08 PM

Description

Steps to replicate the issue (include links if applicable):

Visit https://en.wikipedia.org/wiki/Special:WhatLinksHere/Talk_page with night mode enabled

What happens?:

What should have happened instead?:
Icon should make use of the Codex mixin instead of OOUI so that it's color is flipped in night theme.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
This should likely be switched to use a Codex icon.
https://gerrit.wikimedia.org/g/mediawiki/core/+/6e4337de93f312dc8ec8da805cf66a7199588308/resources/src/mediawiki.helplink/helplink.less

QA Results - Beta

AC	Status	Details
1	✅	T366358#9936425

QA Results - Prod

AC	Status	Details
1	✅	T366358#9975732

Details

	Subject	Repo	Branch	Lines +/-
	OutputPage: Convert helplink icon to use codex css mixin	mediawiki/core	master	+10 -17

Customize query in gerrit

Related Objects

Mentioned In: T368686: Verify 1.43.0-wmf.12 deployment
T363780: [QA] Exploratory testing: Vector 2022 night theme

Event Timeline

Jdlrobson created this task.May 31 2024, 3:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2024, 3:08 PM

Jdlrobson mentioned this in T363780: [QA] Exploratory testing: Vector 2022 night theme.May 31 2024, 3:08 PM

Jdlrobson triaged this task as Medium priority.May 31 2024, 3:13 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 5); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.

Jdlrobson moved this task from Backlog to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.May 31 2024, 4:47 PM

• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM

JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 6); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 5).Jun 10 2024, 5:46 PM

Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Jun 12 2024, 8:50 PM

Jdlrobson updated the task description. (Show Details)

ovasileva set the point value for this task to 2.Jun 24 2024, 5:51 PM

ovasileva moved this task from Ready for estimation to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

Pcoombe added a project: MediaWiki-Special-pages.Jun 24 2024, 9:58 PM

SToyofuku-WMF claimed this task.Jun 25 2024, 9:43 PM

SToyofuku-WMF moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

Blocked pending a discussion in team sync tomorrow

The issue:

the linked stylesheet (https://gerrit.wikimedia.org/g/mediawiki/core/+/6e4337de93f312dc8ec8da805cf66a7199588308/resources/src/mediawiki.helplink/helplink.less) is attaching the icon directly to the link element, but the codex mixin wants an element of its own
I'm not seeing a super easy way to hack it or add an element for the help notice icon
it looks like we could add skin-invert relatively easily right here: https://gerrit.wikimedia.org/g/mediawiki/core/+/d18d0c228320afe286984b60e1d3c5073ad6c3e7/includes/Output/OutputPage.php#1769
soft blocked on discussing decisions with the team

I think ideal solution here would be to add a span element to addHelpLink for just the icon (cdxIconHelp)
We probably need to consider cached HTML.

Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Jun 26 2024, 8:27 PM

Change #1050077 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/core@master] Convert helplink icon to use codex css mixin

https://gerrit.wikimedia.org/r/1050077

gerritbot added a project: Patch-For-Review.Jun 26 2024, 11:06 PM

Jdlrobson reassigned this task from SToyofuku-WMF to GMikesell-WMF.Jun 27 2024, 10:10 PM

Jdlrobson moved this task from Doing to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

Jdlrobson added a subscriber: SToyofuku-WMF.

Change #1050077 merged by jenkins-bot:

[mediawiki/core@master] OutputPage: Convert helplink icon to use codex css mixin

https://gerrit.wikimedia.org/r/1050077

Maintenance_bot removed a project: Patch-For-Review.Jun 27 2024, 10:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jun 27 2024, 11:00 PM

@Jdlrobson Beta passed but test.wiki failed as seen in the screenshots.

Test Result - Beta/Test.wiki

Status: ✅ PASS for Beta/ ❌ for Test.wiki
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

✅ AC1: Icon should make use of the Codex mixin instead of OOUI so that it's color is flipped in night theme.

✅ Beta	❌Test.wiki
	Help icon is still dark

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Jun 28 2024, 10:41 PM

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

GMikesell-WMF subscribed.

^ I believe that's expected as it was merged yesterday and testwiki isn't deployed until Tuesday

Jdlrobson awarded a token.Jun 29 2024, 2:27 AM

Jdlrobson closed this task as Resolved.Jul 1 2024, 4:24 PM

Jdlrobson claimed this task.

GMikesell-WMF mentioned this in T368686: Verify 1.43.0-wmf.12 deployment.Jul 3 2024, 9:38 PM

Pcoombe awarded a token.Jul 4 2024, 11:03 PM

Edtadros attached a referenced file: F54691921: screenshot 452.png. (Show Details)Jul 12 2024, 1:06 AM

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBS
Emulated Device: NA