Enable night theme on action submit and action edit pages (non-JavaScript based edit workflows)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	May 31 2024, 4:06 PM

Description

Background

Non-Javascript users and users who have disabled all the editors in their preferences access a form based version of the editor. There is also other editors that can load in this URL. All need work for dark mode support.

Screenshot 2024-06-06 at 12.17.53 PM.png (1×2 px, 450 KB)

Screenshot appears in dark-mode since all pages are dark-mode enabled on beta cluster

User story

As a user I want my editing workflow to be in dark mode.

Acceptance criteria

We have fixed the footer (wmf.12)
Night mode is enabled on pages with ?action=edit
Night mode is enabled on pages with ?action=submit

Communication criteria - does this need an announcement or discussion?

N/A

Rollback plan

N/A

This task was created by Version 1.0.0 of the Web team task template using phabulous

QA Results - Beta

AC	Status	Details
1	❌	T366372#9963122

Details

	Subject	Repo	Branch	Lines +/-
	Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)	operations/mediawiki-config	master	+2 -21

Customize query in gerrit

Related Objects

Mentioned In: T369576: No-JS OOUI DropdownInputWidget arrow isn't visible in dark mode
Mentioned Here: T369576: No-JS OOUI DropdownInputWidget arrow isn't visible in dark mode
T367362: Fix 2010 Wikitext editor in night theme

Event Timeline

Jdlrobson created this task.May 31 2024, 4:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2024, 4:06 PM

Jdlrobson triaged this task as High priority.May 31 2024, 4:49 PM

Jdlrobson renamed this task from Enable night theme on action submit and action edit pages to Enable night theme on action submit and action edit pages (non-JavaScript based edit workflows).May 31 2024, 4:53 PM

Jdlrobson lowered the priority of this task from High to Low.

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.May 31 2024, 5:03 PM

• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM

JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM

ovasileva raised the priority of this task from Low to Medium.Jun 6 2024, 1:23 PM

ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 6); removed Web-Team-Backlog.

Jdlrobson updated the task description. (Show Details)Jun 6 2024, 1:31 PM

Jdrewniak updated the task description. (Show Details)Jun 6 2024, 4:19 PM

Jdrewniak updated the task description. (Show Details)

@Jdrewniak after the OOUI release this looks a bit different:

Screenshot 2024-06-07 at 3.17.04 PM.png (1×2 px, 292 KB)

Looks like this is the problematic code for the footer:
https://gerrit.wikimedia.org/g/mediawiki/core/+/d478d4fdc66e3d08b9cea6125ef7d70732414004/resources/src/mediawiki.action/mediawiki.action.edit.styles.less#101

Note the global invert will make this even worse as .wikiEditor-ui-toolbar has a white background:

Screenshot 2024-06-07 at 3.19.37 PM.png (1×2 px, 332 KB)

Without global icon invert:

Screenshot 2024-06-07 at 3.22.25 PM.png (1×2 px, 279 KB)

With global icon invert:

Jack_who_built_the_house subscribed.Jun 8 2024, 8:23 AM

This seems to only require one token update to resources/src/mediawiki.action/mediawiki.action.edit.styles.less in core, assuming we fix https://phabricator.wikimedia.org/T367362 separately.

Jdlrobson removed Jdlrobson as the assignee of this task.Jun 17 2024, 6:07 PM

ovasileva set the point value for this task to 2.Jun 20 2024, 5:37 PM

ovasileva updated the task description. (Show Details)

ovasileva edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 6).

Jdlrobson moved this task from Needs analysis to Blocked on Others on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.Jun 27 2024, 9:40 PM

Jdlrobson updated the task description. (Show Details)

Earliest possible deploy date is 4th July, given holiday this can go out on Monday 8th.

Jdlrobson claimed this task.Jun 27 2024, 9:43 PM

Change #1049975 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)

https://gerrit.wikimedia.org/r/1049975

gerritbot added a project: Patch-For-Review.Jun 28 2024, 12:05 AM

Change #1049975 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)

Reason:

Moved into https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1050671?usp=search

https://gerrit.wikimedia.org/r/1049975

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2024, 2:30 AM

Jdlrobson moved this task from Excluded experiences to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.Jul 1 2024, 11:29 PM

ovasileva raised the priority of this task from Medium to High.Jul 8 2024, 10:54 AM

Done in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1050671

Jdlrobson reassigned this task from Jdlrobson to GMikesell-WMF.Jul 8 2024, 5:14 PM

Jdlrobson moved this task from Blocked on Others to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

@Jdlrobson What about the drop-down arrow that's still in black as seen in the screenshots below? Do you want that in white like how it is when Java is on?

Test Result - Beta

Status: ❌ FAIL
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Polar_bear?action=edit as a non-javascript user in dark mode

2024-07-08_13-13-57.png (1×2 px, 326 KB)

https://en.wikipedia.beta.wmflabs.org/wiki/Polar_bear?action=submit as a non-javascript user in dark mode

2024-07-08_13-13-38.png (1×2 px, 316 KB)

GMikesell-WMF updated the task description. (Show Details)Jul 8 2024, 9:27 PM

Ill open a bug. Thanks for catching that!

I've opened T369576 to capture the issue discovered in QA! Thanks again @GMikesell-WMF

Jdlrobson mentioned this in T369576: No-JS OOUI DropdownInputWidget arrow isn't visible in dark mode.Jul 8 2024, 11:36 PM

	F55032753: Screenshot 2024-06-07 at 3.22.25 PM.png
	Jun 7 2024, 10:27 PM

	F55032635: Screenshot 2024-06-07 at 3.19.37 PM.png
	Jun 7 2024, 10:20 PM

	F55032538: Screenshot 2024-06-07 at 3.17.04 PM.png
	Jun 7 2024, 10:20 PM

	F54971566: Screenshot 2024-06-06 at 12.17.53 PM.png
	Jun 6 2024, 4:19 PM

Enable night theme on action submit and action edit pages (non-JavaScript based edit workflows)Closed, ResolvedPublic2 Estimated Story PointsActions