Page MenuHomePhabricator
Create Task
Maniphest T367005

Map function should be correctly type-hinted that it returns a Typed list of Z1s
Closed, ResolvedPublic
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Note that the output is typed obejct (Z1)

What should have happened instead?:

  • I think it should return a typed list (Z881)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (547b70e)mediawiki/extensions/WikiLambdamaster+1 -1
wikifunctions: Update orchestrator from 2025-03-25-145119 to 2025-04-02-124609operations/deployment-chartsmaster+1 -1
wikifunctions: Update evaluators from 2025-03-19-125950 to 2025-04-02-130409operations/deployment-chartsmaster+2 -2
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
definitions: [Z873] Make return Type more specific, Z881(Z1) not just Z1repos/abstract-wiki/wikifunctions/function-schemata!208feeglgeefmap-return-typemain
Customize query in GitLab

Related Objects

Event Timeline

99of9 created this task.Jun 9 2024, 11:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2024, 11:23 AM
Maintenance_bot added a project: Abstract Wikipedia team.Jun 9 2024, 11:30 AM
Jdforrester-WMF renamed this task from Map function should return a list to Map function should be correctly type-hinted that it returns a Typed list of Z1s.Jun 12 2024, 4:33 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.
• Sharvaniharan moved this task from Backlog to Bugs to investigate on the Abstract Wikipedia team board.Nov 12 2024, 5:30 AM
Jdforrester-WMF assigned this task to gengh.Nov 12 2024, 4:38 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q2 (Oct–Dec)); removed Abstract Wikipedia team.
Jdforrester-WMF subscribed.

This should be fixed by the fix for T375972, which is shipping to production later this week.

Jdforrester-WMF added a project: MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).Nov 12 2024, 4:38 PM
Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Nov 13 2024, 8:09 PM
Stashbot mentioned this in T358737: Object selector cannot select unlabeled object by ZID.Nov 14 2024, 7:20 PM
Stashbot mentioned this in T375972: in the object selector, functions that return a Typed list are not available when a Typed list is expected or required .
Stashbot mentioned this in T373038: fetchZidsOfType only returns objects that have at least one label.

Mentioned in SAL (#wikimedia-operations) [2024-11-14T19:20:16Z] <James_F> Running mwscript-k8s -f -- extensions/WikiLambda/maintenance/updateSecondaryTables.php --wiki=wikifunctionswiki --zType Z8 --report --verbose for T375972, T367005, T373038, T358737

Jdforrester-WMF closed this task as Resolved.Jan 7 2025, 4:28 PM
99of9 reopened this task as Open.Feb 13 2025, 8:45 AM

See the original title and original description. This doesn't seem to have changed.

DVrandecic removed projects: MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Abstract Wikipedia team (25Q2 (Oct–Dec)).Feb 13 2025, 3:12 PM
DVrandecic added a project: WikiLambda.
DVrandecic removed a project: Wikifunctions.Feb 13 2025, 3:15 PM
DVrandecic added a project: Abstract Wikipedia team.
DVrandecic moved this task from Bugs to investigate to To Triage on the Abstract Wikipedia team board.
Jdforrester-WMF removed gengh as the assignee of this task.Feb 19 2025, 5:31 PM
Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF changed the subtype of this task from "Bug Report" to "Task".
Jdforrester-WMF added a subscriber: gengh.
CodeReviewBot added a project: Patch-For-Review.Mar 31 2025, 3:35 PM

feeglgeef opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/208

Change map function return type

Feeglgeef changed the task status from Open to In Progress.Mar 31 2025, 3:38 PM
Feeglgeef claimed this task.
Feeglgeef edited projects, added Abstract Wikipedia team (25Q3 (Jan–Mar)); removed Abstract Wikipedia team.Mar 31 2025, 3:41 PM
Feeglgeef moved this task from Incoming to In Code review on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
CodeReviewBot added a comment.Mar 31 2025, 6:40 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/208

definitions: [Z873] Make return Type more specific, Z881(Z1) not just Z1

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2025, 7:31 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q4 (Apr–Jun)); removed Abstract Wikipedia team (25Q3 (Jan–Mar)).Apr 1 2025, 12:19 PM
Jdforrester-WMF edited projects, added function-schemata; removed WikiLambda.
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
CodeReviewBot added a project: Patch-For-Review.Apr 2 2025, 12:38 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/334

Update function-schemata sub-module to HEAD (bcd26d2)

CodeReviewBot added a comment.Apr 2 2025, 12:38 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/331

Update function-schemata sub-module to HEAD (bcd26d2)

CodeReviewBot added a comment.Apr 2 2025, 12:39 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/67

Update function-schemata sub-module to HEAD (bcd26d2)

gerritbot added a comment.Apr 2 2025, 12:39 PM

Change #1133384 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (bcd26d2)

https://gerrit.wikimedia.org/r/1133384

CodeReviewBot added a comment.Apr 2 2025, 12:41 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/334

Update function-schemata sub-module to HEAD (bcd26d2)

CodeReviewBot added a comment.Apr 2 2025, 1:03 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/331

Update function-schemata sub-module to HEAD (bcd26d2)

gerritbot added a comment.Apr 2 2025, 2:00 PM

Change #1133413 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-03-19-125950 to 2025-04-02-130409

https://gerrit.wikimedia.org/r/1133413

gerritbot added a comment.Apr 2 2025, 2:00 PM

Change #1133414 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-03-25-145119 to 2025-04-02-124609

https://gerrit.wikimedia.org/r/1133414

gerritbot added a comment.Apr 2 2025, 2:03 PM

Change #1133413 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-03-19-125950 to 2025-04-02-130409

https://gerrit.wikimedia.org/r/1133413

gerritbot added a comment.Apr 2 2025, 2:09 PM

Change #1133414 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-03-25-145119 to 2025-04-02-124609

https://gerrit.wikimedia.org/r/1133414

CodeReviewBot added a comment.Apr 2 2025, 2:32 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/67

Update function-schemata sub-module to HEAD (bcd26d2)

Jdforrester-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.Apr 2 2025, 2:33 PM

Once https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1133384 lands, and the train containing it deploys, the Object will be updated following the post-train process.

gerritbot added a comment.Apr 3 2025, 2:13 PM

Change #1133384 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (547b70e)

https://gerrit.wikimedia.org/r/1133384

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.Apr 3 2025, 2:15 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 3 2025, 2:32 PM
Jdforrester-WMF closed this task as Resolved.Apr 16 2025, 8:54 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
Jdforrester-WMF added projects: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08), Essential-Work.
cmassaro mentioned this in rMSFEe8fbf032f976: Update function-schemata sub-module to HEAD (bcd26d2).Oct 3 2025, 9:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits