Page MenuHomePhabricator

GrowthExperiments: Do not expose configuration for unavailable features from Community Configuration
Open, MediumPublic

Description

As of now, CommunityConfiguration expects the set of configuration options is equal at all projects where it is enabled. The only thing that controls which features are displayed in the dashboard, and what configuration options display in the configuration editor, is which extensions are installed on the wiki. For example, if GrowthExperiments is installed, then Special:CommunityConfiguration will display all possible configuration for GrowthExperiments, including options for feature that is not enabled at that project (and including options for features that are not even available at that project).

Within this task, we should hide unavailable features from Special:CommunityConfiguration, since it makes no sense to configure them when not available. See Acceptance Criteria for a list.

Acceptance Criteria

Mentorship:

  • Given Personalized praise is not available on a wiki, When I view Special:CommunityConfiguration/Mentorship, Then I do not see any Personalized praise settings.

Newcomer onboarding

  • Given Levelling up is not available on a wiki, When I view Special:CommunityConfiguration/GrowthHomepage, Then I do not see any Levelling up settings.

Suggested edits

  • Given Add a Link is not available on a wiki, When I view Special:CommunityConfiguration/GrowthSuggestedEdits, Then I do not see any Add a Link settings.
  • Given Add an image to an unillustrated article is not available on a wiki, When I view Special:CommunityConfiguration/GrowthSuggestedEdits, Then I do not see any Add an image to an unillustrated article settings.
  • Given Add an image to an article section is not available on a wiki, When I view Special:CommunityConfiguration/GrowthSuggestedEdits, Then I do not see any Add an image to an article section settings.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF added a subscriber: KStoller-WMF.

Hi @KStoller-WMF, do you see any other group of settings besides the three ones I listed that should be hidden in certain conditions? If so, could you add them into the A/C please? Thanks!

This covers it as far as I know. For clarity I broke up "Add an image" into the two, as they have separate configuration settings:

  • Add an image to an unillustrated article
  • Add an image to an article section

Per a discussion with @Michael, I will take over the PoC uploaded by @Michael and finalise them into mergeable code. Thanks for the investigation here!

Change #1043730 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Hide unavailable features from CommunityConfiguration

https://gerrit.wikimedia.org/r/1043730

Change #1043730 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Hide unavailable features from CommunityConfiguration

https://gerrit.wikimedia.org/r/1043730