Page MenuHomePhabricator
Create Task
Maniphest T368679

Confirmation state appears when a user has edited a wish
Open, MediumPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • When a user edits the wish using the form, the new copy is saved, however the "wish confirmation state" also appears.
  • To replicate, 1, create a wish, 2, click edit, 3, make a new edit, 4, see the confirmation banner

What happens?:

What should have happened instead?:

  • Users should not see the confirmation state, or should see a confirmation state that says "This wish has been updated."

image.png (649×1 px, 135 KB)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

TitleReferenceAuthorSource BranchDest Branch
Move the postEdit storage setting to be after savingrepos/commtech/wishlist-intake!145samwilsonpostedit-after-save-2main
Move the postEdit storage setting to be after savingrepos/commtech/wishlist-intake!135samwilsonpostedit-after-savemain
Make postEdit notification work on save as well as editrepos/commtech/wishlist-intake!123samwilsonpostedit-msgmain
Customize query in GitLab

Related Objects
Search...

Event Timeline

JWheeler-WMF created this task.Thu, Jun 27, 10:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Jun 27, 10:05 PM
JWheeler-WMF added a project: Community Wishlist Survey.Thu, Jun 27, 10:05 PM
JWheeler-WMF triaged this task as Medium priority.Fri, Jun 28, 1:45 PM
Samwilson claimed this task.Mon, Jul 1, 6:28 AM
Samwilson moved this task from Ready for dev to In development on the Community-Tech (July 1-12 2024 (Corsac Fox)) board.
CodeReviewBot added a project: Patch-For-Review.Tue, Jul 2, 3:13 AM

samwilson opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/123

Make postEdit notification work on save as well as edit

Samwilson added a comment.Tue, Jul 2, 3:17 AM

This overlaps with T367937 a bit. I've made a patch that fixes both I think.

Samwilson added a comment.EditedTue, Jul 2, 3:19 AM

Could someone confirm that the two post-edit messages should be a) "Your wish has been submitted." and b) "This wish has been updated."?

Samwilson moved this task from In development to Feedback and review on the Community-Tech (July 1-12 2024 (Corsac Fox)) board.Tue, Jul 2, 3:26 AM
MusikAnimal moved this task from Backlog to Wish page on the Community Wishlist Survey board.Tue, Jul 2, 4:44 AM
MusikAnimal edited projects, added Community Wishlist Survey (Wish page); removed Community Wishlist Survey.
CodeReviewBot added a comment.Tue, Jul 2, 6:18 AM

musikanimal merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/123

Make postEdit notification work on save as well as edit

Maintenance_bot removed a project: Patch-For-Review.Tue, Jul 2, 6:30 AM
Samwilson moved this task from Feedback and review to QA on the Community-Tech (July 1-12 2024 (Corsac Fox)) board.Tue, Jul 2, 7:39 AM
Samwilson added a parent task: T362761: Implement all form fields, including saving contents.
MusikAnimal mentioned this in T367937: Show confirmation after wish submission.Tue, Jul 2, 5:09 PM
dom_walden subscribed.Wed, Jul 3, 8:20 AM

@Samwilson Do we want the hook ran even on a null edit? I notice it will show the banner and the toast (with a link to the last revision ID). I wonder if this will cause problems for anything that listens to the postEdit hook and expects unique revision IDs.

I also notice when you first create a wish the toast popup link to Special:Diff/<rev id> does not work (returns a 500). The link does work when I create a new page on test.wikipedia.org, so I assume this is just a toolforge issue?

CodeReviewBot added a project: Patch-For-Review.Wed, Jul 3, 8:45 AM

samwilson opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/135

Move the postEdit storage setting to be after saving

Samwilson added a comment.Wed, Jul 3, 8:51 AM

Thanks Dom!

That's a good point about null edits; patch made.

I'm not sure about the failed diff link, am looking into it more now. I have an inkling that it could be T360631.

CodeReviewBot added a comment.Wed, Jul 3, 10:49 AM

samtar merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/135

Move the postEdit storage setting to be after saving

Samwilson added a comment.Thu, Jul 4, 1:23 AM

Could someone confirm that the two post-edit messages should be a) "Your wish has been submitted." and b) "This wish has been updated."?

I went with "Your wish has been submitted" and "Your wish has been saved".

dom_walden added a comment.Thu, Jul 4, 6:36 AM
In T368679#9948887, @CodeReviewBot wrote:

samtar merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/135

Move the postEdit storage setting to be after saving

@Samwilson I am still seeing the toast and banner after a null edit. Has the test environment been updated correctly?

Samwilson moved this task from QA to In development on the Community-Tech (July 1-12 2024 (Corsac Fox)) board.Fri, Jul 5, 12:31 AM
CodeReviewBot added a comment.Fri, Jul 5, 3:36 AM

samwilson opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/145

Move the postEdit storage setting to be after saving

Samwilson added a comment.Fri, Jul 5, 3:51 AM

Has the test environment been updated correctly?

Nope, it seems that the change was overwritten by one for T368549! Oops. I've recreated it and will move this back to QA after it's merged and I've checked that it's deployed. Sorry for the goose chasing.

Samwilson moved this task from In development to Feedback and review on the Community-Tech (July 1-12 2024 (Corsac Fox)) board.Fri, Jul 5, 3:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits