Upstream printfooter clear from en.wp to interface-print.less
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Izno
	Jul 16 2024, 6:43 PM

Description

Right now English Wikipedia has a block like the following in its print.css added by @TheDJ :

.printfooter {
  clear: both;
}

Originally, this looks to have been added to ensure that floating content at the bottom of the page before the print footer did not "fall out" and into the footer. Per some discussion, .mw-body-content has since the skin rework also had a float clear on ::after, but that functions only in @media screen, which misses the point for .printfooter.

An alternative to the title of the mentioned .mw-body-content::after block to something that always loads, whether in print or otherwise. I don't know where that would be.

Details

	Subject	Repo	Branch	Lines +/-
	Print: Clear printfooter from contents	mediawiki/core	master	+1 -0
	Print: Clear printfooter from contents	mediawiki/core	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T371110: Verify 1.43.0-wmf.16 deployment

Event Timeline

Izno created this task.Jul 16 2024, 6:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2024, 6:43 PM

Jdlrobson added a project: Web-Team-Backlog.Jul 16 2024, 7:01 PM

Yes this was a pretty common problem where quite regularly floating content would bleed into the skin over the past 20 years. There was no consistency in skins that dealt with this universally, and quite often it made assumptions about where content could appear. I remember especially this being a problem in the edit/preview screen, where the previewed content would overlap into the edit screen.

But also indeed in print, where some skins would overlap into categories and the printfooter itself of the printed version, because the skins often just didn't implement print correctly, and many elements that ppl assume are visible and styled, are not visible in print.. There was also the old PDF print back then, which was even worse.

TheDJ added a project: Browser-support-print-media.Jul 17 2024, 8:39 AM

alistair3149 subscribed.Jul 17 2024, 8:39 AM

Jdlrobson added a project: patch-welcome.Jul 17 2024, 2:49 PM

Change #1056490 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] Print: Clear printfooter from contents

https://gerrit.wikimedia.org/r/1056490

Change #1056490 abandoned by TheDJ:

[mediawiki/core@master] Print: Clear printfooter from contents

Reason:

error

https://gerrit.wikimedia.org/r/1056490

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2024, 12:30 PM