Page MenuHomePhabricator

account vanishing is locking accounts without logging the action
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Approve a vanish request in the rename queue
  • Look at the target account or the global account log

What happens?:

  • The account is locked
  • The locking action is not logged

What should have happened instead?:

  • The change should be logged with an appropriate reason

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Alternatively we can (1) make vanish (automatic or manual) a dedicated log subtype of global rename log; (2) let Special:CentralAuth show such log.

Amdrel changed the task status from Open to In Progress.Jul 22 2024, 10:49 PM

Change #1056208 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/CentralAuth@master] Publicly log account locking reason for account vanishes

https://gerrit.wikimedia.org/r/1056208

The patch I just uploaded inserts an entry using the existing 'setstatus' log action. This log entry will show up in the site-wide Special:Log page, but since the performer for vanishes is the renamer or the user configured by $wgCentralAuthAutomaticVanishPerformer for automatic vanishes, the log entry will not be viewable from the global account manager logs link since that filters by performer and not the affected user. Please let me know if this works or not and if I need to make changes.

Not following where this will fail to appear?

Will it appear with other locks on Special:CentralAuth?

Yes you can see vanished accounts are locked from that page under "Global account information" when pulling up a user. I was talking about the logs link in the tools sidebar specifically not showing them.

The patch I just uploaded inserts an entry using the existing 'setstatus' log action. This log entry will show up in the site-wide Special:Log page, but since the performer for vanishes is the renamer or the user configured by $wgCentralAuthAutomaticVanishPerformer for automatic vanishes, the log entry will not be viewable from the global account manager logs link since that filters by performer and not the affected user. Please let me know if this works or not and if I need to make changes.

That's the way it is done for any other lock. I've added other feedback in Gerrit.

Change #1056208 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Publicly log account locking reason for account vanishes

https://gerrit.wikimedia.org/r/1056208

While there is now a log entry, the log entry is under the original name instead of the new username (after rename is complete) and missing from Special:CentralAuth.

Example:

Maybe there is some race condition or primary vs secondary DB use issue or the lock log target isn't being updated in the rename process.

Are we able to resolve that? If not, can we rename first then lock?

Change #1071980 had a related patch set uploaded (by Mimurawil; author: Mimurawil):

[mediawiki/extensions/CentralAuth@master] Lock and log account after renaming during account vanish

https://gerrit.wikimedia.org/r/1071980

We have opened a patch to solve the issue above.

This would be the outcome after the user process. Is this what we expected?

image.png (123×945 px, 55 KB)

Yes, but please also confirm that it shows up on Special:CentralAuth for the vanished username.

I can confirm in Special:CentralAuth I can see only the newest username in the logs:

Screenshot 2024-09-11 at 3.18.23 PM.png (321×994 px, 32 KB)

Screenshot 2024-09-11 at 3.18.57 PM.png (207×555 px, 29 KB)

Screenshot 2024-09-11 at 3.19.12 PM.png (161×981 px, 30 KB)

Thanks, F57500726 is what I was looking for. Prior to the change, the lock log entry would not show up there since it was under the old username.

Change #1071980 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Lock and log account after renaming during account vanish

https://gerrit.wikimedia.org/r/1071980

JJMC89 moved this task from Current priorities to Done on the Account-Vanishing board.
JJMC89 updated Other Assignee, added: Mimurawil.