Change #1092830 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Copyright selection updates

https://gerrit.wikimedia.org/r/1092830

Change #1092830 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Copyright selection updates

https://gerrit.wikimedia.org/r/1092830

@matthiasmullie for A new option for custom license under the CC license option in q1 - the label on commons beta says "This feature is temporarily disabled" - is it ok to have it on beta?

Also, please review the following (and adding @Sneha):

The new custom license field
(1) in current production there is validation for user input in "Enter a different license in wikitext format" field
The warning messages, e.g. "The wikitext here is too short to be a license" is placed close to the field itself:

For a new field (currently in commons beta) the warning will be displayed below several fields:

(2) {{CC-by-2.0}} and {{PD-old-70}} are underlined (and they are actual links in figma design), but in beta these are not the links.

That message was overwritten on-wiki to say "This feature is temporarily disabled" (see https://commons.wikimedia.beta.wmflabs.org/wiki/MediaWiki:Mwe-upwiz-license-custom). I deleted that and now it's fine.
FYI: in production, this is not the case. It used to be overwritten there too, but not anymore since 2012: https://commons.wikimedia.org/wiki/MediaWiki:Mwe-upwiz-license-custom

(1) As for validation: the license block as a whole is validated. That always has been the case, but I guess that wasn't as obvious in their old structure.
If that's something we want to change, let's file a new ticket!

(2) I didn't realize that these were actually a link in the design. I find it a bit confusing, though. especially since we have another link in that same line, that *is* blue. But happy to change that if needed.

In T371050#10365113, @matthiasmullie wrote:

That message was overwritten on-wiki to say "This feature is temporarily disabled" (see https://commons.wikimedia.beta.wmflabs.org/wiki/MediaWiki:Mwe-upwiz-license-custom). I deleted that and now it's fine.
FYI: in production, this is not the case. It used to be overwritten there too, but not anymore since 2012: https://commons.wikimedia.org/wiki/MediaWiki:Mwe-upwiz-license-custom

(1) As for validation: the license block as a whole is validated. That always has been the case, but I guess that wasn't as obvious in their old structure.
If that's something we want to change, let's file a new ticket!

(2) I didn't realize that these were actually a link in the design. I find it a bit confusing, though. especially since we have another link in that same line, that *is* blue. But happy to change that if needed.

Thx, @matthiasmullie! Regarding (1) and (2) - I think the input from @Sneha is needed. Moving to Design QA.

@Etonkovidova @matthiasmullie

(1) Yes the validation needs to be closer to the field or question it is referring to. We are already doing this in other parts of the upload wizard such as this AI validation error. If we don't fix it in this ticket it should definitely be captured in another ticket.

(2) The template example in the figma has links as it was meant to show users what templates are like. But since we already have the other link that shows a list of templates/copyright tags its okay to leave the example as implemented i.e. without any link. I will update in Figma to not have link for specific example.

Edit:
For #2 it seems like the link is already implemented in beta for both custom fields. Can we remove it so that it does not have underline and link. Because I agree it looks a bit confusing with another link which is blue.

In T371050#10366336, @Sneha wrote:

@Etonkovidova @matthiasmullie

(1) Yes the validation needs to be closer to the field or question it is referring to. We are already doing this in other parts of the upload wizard such as this AI validation error. If we don't fix it in this ticket it should definitely be captured in another ticket.

@Sneha, @Matthias - I filed it as T381323: UploadWizard: Validation warning for custom license field should be placed closer to the field.

(2) The template example in the figma has links as it was meant to show users what templates are like. But since we already have the other link that shows a list of templates/copyright tags its okay to leave the example as implemented i.e. without any link. I will update in Figma to not have link for specific example.

Edit:
For #2 it seems like the link is already implemented in beta for both custom fields. Can we remove it so that it does not have underline and link. Because I agree it looks a bit confusing with another link which is blue.

It's done.