Page MenuHomePhabricator
Create Task
Maniphest T371316

refreshLinkRecommendations.php does not run when link-recommendation task type is disabled
Closed, ResolvedPublic
Actions

Description

As part of working on T370802: Add a link (Structured task): Release as "turned off" to English Wikipedia, I discovered that the refreshLinkRecommendations.php script does not run when Add Link is disabled via CommunityConfiguration. This is incorrect – the refreshing script is a part of the backend, and as long as the backend flag (GENewcomerTasksLinkRecommendationsEnabled) is enabled, the script should continue running (the CommunityConfiguration flag should affect the frontend only, not the backend). Doing so will enable us to enable Add Link silently, in a way that needs only a community Administrator to enable Add Link via CommunityConfiguration.

Since https://en.wikipedia.org/w/index.php?title=MediaWiki:GrowthExperimentsSuggestedEdits.json&diff=prev&oldid=1237412036, refreshLinkRecommendations.php results in the following at en.wikipedia:

[urbanecm@mwmaint1002 ~]$ mwscript extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php --wiki=enwiki --verbose
'link-recommendation' is not a link recommendation task type
[urbanecm@mwmaint1002 ~]$

Interestingly, revalidateLinkRecommendations.php works just fine, even though Add Link is disabled via CommunityConfiguration, see T370802#10025055.

Details

SubjectRepoBranchLines +/-
refreshLinkRecommendations: Work even when link-recommendation is disabledmediawiki/extensions/GrowthExperimentswmf/1.43.0-wmf.15+26 -0
refreshLinkRecommendations: Work even when link-recommendation is disabledmediawiki/extensions/GrowthExperimentswmf/1.43.0-wmf.16+26 -0
refreshLinkRecommendations: Work even when link-recommendation is disabledmediawiki/extensions/GrowthExperimentsmaster+26 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Jul 29 2024, 7:36 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 29 2024, 7:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF added subscribers: KStoller-WMF, Trizek-WMF.Jul 29 2024, 7:36 PM

@Trizek-WMF @KStoller-WMF Unfortunately, we will have to solve this before we can finish T370802: Add a link (Structured task): Release as "turned off" to English Wikipedia.

Urbanecm_WMF mentioned this in T370802: Add a link (Structured task): Release as "turned off" to English Wikipedia.Jul 29 2024, 7:36 PM
Urbanecm_WMF added a parent task: T370802: Add a link (Structured task): Release as "turned off" to English Wikipedia.
Urbanecm_WMF updated the task description. (Show Details)
KStoller-WMF added a comment.Jul 29 2024, 8:14 PM
In T371316#10025058, @Urbanecm_WMF wrote:

@Trizek-WMF @KStoller-WMF Unfortunately, we will have to solve this before we can finish T370802: Add a link (Structured task): Release as "turned off" to English Wikipedia.

Bummer. Thanks for documenting this issue. Is this small enough that we should pull it into the current sprint?

Michael subscribed.Jul 30 2024, 5:52 AM

🤨

This error seems to come from:

refreshLinkRecommendations.php
	protected function initConfig(): void {
		$taskTypes = $this->configurationLoader->getTaskTypes();
		$taskType = $taskTypes[LinkRecommendationTaskTypeHandler::TASK_TYPE_ID] ?? null;
		if ( !$taskType || !$taskType instanceof LinkRecommendationTaskType ) {
			$this->fatalError( sprintf( "'%s' is not a link recommendation task type",
				LinkRecommendationTaskTypeHandler::TASK_TYPE_ID ) );
		} else {
			$this->recommendationTaskType = $taskType;
		}
		$this->searchUser = User::newSystemUser( 'Maintenance script', [ 'steal' => true ] );
	}

Did this ever work?

Anyway. LinkRecommendationUpdater also loads the disabled tasks types to get the config, we may want to do something similar:

LinkRecommendationUpdater.php
	private function getLinkRecommendationTaskType(): LinkRecommendationTaskType {
		if ( !$this->linkRecommendationTaskType ) {
			$taskTypes = $this->configurationLoader->loadTaskTypes();
			if ( $taskTypes instanceof StatusValue ) {
				throw new WikiConfigException( 'Could not load task types: ' .
					Status::wrap( $taskTypes )->getWikiText( false, false, 'en' ) );
			}
			$taskTypes = $this->configurationLoader->getTaskTypes() +
				$this->configurationLoader->getDisabledTaskTypes();
			$taskType = $taskTypes[LinkRecommendationTaskTypeHandler::TASK_TYPE_ID] ?? null;
			if ( !( $taskType instanceof LinkRecommendationTaskType ) ) {
				throw new WikiConfigException( 'Could not load link recommendation task type' );
			}
			$this->linkRecommendationTaskType = $taskType;
		}
		return $this->linkRecommendationTaskType;
	}
Urbanecm_WMF claimed this task.Jul 30 2024, 9:01 AM
Urbanecm_WMF edited projects, added Growth-Team (FY2024-25 Q1 Sprint 2); removed Growth-Team.

I looked into this, and the task is relatively straightforward. Moving to sprint.

gerritbot added a comment.Jul 30 2024, 9:06 AM

Change #1058091 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] refreshLinkRecommendations: Work even when link-recommendation is disabled

https://gerrit.wikimedia.org/r/1058091

gerritbot added a project: Patch-For-Review.Jul 30 2024, 9:06 AM
Urbanecm_WMF triaged this task as High priority.Jul 30 2024, 10:47 AM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (FY2024-25 Q1 Sprint 2) board.
gerritbot added a comment.Jul 30 2024, 11:18 AM

Change #1058116 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.43.0-wmf.15] refreshLinkRecommendations: Work even when link-recommendation is disabled

https://gerrit.wikimedia.org/r/1058116

gerritbot added a comment.Jul 30 2024, 11:18 AM

Change #1058117 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.43.0-wmf.16] refreshLinkRecommendations: Work even when link-recommendation is disabled

https://gerrit.wikimedia.org/r/1058117

gerritbot added a comment.Jul 30 2024, 11:55 AM

Change #1058091 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refreshLinkRecommendations: Work even when link-recommendation is disabled

https://gerrit.wikimedia.org/r/1058091

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Jul 30 2024, 12:00 PM
gerritbot added a comment.Jul 30 2024, 12:01 PM

Change #1058117 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.43.0-wmf.16] refreshLinkRecommendations: Work even when link-recommendation is disabled

https://gerrit.wikimedia.org/r/1058117

gerritbot added a comment.Jul 30 2024, 12:01 PM

Change #1058116 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.43.0-wmf.15] refreshLinkRecommendations: Work even when link-recommendation is disabled

https://gerrit.wikimedia.org/r/1058116

Stashbot mentioned this in T370558: Disable Add Link backend on hywwiki.Jul 30 2024, 12:02 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-30T12:02:33Z] <urbanecm@deploy1003> Started scap sync-world: Backport for [[gerrit:1057970|[Growth] hywwiki: Disable Add link backend (T370558)]], [[gerrit:1058117|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]], [[gerrit:rODNS10581164f3e4|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]]

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (FY2024-25 Q1 Sprint 2) board.Jul 30 2024, 12:06 PM
Stashbot added a comment.Jul 30 2024, 12:16 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-30T12:16:43Z] <urbanecm@deploy1003> sync-world aborted: Backport for [[gerrit:1057970|[Growth] hywwiki: Disable Add link backend (T370558)]], [[gerrit:1058117|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]], [[gerrit:rODNS10581164f3e4|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]] (duration: 14m 10s)

Stashbot added a comment.Jul 30 2024, 12:17 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-30T12:17:06Z] <urbanecm@deploy1003> Started scap sync-world: Backport for [[gerrit:1057970|[Growth] hywwiki: Disable Add link backend (T370558)]], [[gerrit:1058117|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]], [[gerrit:rODNS10581164f3e4|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]]

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2024, 12:31 PM
Stashbot added a comment.Jul 30 2024, 12:58 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-30T12:58:42Z] <urbanecm@deploy1003> Started scap sync-world: Backport for [[gerrit:1057970|[Growth] hywwiki: Disable Add link backend (T370558)]], [[gerrit:1058117|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]], [[gerrit:rODNS10581164f3e4|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]]

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.16; 2024-07-30); removed MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Jul 30 2024, 1:00 PM
Stashbot added a comment.Jul 30 2024, 1:21 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-30T13:21:13Z] <urbanecm@deploy1003> Finished scap: Backport for [[gerrit:1057970|[Growth] hywwiki: Disable Add link backend (T370558)]], [[gerrit:1058117|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]], [[gerrit:rODNS10581164f3e4|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]] (duration: 22m 31s)

Urbanecm_WMF closed this task as Resolved.Jul 30 2024, 2:28 PM
In T371316#10026197, @Michael wrote:

Did this ever work?

It very likely never did. That's why I mentioned we need to check this in EngSync, as I recalled we had to enable the task in CC before working with the task pool.

Anyway, it does work now:

[urbanecm@mwmaint1002 ~]$ mwscript extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php --wiki=enwiki
Refreshing link recommendations...
  processing topic biography...
    no new tasks needed
  processing topic women...
    no new tasks needed
  processing topic food-and-drink...
    no new tasks needed
  processing topic internet-culture...
    no new tasks needed
  processing topic linguistics...
    no new tasks needed
  processing topic literature...
    no new tasks needed
  processing topic books...
    no new tasks needed
  processing topic entertainment...
    no new tasks needed
  processing topic films...
    no new tasks needed
  processing topic media...
    no new tasks needed
  processing topic music...
    no new tasks needed
  processing topic radio...
    no new tasks needed
  processing topic software...
    no new tasks needed
  processing topic television...
    no new tasks needed
  processing topic video-games...
    no new tasks needed
  processing topic performing-arts...
    no new tasks needed
  processing topic philosophy-and-religion...
    no new tasks needed
  processing topic sports...
^C
[urbanecm@mwmaint1002 ~]$

So, all good now.

Urbanecm_WMF mentioned this in T373176: fixLinkRecommendationData.php does not run when link-recommendation task type is disabled.Fri, Aug 23, 9:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits