Page MenuHomePhabricator

Github Actions CI - pull from phabricator.wikimedia.org blocked 429
Open, Needs TriagePublic

Description

Current Situation:

  • Our github action runners are blocked from git cloning from phabricator.
  • This breaks the build of wikibase and therefore our whole CI pipeline

Goal:

  • Fix CI

Acceptance Criteria:

  • Wikibase builds in CI

[optional] Notes:

[optional] Open Questions:

Event Timeline

I have also noticed this and worked around it for my own projects. However, I imagine that the recently added cloning restriction is hitting many users of Wikibase that suddenly see their submodule cloning fail. A fix of the root cause or workaround that works for everyone will limit the damage to the community.

To add some more specific details, we are cloning like this:
git clone https://github.com/wikimedia/mediawiki-extensions-Wikibase --branch=REL1_39 --depth=1 --recurse-submodules

And then the 3 submodule clones fail like this:
fatal: unable to access 'https://phabricator.wikimedia.org/source/wikibase-data-model.git/': The requested URL returned error: 429
fatal: unable to access 'https://phabricator.wikimedia.org/source/datavalues-javascript.git/': The requested URL returned error: 429
fatal: unable to access 'https://phabricator.wikimedia.org/source/wikibase-serialization.git/': The requested URL returned error: 429

We noticed this happing since at least Friday, 9 August.

The original change introducing this checkout strategy rEWBA2edbce09c29b6ca33b8f5c05f7e98613e5c647cf

Apparently this had some unwanted side effects T349921

The workaround PR for Wikibase Suite https://github.com/wmde/wikibase-release-pipeline/pull/753

Workaround PR merged to main. Leaving this open for long term solution.

Internal thread https://mattermost.wikimedia.de/swe/pl/ux4aa1q8wjn7uno1btaiwxeyse

@JeroenDeDauw You mentioned:

recently added cloning restriction

Do you have a reference? This could ease following up on our side.

Change #1063209 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Clone Wikibase submodules from GitHub

https://gerrit.wikimedia.org/r/1063209

Change #1063209 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Clone Wikibase submodules from GitHub

https://gerrit.wikimedia.org/r/1063209

Wrong task, sorry!

I see that this is breaking the CI of various community extensions. Example: https://github.com/ProfessionalWiki/WikibaseEdtf/actions

For all my use cases this issue has not been solved at all.

The original change introducing this checkout strategy rEWBA2edbce09c29b6ca33b8f5c05f7e98613e5c647cf

The issue showed up about 3 months ago. It is not caused by submodule changes in 2017.

Do you have a reference? This could ease following up on our side.

Nope. I guess this was something done by the WMF operations folks somewhere on Gerrit.