Page MenuHomePhabricator

Don't send entire new talk page message when user has been reverted multiple times by Automoderator in the same month
Closed, ResolvedPublic8 Estimated Story Points

Description

Currently, if a user is reverted by Automoderator and receives a talk page message, they receive an entirely new heading and full message every time. This can make user talk page messages very messy for persistent vandals who don't get blocked for a little while. See, for example, User talk:~2024-3342.

Instead, we could be appending a shorter message to a relevant previous heading, which simply notes that another edit has been reverted. This message should also be a system message for translation and local overwriting.

If Automoderator finds a talk page message sent this month, instead of sending an entirely new message, it should instead add an intended response to the last message (in the same section), like:

:I also reverted one of your recent edits to PAGE because it seemed unconstructive. ~~~~

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This would match behaviour of many existing anti-vandalism bots such as ClueBot NG, which append follow-up messages to their (or other user's) previous ones:

image.png (924×1 px, 323 KB)

Just noting that an advantage to our current approach is that we don't have to parse the current state of the talk page regarding threads, we just always append. If we are going to stick with the current approach, we should probably adjust the subject so that it's clear that it is per-edit, not per-month.

Scardenasmolinar moved this task from To be estimated to Up next on the Moderator-Tools-Team board.
Samwalton9-WMF moved this task from Backlog to Communication on the Automoderator board.
Scardenasmolinar changed the task status from Open to In Progress.Sep 10 2024, 2:48 AM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar changed the task status from In Progress to Stalled.Sep 18 2024, 6:32 PM
Scardenasmolinar removed Scardenasmolinar as the assignee of this task.
Scardenasmolinar moved this task from In Progress to Ready on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar subscribed.

This task is now stalled until T375121 is solved. Moving this back to Ready.

Scardenasmolinar changed the task status from Stalled to In Progress.Sep 24 2024, 10:25 PM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

This is now unstalled because T375121 has been merged.

Change #1076897 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/AutoModerator@master] Add follow-up message instead of sending new one

https://gerrit.wikimedia.org/r/1076897

Scardenasmolinar changed the point value for this task from 5 to 8.Oct 2 2024, 6:04 PM

Based on discussions in our engineering meeting today, I am going to refactor the message sending to incorporate the Discussion Tools API for sending all AutoModerator talk page messages.

@Dogu @Renvoy I know your wikis aren't currently using the talk page message, but in case you're interested this issue is now resolved. It requires a translation to be updated (and then to go live on your wiki), after which talk page messages should work as expected.

Noting that we would need to change the talk page header translation string again (hope this is the last time). We removed the header wikitext because it is no longer needed. FYI @Samwalton9-WMF

Change #1082840 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[integration/config@master] AutoModerator: Add DiscussionTools as a dependency

https://gerrit.wikimedia.org/r/1082840

Change #1084211 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/AutoModerator@master] Add follow-up message

https://gerrit.wikimedia.org/r/1084211

Change #1084211 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Add follow-up message

https://gerrit.wikimedia.org/r/1084211

Change #1084891 had a related patch set uploaded (by Jsn.sherman; author: Scardenasmolinar):

[mediawiki/extensions/AutoModerator@wmf/1.44.0-wmf.1] Add follow-up message

https://gerrit.wikimedia.org/r/1084891

Change #1084891 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@wmf/1.44.0-wmf.1] Add follow-up message

https://gerrit.wikimedia.org/r/1084891

Mentioned in SAL (#wikimedia-operations) [2024-10-31T20:28:16Z] <jsn@deploy2002> Started scap sync-world: Backport for [[gerrit:1084889|Translations for configuration for same-user-same-page reverts in Automoderator (T370795)]], [[gerrit:1084891|Add follow-up message (T372476)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-31T20:46:10Z] <jsn@deploy2002> jsn: Backport for [[gerrit:1084889|Translations for configuration for same-user-same-page reverts in Automoderator (T370795)]], [[gerrit:1084891|Add follow-up message (T372476)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-10-31T20:55:27Z] <jsn@deploy2002> Finished scap sync-world: Backport for [[gerrit:1084889|Translations for configuration for same-user-same-page reverts in Automoderator (T370795)]], [[gerrit:1084891|Add follow-up message (T372476)]] (duration: 27m 10s)

The automoderator-wiki-revert-message-follow-up message has been backported; it should be translated on wikitranslate as soon as it becomes available there

Change #1082840 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/AutoModerator] Add DiscussionTools dependency

https://gerrit.wikimedia.org/r/1082840

Change #1076897 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Add follow-up message instead of sending new one

https://gerrit.wikimedia.org/r/1076897

@Bonaditya I'm sorry to say that this briefly caused another bug on id.wiki - some talk page messages did not have their header formatted correctly, i.e. it did not have the == markup. Would it be possible for you to check messages from the last 1-2 weeks and fix these, so that talk pages work as expected? Thanks!

@Bonaditya I'm sorry to say that this briefly caused another bug on id.wiki - some talk page messages did not have their header formatted correctly, i.e. it did not have the == markup. Would it be possible for you to check messages from the last 1-2 weeks and fix these, so that talk pages work as expected? Thanks!

There were only 4 such cases, so I fixed them today!

jsn.sherman moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.