Pending discussion with @Sarai-WMF, we should probably have better inline validation for all the forms.
POC with vestjs - https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/89
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T378202 [Epic] MPIC: UI & Copy improvement implementation | |||
| Resolved | Sarai-WMF | T371928 MPIC: Style and UX review | |||
| Open | None | T372952 MPIC: Add better validation to forms |
Thank you for creating this ticket, @cjming! This will be an essential feature of the form 🙏🏻
We'll discuss it more when the time comes to define specs for this ticket, but: while I originally thought that introducing global "on submission" validation would suffice, after interacting more with MPIC I believe that there are some errors that we might want to help prevent by providing immediate feedback.
Specifically, I'd evaluate applying inline validation with lookup-type fields (e.g. selection of an existing instrument, contextual attributes, location). This could help prevent complex errors that could result in the loss of information when these fields are populated with invalid/non-matching data.
But, as mentioned, let's evaluate this together once this task is prioritized.
This tasks need a consistent design approach to validation that is informed by the system requirements.
@cjming yes, on hold.
@Sarai-WMF will have 5% of her time to continue to support us with design reviews. So we may be able to get this depending on how much time is required for design validation work.