Page MenuHomePhabricator
Create Task
Maniphest T373830

Deprecated: Use of MediaWiki\Output\OutputPage::setCategoryLinks was deprecated [Called from MediaWiki\Specials\SpecialExpandTemplates::showHtmlPreview]
Closed, ResolvedPublic
Actions

Description

I see the following warning locally when submitting the form on Special:ExpandTemplates:

Deprecated: Use of MediaWiki\Output\OutputPage::setCategoryLinks was deprecated in MediaWiki 1.43. [Called from MediaWiki\Specials\SpecialExpandTemplates::showHtmlPreview in /var/www/html/w/includes/specials/SpecialExpandTemplates.php at line 280] in /var/www/html/w/includes/debug/MWDebug.php on line 385

It was deprecated in rMW3739467256f3: Deprecate OutputPage::setCategoryLinks() for T373480: Display categories in sorted order by default.

Details

SubjectRepoBranchLines +/-
SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks()mediawiki/corewmf/1.43.0-wmf.21+1 -1
SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks()mediawiki/corewmf/1.43.0-wmf.22+1 -1
SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks()mediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Tue, Sep 3, 12:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Sep 3, 12:07 AM
Izno edited projects, added MediaWiki-Special-pages; removed MediaWiki-General.Tue, Sep 3, 4:37 AM
Izno moved this task from To triage to Special:ExpandTemplates on the MediaWiki-Special-pages board.
SLopes-WMF assigned this task to cscott.Thu, Sep 5, 2:10 PM
SLopes-WMF edited projects, added Essential-Work, Content-Transform-Team-WIP; removed Content-Transform-Team.
dduvall added a project: Wikimedia-production-error.EditedWed, Sep 11, 6:31 PM
dduvall subscribed.

Spotted this during 1.43.0-wmf.22 deployment today. It seems to have occurred for wmf.21 as well. I won't block train on it since it predates this week's branch, but it would be great to get this fixed soon to reduce log spam.

gerritbot added a comment.Wed, Sep 11, 6:39 PM

Change #1072275 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks()

https://gerrit.wikimedia.org/r/1072275

gerritbot added a project: Patch-For-Review.Wed, Sep 11, 6:39 PM
Jdforrester-WMF added a comment.Wed, Sep 11, 6:39 PM

Oops, yes, missed in 3739467256f3.

gerritbot added a comment.Wed, Sep 11, 10:07 PM

Change #1072305 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@wmf/1.43.0-wmf.22] SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks()

https://gerrit.wikimedia.org/r/1072305

gerritbot added a comment.Wed, Sep 11, 10:07 PM

Change #1072306 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@wmf/1.43.0-wmf.21] SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks()

https://gerrit.wikimedia.org/r/1072306

gerritbot added a comment.Wed, Sep 11, 10:27 PM

Change #1072275 merged by jenkins-bot:

[mediawiki/core@master] SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks()

https://gerrit.wikimedia.org/r/1072275

gerritbot added a comment.Wed, Sep 11, 10:38 PM

Change #1072305 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.22] SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks()

https://gerrit.wikimedia.org/r/1072305

gerritbot added a comment.Wed, Sep 11, 10:38 PM

Change #1072306 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.21] SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks()

https://gerrit.wikimedia.org/r/1072306

Stashbot added a comment.Wed, Sep 11, 10:38 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-11T22:38:56Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1072305|SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks() (T373830)]], [[gerrit:1072306|SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks() (T373830)]]

Stashbot added a comment.Wed, Sep 11, 10:41 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-11T22:41:03Z] <jforrester@deploy1003> jforrester: Backport for [[gerrit:1072305|SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks() (T373830)]], [[gerrit:1072306|SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks() (T373830)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Wed, Sep 11, 10:46 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-11T22:46:24Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1072305|SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks() (T373830)]], [[gerrit:1072306|SpecialExpandTemplates: Replace use of deprecated OutputPage::addCategoryLinks() (T373830)]] (duration: 07m 27s)

Jdforrester-WMF closed this task as Resolved.Wed, Sep 11, 10:53 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.23; 2024-09-17).Wed, Sep 11, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Wed, Sep 11, 11:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits