Page MenuHomePhabricator
Create Task
Maniphest T374246

CdxLookup: update:selected event is triggered every time that the input value changes
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue

  1. Go to Wikifunctions Special:CreateObject page: https://wikifunctions.beta.wmflabs.org/wiki/Special:CreateObject
  2. In the "Contents" section, in the type selector, search for something (E.g. typing "text" or "lang" should render results)

What happens?

  • The input doesn't appear and the user is focused out of the field

What should have happened instead?

  • The user should be able to input text
  • A dropdown with options is displayed and the user should be able to pick

Demo video
https://www.loom.com/share/566d9facf5da42dca0eb889c8e10969c?sid=dffd33a2-3fd5-4411-abc1-53bd3e133f04

Software version

  • Codex 1.12.0

Details

SubjectRepoBranchLines +/-
Lookup: Only clear selection on input if there is onedesign/codexmain+2 -1
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.Sep 6 2024, 2:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2024, 2:27 PM
gengh mentioned this in T374248: ZObjectSelector: Adapt to new CdxLookup behavior after release v1.12.0.Sep 6 2024, 2:52 PM
egardner edited projects, added Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)); removed Design-System-Team.Sep 6 2024, 3:59 PM
egardner set the point value for this task to 2.
CCiufo-WMF triaged this task as High priority.Sep 6 2024, 6:35 PM
gerritbot added a comment.Sep 9 2024, 1:28 PM

Change #1071614 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] Lookup: Only clear selection on input if there is one

https://gerrit.wikimedia.org/r/1071614

gerritbot added a project: Patch-For-Review.Sep 9 2024, 1:28 PM
AnneT claimed this task.Sep 9 2024, 1:29 PM
AnneT moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)) board.
gerritbot added a comment.Sep 11 2024, 10:20 PM

Change #1071614 merged by jenkins-bot:

[design/codex@main] Lookup: Only clear selection on input if there is one

https://gerrit.wikimedia.org/r/1071614

egardner moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)) board.Sep 11 2024, 10:21 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2024, 10:30 PM
gerritbot added a comment.Sep 17 2024, 9:20 PM

Change #1073562 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.12.0 to v1.13.0

https://gerrit.wikimedia.org/r/1073562

gerritbot added a project: Patch-For-Review.Sep 17 2024, 9:20 PM
PatchDemoBot added a comment.Sep 17 2024, 9:24 PM

Test wiki created on Patch demo by LWatson-WMF using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/ceebb67189/wiki/Main Page

AnneT added a comment.Sep 18 2024, 1:18 PM

@gengh FYI this has been resolve and is part of Codex 1.13.0, which was merged into core yesterday!

lwatson closed this task as Resolved.Sep 18 2024, 1:42 PM
lwatson removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits