Page MenuHomePhabricator
Create Task
Maniphest T376433

TypeError: Argument 1 passed to Wikimedia\Stats\Metrics\CounterMetric::incrementBy() must be of the type float, null given
Open, Needs TriagePublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to Wikimedia\Stats\Metrics\CounterMetric::incrementBy() must be of the type float, null given, called in /srv/mediawiki/php-1.43.0-wmf.25/includes/page/ParserOutputAccess.php on line 469
FrameLocationCall
from/srv/mediawiki/php-1.43.0-wmf.25/includes/libs/Stats/Metrics/CounterMetric.php(75)
#0/srv/mediawiki/php-1.43.0-wmf.25/includes/page/ParserOutputAccess.php(469)Wikimedia\Stats\Metrics\CounterMetric->incrementBy(null)
#1/srv/mediawiki/php-1.43.0-wmf.25/includes/page/ParserOutputAccess.php(364)MediaWiki\Page\ParserOutputAccess->renderRevision(MediaWiki\Page\PageStoreRecord, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, int, MediaWiki\Parser\ParserOutput)
#2/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(892)MediaWiki\Page\ParserOutputAccess->getParserOutput(MediaWiki\Page\PageStoreRecord, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, int)
#3/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(633)MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getParserOutputInternal(ParserOptions)
#4/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(558)MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getParserOutput()
#5/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/Handler/RevisionHTMLHandler.php(111)MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getETag(string)
#6/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/Handler.php(479)MediaWiki\Rest\Handler\RevisionHTMLHandler->getETag()
#7/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/Handler.php(496)MediaWiki\Rest\Handler->getConditionalHeaderUtil()
#8/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/Module/Module.php(380)MediaWiki\Rest\Handler->checkPreconditions()
#9/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/Module/Module.php(269)MediaWiki\Rest\Module\Module->executeHandler(MediaWiki\Rest\Handler\RevisionHTMLHandler)
#10/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/Router.php(488)MediaWiki\Rest\Module\Module->execute(string, MediaWiki\Rest\RequestFromGlobals)
#11/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/Router.php(447)MediaWiki\Rest\Router->doExecute(string, MediaWiki\Rest\RequestFromGlobals)
#12/srv/mediawiki/php-1.43.0-wmf.25/includes/Rest/EntryPoint.php(211)MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#13/srv/mediawiki/php-1.43.0-wmf.25/includes/MediaWikiEntryPoint.php(200)MediaWiki\Rest\EntryPoint->execute()
#14/srv/mediawiki/php-1.43.0-wmf.25/rest.php(39)MediaWiki\MediaWikiEntryPoint->run()
#15/srv/mediawiki/w/rest.php(3)require(string)
#16{main}
Impact
Notes

Seeing these since roughly 21:30 UTC. Fallout from https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1077460 or https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1077792 ?

Details

Request URL
https://www.wikidata.org/w/rest.php/v1/revision/1961805404/html
SubjectRepoBranchLines +/-
Turn on Parsoid Selective Update metrics (take 2)operations/mediawiki-configmaster+4 -0
Parsoid selective update metrics: don't crash if no time profile availablemediawiki/coremaster+4 -4
ParserOutput: ensure all created ParserOutputs have a "start of parse" time setmediawiki/coremaster+48 -6
Document ParserOutput::resetParseStartTime() contract a bit moremediawiki/coremaster+3 -0
Ensure ParserOutput::getTimeProfile() is valid for all ContentHandlersmediawiki/extensions/Wikibasemaster+3 -0
Revert "Turn on Parsoid Selective Update metrics"operations/mediawiki-configmaster+0 -4
Customize query in gerrit

Related Objects

Event Timeline

brennen created this task.Thu, Oct 3, 10:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Oct 3, 10:09 PM
gerritbot added a comment.Thu, Oct 3, 10:13 PM

Change #1077802 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] Revert "Turn on Parsoid Selective Update metrics"

https://gerrit.wikimedia.org/r/1077802

gerritbot added a project: Patch-For-Review.Thu, Oct 3, 10:13 PM
cscott subscribed.Thu, Oct 3, 10:13 PM

The root cause is probably

$timeStat->incrementBy( $output->getTimeProfile( 'cpu' ) );

I hadn't considered that ParserOutput::getTimeProfile could return null, but I guess there are some parse paths which are hitting this.

The quickest fix is probably to revert the mediawiki-config patch https://gerrit.wikimedia.org/r/1077460 which should prevent the error.

gerritbot added a comment.Thu, Oct 3, 10:15 PM

Change #1077802 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Turn on Parsoid Selective Update metrics"

https://gerrit.wikimedia.org/r/1077802

Stashbot added a comment.Thu, Oct 3, 10:15 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-03T22:15:50Z] <brennen@deploy2002> Started scap sync-world: Backport for [[gerrit:1077802|Revert "Turn on Parsoid Selective Update metrics" (T376433)]]

cscott added a comment.Thu, Oct 3, 10:16 PM

The more proper, slower, fix would probably to fix the codepaths which don't record parse timing data; it looks like it's the REST API through HtmlOutputRendererHelper which is at fault here, but I should do a proper thorough audit (like we did for render id) to ensure that every parser path is calling ParserOutput::resetParseStartTime/::recordTimeProfile() at the appropriate points.

Stashbot added a comment.Thu, Oct 3, 10:18 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-03T22:18:22Z] <brennen@deploy2002> Started scap sync-world: Backport for [[gerrit:1077802|Revert "Turn on Parsoid Selective Update metrics" (T376433)]]

cscott added a comment.Thu, Oct 3, 10:24 PM

The linked exception was coming from https://www.wikidata.org/w/rest.php/v1/revision/1961805404/html which is a non-wikitext content model I believe. So two learnings here: I should probably restrict the statistics to the wikitext content model, since I'm trying to measure parsoid optimization possibilities; and two although the time profile is recorded in the generic ContentHandler::getParserOutput(), I'm guessing that wikidata is doing 'something' in its implementation of ContentHandler::fillParserOutput() which is preventing the times from being successfully recorded.

cscott added a comment.Thu, Oct 3, 10:28 PM

(yeah, confirming these are all from wikidatawiki)

Maintenance_bot removed a project: Patch-For-Review.Thu, Oct 3, 10:30 PM
Stashbot added a comment.Thu, Oct 3, 10:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-03T22:30:49Z] <brennen@deploy2002> Started scap sync-world: Backport for [[gerrit:1077802|Revert "Turn on Parsoid Selective Update metrics" (T376433)]]

Stashbot added a comment.Thu, Oct 3, 10:32 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-03T22:32:54Z] <brennen@deploy2002> brennen: Backport for [[gerrit:1077802|Revert "Turn on Parsoid Selective Update metrics" (T376433)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Thu, Oct 3, 10:37 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-03T22:37:53Z] <brennen@deploy2002> Finished scap sync-world: Backport for [[gerrit:1077802|Revert "Turn on Parsoid Selective Update metrics" (T376433)]] (duration: 07m 04s)

gerritbot added a comment.Thu, Oct 3, 10:54 PM

Change #1077805 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Wikibase@master] Ensure ParserOutput::getTimeProfile() is valid for all ContentHandlers

https://gerrit.wikimedia.org/r/1077805

gerritbot added a project: Patch-For-Review.Thu, Oct 3, 10:54 PM
gerritbot added a comment.Thu, Oct 3, 10:58 PM

Change #1077808 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput: ensure all created ParserOutputs have a "start of parse" time set

https://gerrit.wikimedia.org/r/1077808

gerritbot added a comment.Thu, Oct 3, 11:03 PM

Change #1077810 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Parsoid selective update metrics: don't crash if no time profile available

https://gerrit.wikimedia.org/r/1077810

Aklapper added a project: MediaWiki-Parser.Fri, Oct 4, 6:58 AM
gerritbot added a comment.Mon, Oct 7, 9:41 AM

Change #1078360 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] Document ParserOutput::resetParseStartTime() contract a bit more

https://gerrit.wikimedia.org/r/1078360

gerritbot added a comment.Mon, Oct 7, 10:16 AM

Change #1077805 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Ensure ParserOutput::getTimeProfile() is valid for all ContentHandlers

https://gerrit.wikimedia.org/r/1077805

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.26; 2024-10-08).Mon, Oct 7, 11:00 AM
gerritbot added a comment.Mon, Oct 7, 8:08 PM

Change #1078360 merged by jenkins-bot:

[mediawiki/core@master] Document ParserOutput::resetParseStartTime() contract a bit more

https://gerrit.wikimedia.org/r/1078360

gerritbot added a comment.Mon, Oct 7, 11:13 PM

Change #1077808 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput: ensure all created ParserOutputs have a "start of parse" time set

https://gerrit.wikimedia.org/r/1077808

gerritbot added a comment.Thu, Oct 10, 12:52 PM

Change #1079274 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[operations/mediawiki-config@master] Turn on Parsoid Selective Update metrics (take 2)

https://gerrit.wikimedia.org/r/1079274

gerritbot added a comment.Thu, Oct 10, 1:20 PM

Change #1079274 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn on Parsoid Selective Update metrics (take 2)

https://gerrit.wikimedia.org/r/1079274

Stashbot mentioned this in T371713: Instrumentation & data gathering to inform future performance & templating improvements.Thu, Oct 10, 1:21 PM
Stashbot mentioned this in T376048: MFE still have issues with Parsoid Read Views on talk pages (Discussion Tools).
Stashbot mentioned this in T269499: [Epic] Make MobileFrontend compatible with Parsoid HTML.

Mentioned in SAL (#wikimedia-operations) [2024-10-10T13:20:59Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1075635|Turn on mobile support for Parsoid Read Views (but not on talk pages) (T269499 T376048)]], [[gerrit:1079274|Turn on Parsoid Selective Update metrics (take 2) (T371713 T376433)]]

Stashbot added a comment.Thu, Oct 10, 1:23 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-10T13:23:01Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde, cscott: Backport for [[gerrit:1075635|Turn on mobile support for Parsoid Read Views (but not on talk pages) (T269499 T376048)]], [[gerrit:1079274|Turn on Parsoid Selective Update metrics (take 2) (T371713 T376433)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Thu, Oct 10, 1:37 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-10T13:37:09Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1075635|Turn on mobile support for Parsoid Read Views (but not on talk pages) (T269499 T376048)]], [[gerrit:1079274|Turn on Parsoid Selective Update metrics (take 2) (T371713 T376433)]] (duration: 16m 09s)

Krinkle added a project: Content-Transform-Team.Thu, Oct 10, 3:35 PM
Krinkle moved this task from Untriaged to Oct 2024 on the Wikimedia-production-error board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits