Page MenuHomePhabricator
Create Task
Maniphest T377521

Remove deprecated skin methods, hard deprecate soft deprecated methods
Closed, ResolvedPublic
Actions

Description

Remove the following methods:

  • Skin::makeSearchInput
  • Skin::makeSearchButton
  • Skin::buildContentNavigationUrls

The following methods were soft deprecated and should now be hard deprecated:

  • Skin::makeSpecialUrl
  • SkinFactory::getSkinNames
  • Skin::makeSpecialUrlSubpage

Sign off steps

Details

SubjectRepoBranchLines +/-
ChangeSkinPref: Replace deprecated SkinFactory::getSkinNames() callmediawiki/extensions/WikimediaMaintenanceREL1_43+1 -1
Hard deprecate soft deprecated skin methodsmediawiki/coreREL1_43+5 -12
doc: Remove references to removed Skin methodmediawiki/skins/WikimediaApiPortalmaster+1 -2
RELEASE NOTES: Update release note relating to hard deprecationmediawiki/coremaster+6 -0
RELEASE NOTES: Update release note relating to hard deprecationmediawiki/coreREL1_43+6 -0
SkinFactory::getSkinNames is deprecated, use getInstalledSkinsmediawiki/extensions/VisualEditorREL1_43+1 -1
SpecialGadgets: Replace deprecated SkinFactory::getSkinNames() callmediawiki/extensions/GadgetsREL1_43+1 -1
Hard deprecate soft deprecated skin methodsmediawiki/coremaster+5 -12
SkinFactory::getSkinNames is deprecated, use getInstalledSkinsmediawiki/extensions/VisualEditorREL1_39+1 -1
Future-proofingmediawiki/extensions/Thememaster+10 -3
tests: restore test for deprecated skin methodsmediawiki/coremaster+12 -0
ChangeSkinPref: Replace deprecated SkinFactory::getSkinNames() callmediawiki/extensions/WikimediaMaintenancewmf/1.44.0-wmf.1+1 -1
SpecialGadgets: Replace deprecated SkinFactory::getSkinNames() callmediawiki/extensions/Gadgetswmf/1.44.0-wmf.1+1 -1
ChangeSkinPref: Replace deprecated SkinFactory::getSkinNames() callmediawiki/extensions/WikimediaMaintenancemaster+1 -1
SpecialGadgets: Replace deprecated SkinFactory::getSkinNames() callmediawiki/extensions/Gadgetsmaster+1 -1
SkinFactory::getSkinNames is deprecated, use getInstalledSkinsmediawiki/extensions/VisualEditormaster+1 -1
Skin: Remove deprecated skin methodsmediawiki/coremaster+9 -83
Don't use deprecated skin methodmediawiki/extensions/UploadWizardmaster+3 -3
Don't use deprecated methodsmediawiki/extensions/Collectionmaster+45 -45
Don't use deprecated methodmediawiki/skins/CologneBluemaster+2 -1
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Oct 17 2024, 10:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2024, 10:43 PM
gerritbot added a comment.Oct 17 2024, 10:44 PM

Change #1081274 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Skin: Deprecate skin methods

https://gerrit.wikimedia.org/r/1081274

gerritbot added a project: Patch-For-Review.Oct 17 2024, 10:44 PM
Jdlrobson renamed this task from Remove deprecated skin methods to Remove deprecated skin methods, hard deprecate soft deprecated methods.Oct 17 2024, 10:54 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Oct 17 2024, 10:54 PM

Change #1081276 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Hard deprecate soft deprecated skin methods

https://gerrit.wikimedia.org/r/1081276

Jdlrobson updated the task description. (Show Details)Oct 17 2024, 10:54 PM
gerritbot added a comment.Oct 17 2024, 10:59 PM

Change #1081280 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/CologneBlue@master] Don't use deprecated method

https://gerrit.wikimedia.org/r/1081280

gerritbot added a comment.Oct 17 2024, 11:00 PM

Change #1081283 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UploadWizard@master] Don't use deprecated skin method

https://gerrit.wikimedia.org/r/1081283

gerritbot added a comment.Oct 17 2024, 11:03 PM

Change #1081284 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Collection@master] Don't use deprecated methods

https://gerrit.wikimedia.org/r/1081284

gerritbot added a comment.Oct 18 2024, 12:14 AM

Change #1081280 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Don't use deprecated method

https://gerrit.wikimedia.org/r/1081280

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Oct 18 2024, 1:00 AM
gerritbot added a comment.Oct 18 2024, 2:41 PM

Change #1081283 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Don't use deprecated skin method

https://gerrit.wikimedia.org/r/1081283

gerritbot added a comment.Oct 18 2024, 2:44 PM

Change #1081284 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Don't use deprecated methods

https://gerrit.wikimedia.org/r/1081284

Jdlrobson triaged this task as High priority.Oct 18 2024, 6:22 PM
gerritbot added a comment.Oct 19 2024, 6:52 PM

Change #1081274 merged by jenkins-bot:

[mediawiki/core@master] Skin: Remove deprecated skin methods

https://gerrit.wikimedia.org/r/1081274

Jdlrobson closed this task as Resolved.Oct 21 2024, 5:04 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson reopened this task as Open.Oct 21 2024, 11:30 PM
Jdlrobson changed the task status from Open to Stalled.
Jdlrobson updated the task description. (Show Details)

Blocked by T377666

gerritbot added a comment.Wed, Oct 23, 3:38 PM

Change #1082495 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] SkinFactory::getSkinNames is deprecated, use getInstalledSkins

https://gerrit.wikimedia.org/r/1082495

gerritbot added a comment.Wed, Oct 23, 5:45 PM

Change #1082495 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] SkinFactory::getSkinNames is deprecated, use getInstalledSkins

https://gerrit.wikimedia.org/r/1082495

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Wed, Oct 23, 6:00 PM
gerritbot added a comment.Wed, Oct 23, 6:31 PM

Change #1081276 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate soft deprecated skin methods

https://gerrit.wikimedia.org/r/1081276

Jdlrobson closed this task as Resolved.Wed, Oct 23, 7:18 PM
Jdlrobson updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Wed, Oct 23, 7:31 PM
Reedy reopened this task as Open.Tue, Oct 29, 12:46 AM
gerritbot added a comment.Tue, Oct 29, 12:47 AM

Change #1083942 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Gadgets@master] SpecialGadgets: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1083942

gerritbot added a project: Patch-For-Review.Tue, Oct 29, 12:47 AM

Change #1083943 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WikimediaMaintenance@master] ChangeSkinPref: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1083943

Reedy mentioned this in T375660: 1.44.0-wmf.1 deployment blockers.Tue, Oct 29, 12:51 AM
Reedy subscribed.Tue, Oct 29, 12:56 AM

SkinTemplate::buildContentNavigationUrls is still referenced in numerous repos too, in comments

https://codesearch.wmcloud.org/search/?q=buildContentNavigationUrls&files=&excludeFiles=&repos=

VisualEditor, MinervaNeue, DiscussionTools and WikimediaApiPortal...

gerritbot added a comment.Tue, Oct 29, 1:52 AM

Change #1083950 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/Theme@master] Future-proofing

https://gerrit.wikimedia.org/r/1083950

Reedy added a parent task: T375660: 1.44.0-wmf.1 deployment blockers.Tue, Oct 29, 2:01 AM
gerritbot added a comment.Tue, Oct 29, 5:01 AM

Change #1083942 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] SpecialGadgets: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1083942

gerritbot added a comment.Tue, Oct 29, 5:01 AM

Change #1083943 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] ChangeSkinPref: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1083943

gerritbot added a comment.Tue, Oct 29, 5:01 AM

Change #1083962 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Gadgets@wmf/1.44.0-wmf.1] SpecialGadgets: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1083962

gerritbot added a comment.Tue, Oct 29, 5:02 AM

Change #1083963 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WikimediaMaintenance@wmf/1.44.0-wmf.1] ChangeSkinPref: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1083963

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.2; 2024-11-05); removed MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Tue, Oct 29, 6:00 AM
gerritbot added a comment.Tue, Oct 29, 2:31 PM

Change #1083962 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@wmf/1.44.0-wmf.1] SpecialGadgets: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1083962

gerritbot added a comment.Tue, Oct 29, 2:31 PM

Change #1083963 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@wmf/1.44.0-wmf.1] ChangeSkinPref: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1083963

Stashbot added a comment.Tue, Oct 29, 2:32 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-29T14:32:51Z] <reedy@deploy2002> Started scap sync-world: 1.44.0-wmf.1 backports to fix deprecated logspam T375660 T377521

Stashbot added a comment.Tue, Oct 29, 2:40 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-29T14:40:13Z] <reedy@deploy2002> Finished scap sync-world: 1.44.0-wmf.1 backports to fix deprecated logspam T375660 T377521 (duration: 07m 21s)

Reedy removed a parent task: T375660: 1.44.0-wmf.1 deployment blockers.Tue, Oct 29, 2:45 PM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.1; 2024-10-29); removed MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Tue, Oct 29, 3:00 PM
gerritbot added a comment.Tue, Oct 29, 3:28 PM

Change #1084142 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] tests: restore test for deprecated skin methods

https://gerrit.wikimedia.org/r/1084142

Jdlrobson updated the task description. (Show Details)Tue, Oct 29, 3:52 PM

Thanks @Reedy for the backports (I'm also wondering if these could have been flagged while this code was on the beta cluster via an alert - the search tool only gets so far)

In T377521#10270841, @Reedy wrote:

SkinTemplate::buildContentNavigationUrls is still referenced in numerous repos too, in comments

https://codesearch.wmcloud.org/search/?q=buildContentNavigationUrls&files=&excludeFiles=&repos=

VisualEditor, MinervaNeue, DiscussionTools and WikimediaApiPortal...

Thanks. Added a sign off step to make sure this gets done before resolving.

gerritbot added a comment.Tue, Oct 29, 5:17 PM

Change #1084142 merged by jenkins-bot:

[mediawiki/core@master] tests: restore test for deprecated skin methods

https://gerrit.wikimedia.org/r/1084142

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.2; 2024-11-05); removed MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Tue, Oct 29, 6:00 PM
gerritbot added a comment.Tue, Oct 29, 10:31 PM

Change #1084259 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Use getTemplateData for skin menus

https://gerrit.wikimedia.org/r/1084259

MSantos subscribed.Wed, Oct 30, 4:11 PM

@Jdlrobson are you planning to backport these into MW-1.43-release? Or will it be deferred to MW-1.44-release?

gerritbot added a comment.Wed, Oct 30, 5:40 PM

Change #1084854 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@REL1_39] SkinFactory::getSkinNames is deprecated, use getInstalledSkins

https://gerrit.wikimedia.org/r/1084854

Jdlrobson changed the task status from Open to Stalled.Wed, Oct 30, 5:41 PM
In T377521#10277818, @MSantos wrote:

@Jdlrobson are you planning to backport these into MW-1.43-release? Or will it be deferred to MW-1.44-release?

Yes. I just need to work out which need to be backported and backporting is blocked on T378531.

gerritbot added a comment.Wed, Oct 30, 7:36 PM

Change #1083950 merged by jenkins-bot:

[mediawiki/extensions/Theme@master] Future-proofing

https://gerrit.wikimedia.org/r/1083950

gerritbot added a comment.Wed, Oct 30, 9:16 PM

Change #1084896 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@REL1_43] SkinFactory::getSkinNames is deprecated, use getInstalledSkins

https://gerrit.wikimedia.org/r/1084896

gerritbot added a comment.Wed, Oct 30, 9:16 PM

Change #1084897 had a related patch set uploaded (by Jdlrobson; author: Reedy):

[mediawiki/extensions/Gadgets@REL1_43] SpecialGadgets: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1084897

gerritbot added a comment.Wed, Oct 30, 9:16 PM

Change #1084898 had a related patch set uploaded (by Jdlrobson; author: Reedy):

[mediawiki/extensions/WikimediaMaintenance@REL1_43] ChangeSkinPref: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1084898

gerritbot added a comment.Wed, Oct 30, 9:17 PM

Change #1084854 abandoned by Jdlrobson:

[mediawiki/extensions/VisualEditor@REL1_39] SkinFactory::getSkinNames is deprecated, use getInstalledSkins

Reason:

Wrong branch (should have been REL1_43 sorry!)

https://gerrit.wikimedia.org/r/1084854

gerritbot added a comment.Wed, Oct 30, 9:21 PM

Change #1084899 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] RELEASE NOTES: Update release note relating to hard deprecation

https://gerrit.wikimedia.org/r/1084899

gerritbot added a comment.Wed, Oct 30, 9:22 PM

Change #1084902 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@REL1_43] Hard deprecate soft deprecated skin methods

https://gerrit.wikimedia.org/r/1084902

gerritbot added a comment.Wed, Oct 30, 9:29 PM

Change #1084896 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@REL1_43] SkinFactory::getSkinNames is deprecated, use getInstalledSkins

https://gerrit.wikimedia.org/r/1084896

gerritbot added a comment.Wed, Oct 30, 9:29 PM

Change #1084897 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@REL1_43] SpecialGadgets: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1084897

gerritbot added a comment.Wed, Oct 30, 9:54 PM

Change #1084909 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@REL1_43] RELEASE NOTES: Update release note relating to hard deprecation

https://gerrit.wikimedia.org/r/1084909

gerritbot added a comment.Wed, Oct 30, 10:21 PM

Change #1084911 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/skins/WikimediaApiPortal@master] doc: Remove references to removed Skin method

https://gerrit.wikimedia.org/r/1084911

gerritbot added a comment.Wed, Oct 30, 10:22 PM

Change #1084909 merged by jenkins-bot:

[mediawiki/core@REL1_43] RELEASE NOTES: Update release note relating to hard deprecation

https://gerrit.wikimedia.org/r/1084909

Jdlrobson changed the task status from Stalled to Open.Wed, Oct 30, 10:31 PM

Okay this should be done and backported now! need to update documentation references, but this is not urgent from my perspective and not a simple find and replace job - most of these comments look like they need significant revising to be useful.

Jdlrobson closed this task as Resolved.Wed, Oct 30, 10:34 PM
Jdlrobson mentioned this in T378670: Documentation: fix references to removed buildContentNavigationUrls function.
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Wed, Oct 30, 10:42 PM

Change #1084899 merged by jenkins-bot:

[mediawiki/core@master] RELEASE NOTES: Update release note relating to hard deprecation

https://gerrit.wikimedia.org/r/1084899

ReleaseTaggerBot edited projects, added MW-1.43-notes; removed MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Wed, Oct 30, 11:00 PM
gerritbot added a comment.Fri, Nov 1, 4:15 PM

Change #1084911 merged by jenkins-bot:

[mediawiki/skins/WikimediaApiPortal@master] doc: Remove references to removed Skin method

https://gerrit.wikimedia.org/r/1084911

Ammarpad mentioned this in rMSWA8b63dac5c2b1: doc: Remove references to removed Skin method.Fri, Nov 1, 4:17 PM
gerritbot added a comment.Wed, Nov 13, 12:27 AM

Change #1084902 merged by Jdlrobson:

[mediawiki/core@REL1_43] Hard deprecate soft deprecated skin methods

https://gerrit.wikimedia.org/r/1084902

gerritbot added a comment.Wed, Nov 13, 12:36 AM

Change #1084898 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@REL1_43] ChangeSkinPref: Replace deprecated SkinFactory::getSkinNames() call

https://gerrit.wikimedia.org/r/1084898

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits