Page MenuHomePhabricator

Epic: Enable Chart extension on testwiki and testcommons
Closed, ResolvedPublic

Description

Background

We want to enable the charts extension in production setting. This is not blocked on security review (due to risk assessment).

acceptance criteria

  • The extension is enabled on test.wikipedia.org (it should appear on Special:Version)
  • The extension is enabled on https://test-commons.wikimedia.org/ (it should appear on Special:Version)
  • All changes have been backported into the current deployment branch (if needed)
  • T379199 - The new databases are setup for global usage tracking [ Wikitech Documentation ] (deployed by @CDanis )
  • T378216 - TestCommons is fully setup for testing
  • T374746 - Cache invalidation for Data: NS pages is working

Event Timeline

CCiufo-WMF renamed this task from Deploy Chart extension to testwiki and testcommons to Enable Chart extension to testwiki and testcommons.Nov 4 2024, 7:22 PM
CCiufo-WMF edited projects, added Charts (Sprint 10); removed Charts.
Jdlrobson renamed this task from Enable Chart extension to testwiki and testcommons to Deploy Chart extension to testwiki and testcommons.Nov 4 2024, 7:24 PM
Jdlrobson updated the task description. (Show Details)
Seddon updated the task description. (Show Details)
Seddon added subscribers: Ladsgroup, aude.
CCiufo-WMF renamed this task from Deploy Chart extension to testwiki and testcommons to Enable Chart extension on testwiki and testcommons.Nov 4 2024, 7:40 PM
CCiufo-WMF reassigned this task from Jdlrobson to aude.

Test Commons is closed. We sorta can deploy it there but it doesn't make much sense as noone can edit it.

Test Commons is closed. We sorta can deploy it there but it doesn't make much sense as noone can edit it.

I thought that too, but it turns out staff who previously logged in can edit there ( e.g. me - https://test-commons.wikimedia.org/wiki/Special:Contributions/Jon_(WMF) ) which is enough for our testing.

In paper stewards can do that and probably you have some rights that allow it. It's fine if you really want it but also that means you will need to set up a dedicated central table for testcommons? If the table is created for commons (in x1) and is not read, that'd be way less complicated and safer as result.

So if I understand correctly, we need two databases on x1 which will each hold globaljsonlinks, globaljsonlinks_target, and globaljsonlinks_wiki tables: one for testcommons for the testcommons deployment, and one for the actual commons-based deployment.

Or alternately, we can put those tables into testcommons directly.

In either case, test + testcommons will need JsonConfig's config updated to enable $wgTrackGlobalJsonLinks and to point the virtual-globaljsonlinks virtual domain at the right target, and the final deployment config will point all wikis at the final location.

Does that sound about right? Should I try to prepare a config patch for this?

I think the tables could go on testcommonswiki (to be paired with testwiki), as well on x1 for actual deploy to commons.

This provides a way to test the global json usage on the test wikis (in group 0 deployments) that is more realistic.

Agreed, that makes sense. Prelim config patch attached on T379199 -- @Ladsgroup let me know if this looks right to you!

@Jdlrobson Do we want $wgChartProgressiveEnhancement to be enabled for testcommonswiki and testwiki?

Change #1087987 had a related patch set uploaded (by Aude; author: Aude):

[operations/mediawiki-config@master] Enable Chart extension on testwiki and testcommonswiki

https://gerrit.wikimedia.org/r/1087987

@Jdlrobson Do we want $wgChartProgressiveEnhancement to be enabled for testcommonswiki and testwiki?

Yes please. Just not pilot wikis!

Seddon updated the task description. (Show Details)

Change #1087987 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Chart extension on testwiki and testcommonswiki

https://gerrit.wikimedia.org/r/1087987

Mentioned in SAL (#wikimedia-operations) [2024-11-07T20:22:17Z] <cdanis@deploy2002> Started scap sync-world: Backport for [[gerrit:1087987|Enable Chart extension on testwiki and testcommonswiki (T378127)]]

Mentioned in SAL (#wikimedia-operations) [2024-11-07T20:25:00Z] <cdanis@deploy2002> cdanis, aude: Backport for [[gerrit:1087987|Enable Chart extension on testwiki and testcommonswiki (T378127)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-11-07T20:35:20Z] <cdanis@deploy2002> Finished scap sync-world: Backport for [[gerrit:1087987|Enable Chart extension on testwiki and testcommonswiki (T378127)]] (duration: 13m 02s)

Change #1088366 had a related patch set uploaded (by Aude; author: Aude):

[operations/mediawiki-config@master] Reopen testcommonswiki for testing Chart extension

https://gerrit.wikimedia.org/r/1088366

Change #1088375 had a related patch set uploaded (by Aude; author: Aude):

[operations/mediawiki-config@master] Enable Tabular data for test commons

https://gerrit.wikimedia.org/r/1088375

Change #1088385 had a related patch set uploaded (by Bvibber; author: Bvibber):

[operations/mediawiki-config@master] Update interwiki map

https://gerrit.wikimedia.org/r/1088385

Change #1088385 merged by jenkins-bot:

[operations/mediawiki-config@master] Update interwiki map

https://gerrit.wikimedia.org/r/1088385

Seddon updated the task description. (Show Details)

Change #1088375 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Tabular data for test commons

https://gerrit.wikimedia.org/r/1088375

Mentioned in SAL (#wikimedia-operations) [2024-11-08T20:04:22Z] <aude@deploy2002> Started scap sync-world: Backport for [[gerrit:1088375|Enable Tabular data for test commons (T378127)]]

Mentioned in SAL (#wikimedia-operations) [2024-11-08T20:06:52Z] <aude@deploy2002> aude: Backport for [[gerrit:1088375|Enable Tabular data for test commons (T378127)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-11-08T20:15:17Z] <aude@deploy2002> Finished scap sync-world: Backport for [[gerrit:1088375|Enable Tabular data for test commons (T378127)]] (duration: 10m 55s)

CCiufo-WMF renamed this task from Enable Chart extension on testwiki and testcommons to Epic: Enable Chart extension on testwiki and testcommons.Nov 12 2024, 10:49 PM
CCiufo-WMF moved this task from Sprint 10 to Epics on the Charts board.
CCiufo-WMF edited projects, added Charts, Epic; removed Charts (Sprint 10).
CCiufo-WMF updated the task description. (Show Details)