Page MenuHomePhabricator
Create Task
Maniphest T378664

[wmf.1] refreshLinkRecommendations.php - Unable to deliver all events: 400: Bad Request
Closed, ResolvedPublic
Actions

Description

Error
normalized_message
Unable to deliver all events: 400: Bad Request
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.1/extensions/EventBus/includes/EventBus.php(433)
#0/srv/mediawiki/php-1.44.0-wmf.1/extensions/CirrusSearch/includes/EventBusWeightedTagsUpdater.php(68)MediaWiki\Extension\EventBus\EventBus->send(array)
#1/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/includes/NewcomerTasks/AddLink/LinkRecommendationUpdater.php(145)CirrusSearch\EventBusWeightedTagsUpdater->updateWeightedTags(MediaWiki\Page\PageIdentityValue, string)
#2/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(292)GrowthExperiments\NewcomerTasks\AddLink\LinkRecommendationUpdater->processCandidate(MediaWiki\Title\Title, bool)
#3/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(161)GrowthExperiments\Maintenance\RefreshLinkRecommendations->processCandidate(MediaWiki\Title\Title, bool)
#4/srv/mediawiki/php-1.44.0-wmf.1/maintenance/includes/MaintenanceRunner.php(703)GrowthExperiments\Maintenance\RefreshLinkRecommendations->execute()
#5/srv/mediawiki/php-1.44.0-wmf.1/maintenance/run.php(51)MediaWiki\Maintenance\MaintenanceRunner->run()
#6/srv/mediawiki/multiversion/MWScript.php(158)require_once(string)
#7{main}
Impact
  • a user sees only one Add link suggested article on Homepage - see the gif below. the same behavior is on frwiki wmf.28

incorrect_counter.gif (612×1 px, 170 KB)

Notes

Details

SubjectRepoBranchLines +/-
Fix WeightedTagsUpdatermediawiki/extensions/CirrusSearchwmf/1.44.0-wmf.2+332 -48
Fix WeightedTagsUpdatermediawiki/extensions/CirrusSearchmaster+332 -48
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Wed, Oct 30, 9:22 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptWed, Oct 30, 9:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova renamed this task from [wmf.1] Unable to deliver all events: 400: Bad Request to [wmf.1] refreshLinkRecommendations.php - Unable to deliver all events: 400: Bad Request .Wed, Oct 30, 9:24 PM
Michael mentioned this in T378983: Add Link recommendation are not being processed by CirrusSearch (November 2024).Mon, Nov 4, 4:47 PM

This is being worked on in T378983: Add Link recommendation are not being processed by CirrusSearch (November 2024).

pfischer changed the task status from Open to In Progress.Tue, Nov 5, 10:54 AM
pfischer claimed this task.
pfischer triaged this task as Unbreak Now! priority.
pfischer added projects: CirrusSearch, Discovery-Search (Current work).
pfischer moved this task from Incoming to In Progress on the Discovery-Search (Current work) board.
gerritbot added a comment.Tue, Nov 5, 11:34 AM

Change #1087432 had a related patch set uploaded (by Peter Fischer; author: Peter Fischer):

[mediawiki/extensions/CirrusSearch@master] Fix WeightedTagsUpdater

https://gerrit.wikimedia.org/r/1087432

gerritbot added a project: Patch-For-Review.Tue, Nov 5, 11:34 AM
pfischer moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Tue, Nov 5, 12:13 PM
gerritbot added a comment.Thu, Nov 7, 10:58 AM

Change #1087432 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Fix WeightedTagsUpdater

https://gerrit.wikimedia.org/r/1087432

Maintenance_bot removed a project: Patch-For-Review.Thu, Nov 7, 11:30 AM
gerritbot added a comment.Sun, Nov 10, 8:47 PM

Change #1089230 had a related patch set uploaded (by Urbanecm; author: Peter Fischer):

[mediawiki/extensions/CirrusSearch@wmf/1.44.0-wmf.2] Fix WeightedTagsUpdater

https://gerrit.wikimedia.org/r/1089230

gerritbot added a project: Patch-For-Review.Sun, Nov 10, 8:47 PM
gerritbot added a comment.Tue, Nov 12, 8:19 AM

Change #1089230 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@wmf/1.44.0-wmf.2] Fix WeightedTagsUpdater

https://gerrit.wikimedia.org/r/1089230

Stashbot added a comment.Tue, Nov 12, 8:21 AM

Mentioned in SAL (#wikimedia-operations) [2024-11-12T08:21:00Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1089230|Fix WeightedTagsUpdater (T378664 T378983)]]

Stashbot added a comment.Tue, Nov 12, 8:28 AM

Mentioned in SAL (#wikimedia-operations) [2024-11-12T08:28:00Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1089230|Fix WeightedTagsUpdater (T378664 T378983)]] (duration: 06m 59s)

Maintenance_bot removed a project: Patch-For-Review.Tue, Nov 12, 8:30 AM
Urbanecm_WMF moved this task from Inbox to Tracking on the Growth-Team board.Tue, Nov 12, 8:49 AM
Urbanecm_WMF closed this task as Resolved.Tue, Nov 12, 9:17 AM

The errors should be resolved by now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits