I was surprised to see that Jenkins run https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/588/console passed. (I understand there were no tests run yet, though).
This was introduced by this change:
https://gerrit.wikimedia.org/r/#patch,unified,4672,2,includes/db/DatabasePostgres.php
Version: unspecified
Severity: normal
URL: https://gerrit.wikimedia.org/r/#patch,unified,4672,2,includes/db/DatabasePostgres.php
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T37584 Implementing continuous integration workflow (tracking) | |||
| Resolved | Krinkle | T37585 Jenkins: Set up linting for php, js, py etc. | |||
| Declined | hashar | T37871 Jenkins should not accept PHP files with spurious output (without <?php) |
this would be a good place to put some "lint" like checks. Hrm... and this really isn't Git or Gerrit.
As a summary, the change replaced a '<?php' by '19php'. The end result is that all the file content is interpreted as a full text file making all the file content looking perfectly legit to PHP linter.
I am going to wont fix this issue: