Page MenuHomePhabricator

Disable AbuseFilter protected variables features on wikis where Temporary accounts are not about to be released
Closed, DeclinedPublic

Description

As part of Temporary accounts project, AbuseFilter now has a concept of protected variables. That concept is necessary while preparing a project for Temporary accounts (reviewing filters that make use of IPs and using the protected variables), as well as when Temporary accounts are enabled. On all other projects, it causes confusion.

For now, let's disable access to AbuseFilter protected variables for all local groups on all projects, except projects where:

  • Temporary accounts are enabled
  • Temporary accounts are about to be enabled

This avoids scenarios such as https://en.wikipedia.org/wiki/Wikipedia:Edit_filter_noticeboard#Protected_filters.

Event Timeline

We can do this via permissions, making sure that abusefilter-access-protected-vars is only assigned on wikis where temporary accounts in enabled/known.

Change #1090515 had a related patch set uploaded (by Tchanders; author: Tchanders):

[operations/mediawiki-config@master] Disallow AbuseFilter protected variables use on non-temp-user wikis

https://gerrit.wikimedia.org/r/1090515

Change #1090515 merged by jenkins-bot:

[operations/mediawiki-config@master] Disallow AbuseFilter protected variables use on non-temp-user wikis

https://gerrit.wikimedia.org/r/1090515

Mentioned in SAL (#wikimedia-operations) [2024-11-13T14:03:25Z] <tchanders@deploy2002> Started scap sync-world: Backport for [[gerrit:1090515|Disallow AbuseFilter protected variables use on non-temp-user wikis (T379503)]]

Mentioned in SAL (#wikimedia-operations) [2024-11-13T14:05:55Z] <tchanders@deploy2002> tchanders: Backport for [[gerrit:1090515|Disallow AbuseFilter protected variables use on non-temp-user wikis (T379503)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-11-13T14:14:53Z] <tchanders@deploy2002> Finished scap sync-world: Backport for [[gerrit:1090515|Disallow AbuseFilter protected variables use on non-temp-user wikis (T379503)]] (duration: 11m 28s)

I don't know what's happening here, but it's not good.
We were encouraged to switch to the new ip_in_range(user_unnamed_ip, ...), and some of us did.
That protected our filters for good.
But now we cannot see nor edit the protected filters. They disappeared from our lists. I don't even know if they're working.
On hrwiki, they're the only protection from our IP-jumping LTA.

@Tchanders?

We disallowed sysops on wikis without temporary accounts from using protected variables, in order to avoid exposing the "protect this filter" checkbox when it shouldn't be needed.

However it seems it is needed on wikis that have already updated their filters in advance of temporary accounts deployment.

Let's re-allow access to protected variables as soon as possible, and rely on T377765: Do not allow protecting abuse filters if PII variables are not used to avoid filters being needlessly protected.

Thanks for the report @Ponor

Change #1090965 had a related patch set uploaded (by Tchanders; author: Tchanders):

[operations/mediawiki-config@master] Revert "Disallow AbuseFilter protected variables use on non-temp-user wikis"

https://gerrit.wikimedia.org/r/1090965

Change #1090965 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Disallow AbuseFilter protected variables use on non-temp-user wikis"

https://gerrit.wikimedia.org/r/1090965

Mentioned in SAL (#wikimedia-operations) [2024-11-13T21:51:07Z] <tchanders@deploy2002> Started scap sync-world: Backport for [[gerrit:1090965|Revert "Disallow AbuseFilter protected variables use on non-temp-user wikis" (T379503)]]

Mentioned in SAL (#wikimedia-operations) [2024-11-13T21:55:10Z] <tchanders@deploy2002> tchanders: Backport for [[gerrit:1090965|Revert "Disallow AbuseFilter protected variables use on non-temp-user wikis" (T379503)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-11-13T22:00:11Z] <tchanders@deploy2002> Finished scap sync-world: Backport for [[gerrit:1090965|Revert "Disallow AbuseFilter protected variables use on non-temp-user wikis" (T379503)]] (duration: 09m 03s)

@Tchanders Yes, my filters are back and I was able to edit one. Thanks!

Declining, as explained in T379503#10319347.