Page MenuHomePhabricator
Create Task
Maniphest T379534

Page creation log inserted even if $wgPageCreationLog is false
Closed, ResolvedPublicBUG REPORT
Actions

Description

Commons and Wikidata has $wgPageCreationLog disabled (see discussion at T12331), but page creation logs are still inserted. They displayed incorrectly because of T379527: Page creation log become unknown once $wgPageCreationLog is disabled

Steps to replicate the issue (include links if applicable):

What happens?:

  • x performed unknown action "create/create" on Category:Stowe Pool
  • y performed unknown action "create/create" on File:Марына Васько. 2022 (02).jpeg

What should have happened instead?:
It should not be an unknown action

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
The log types also show no "Page creation log" listed in the menu.

Screenshot 2024-11-11 at 10.54.43.png (1×1 px, 183 KB)

See also: T379527: Page creation log become unknown once $wgPageCreationLog is disabled, T288346: Enable non-file page creation logs on Wikimedia Commons

Details

SubjectRepoBranchLines +/-
storage: restore passing of $wgPageCreationLog to PageUpdatermediawiki/coremaster+4 -15
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Mon, Nov 11, 9:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Nov 11, 9:57 AM
Bugreporter subscribed.Mon, Nov 11, 10:43 AM

And also Wikidata: https://www.wikidata.org/wiki/Special:Log

Bugreporter renamed this task from Commons missing its page creation log to Page creation log inserted even if $wgPageCreationLog is false.Mon, Nov 11, 10:44 AM
Bugreporter edited projects, added MediaWiki-Logevents; removed Commons.
Bugreporter merged a task: T379528: DiscussionTools should not insert page creation log entries if $wgPageCreationLog is disabled.
Bugreporter added a project: Regression.Mon, Nov 11, 10:48 AM
Bugreporter updated the task description. (Show Details)
Ammarpad claimed this task.Mon, Nov 11, 10:56 PM
Ammarpad mentioned this in T379527: Page creation log become unknown once $wgPageCreationLog is disabled.
gerritbot added a comment.Mon, Nov 11, 11:21 PM

Change #1089877 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] storage: restore passing of $wgPageCreationLog to PageUpdater

https://gerrit.wikimedia.org/r/1089877

gerritbot added a project: Patch-For-Review.Mon, Nov 11, 11:21 PM
Ammarpad added a comment.Mon, Nov 11, 11:22 PM

There was a deprecation and undeprecation of PageUpdater::setUsePageCreationLog() in T377229. The undeprecation was a partial revert and did not restore passing the $wgPageCreationLog to the PageUpdater, among other things. The default value in PageUpdater is true, so the log gets created always.

For the 'unknown action', it shows that because there's no formatter since the variable is false; but the entry is nonetheless erroneously created.

Ammarpad triaged this task as High priority.Mon, Nov 11, 11:39 PM
Ammarpad added a subscriber: daniel.
gerritbot added a comment.Wed, Nov 13, 5:43 PM

Change #1089877 merged by jenkins-bot:

[mediawiki/core@master] storage: restore passing of $wgPageCreationLog to PageUpdater

https://gerrit.wikimedia.org/r/1089877

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.4; 2024-11-19).Wed, Nov 13, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Wed, Nov 13, 6:31 PM
TheDJ added a comment.Wed, Nov 13, 7:47 PM

Should this be backported ?

Ammarpad added a subscriber: Reedy.Thu, Nov 14, 8:10 AM

Not sure who can/should do that, maybe @Reedy. But if not, this will be out with wmf.4 next week.

TheDJ added a comment.Thu, Nov 14, 9:16 AM

I meant to 1.43. But it seems that https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1069665 was after the 1.43 cut

Ammarpad closed this task as Resolved.Thu, Nov 14, 11:10 AM

Yes it was not in 1.43

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits