Page MenuHomePhabricator

Review Extension:SignupAPI for deployment
Closed, DeclinedPublic

Description

Author: sumanah

Description:
Akshay has been working on fixing bugs and making user experience improvements: https://www.mediawiki.org/wiki/User:Akshay.agarwal and I know that the editor engagement experiments and community folks at Wikimedia Foundation are interested in getting this extension reviewed and deployed.

This extension aims to resolve bug 34447 .

Also this will help with https://meta.wikimedia.org/wiki/Research:Account_creation_UX


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=15700

Details

Reference
bz36225

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:22 AM
bzimport set Reference to bz36225.

sumanah wrote:

I have heard that Ryan Kaldari may be interested in working on this codebase, and in reviewing it prior to deployment. Assigning to him. Ryan, along with your GSoC mentorship time, do you have time to work on this as part of your 20% time, or possibly as part of your regular work? Thanks.

sumanah wrote:

Not really a shell bug until a senior MediaWiki developer approves it for deployment, so, not putting the "shell" keyword in yet.

I added the extension to the Git migration request list:
https://www.mediawiki.org/wiki/Git/Conversion/Extensions_queue

Now we wait on Chad.

Akshay, do you have a Gerrit account yet? If not, you'll need to get one before the extension can be migrated.

If you don't, see https://www.mediawiki.org/wiki/Git/Workflow#Get_the_right_permissions

(In reply to comment #3)

I added the extension to the Git migration request list:
https://www.mediawiki.org/wiki/Git/Conversion/Extensions_queue

Now we wait on Chad.

This has been exported to Gerrit and can be cloned from the mediawiki/extensions/SignupAPI.git project.

I couldn't find Akshay in Gerrit yet, but you're in the extension-SignupAPI group Ryan, so you can add the user when Akshay is setup.

Thanks Chad! Don't you ever sleep?

(In reply to comment #6)

Thanks Chad! Don't you ever sleep?

No, we keep him hooked up on a ballmer peak of coffee.

sumanah wrote:

Ryan Kaldari and Chris Steipp are collaborating on reviewing this extension towards getting it deployed on Wikimedia sites. You can see it at https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/SignupAPI,n,z . The Editor Engagement Experiments team is eager to get this reviewed and deployed. Thanks, Ryan and Chris.

swalling wrote:

Looks like Kaldari has left some review comments.

I assume our next steps is get Ori on implementation of requested changes. Thanks Kaldari for the help!

sumanah wrote:

Adding Ori to this bug.

sumanah wrote:

Looking at https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/SignupAPI,n,z - who is it who's working on this right now? Ryan, should this bug be assigned to you, Ori, or someone else?

swalling wrote:

This is still in the work queue for E3, but since we're in the middle of testing/deploying a different experiment it's on the backburner.

Hi. In my initial development for the Account creation user experience experiment https://www.mediawiki.org/wiki/Account_creation_user_experience I've looked at the code. I made some notes in https://www.mediawiki.org/wiki/Account_creation_user_experience/SignupAPI , maybe you'll find them of interest.

My bias for the experiment is to leave the server-side PHP code unchanged, rather than adding a new Special:UserSignup; but I may adopt some of your validate API.

akshay.leadindia wrote:

I am working on implementing the changes as suggested in the code review and bugs filed by E3 team during testing. I shall collaborate with Ori on this & possibly he might mentor me on pushing this towards deployment.

Akshay: Would it be useful to have a dedicated "SignupAPI" component here in Bugzilla under the "MediaWiki extensions" product, and set you as the default assignee for bug reports filed under it?
Might make it easier to report and find issues of SignupAPI...

akshay.leadindia wrote:

Andre: That would be excellent. I tried adding a new component to Bugzilla from the administration page but I do not have the sufficient rights, could you please do this for me. thanks.

sumanah wrote:

Steven and S, I just wanted to check on the status of the updated signup functionality. I see that https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/SignupAPI,n,z includes some -1 reviews from Arthur and S -- are you waiting for improvements by author Akshay? Is there another place I should be looking for signup API improvements?

Thanks.

Steven, S: Could you answer comment 18 please?

Akshay: Is anything blocking you?

WMF will not deploy SignupAPI, instead we will some day rewrite much of the "account creation user experience" code currently in the E3Experiments extension into core.

Also gerrit 18127 implemented a 'createaccount' API with similar functionality to 'signup'.

I acknowledge and appreciate Akshay's work, it was very helpful.