Page MenuHomePhabricator
Create Task
Maniphest T382592

Rollbacks are not counted in user edit counts
Open, HighPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Make a dummy edit in a sandbox.
  • Check and remember your current edit count in Preferences => Number of edits.
  • Rollback your dummy edit using the rollback feature.

What happens?:
After performing the rollback, your edit count remains the same as it was before.

What should have happened instead?:
The rollback should count as an edit, and the number of edits in "Preferences => Number of edits" should increase by one.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
1.44.0-wmf.8 (f08e6b3)

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
RollbackAction: do not mark rollbacks as internalmediawiki/coremaster+10 -1
Customize query in gerrit

Related Objects

Event Timeline

Guycn2 created this task.Fri, Dec 20, 11:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Dec 20, 11:53 AM
Safwansayeed subscribed.EditedFri, Dec 20, 2:46 PM

The Number of edits do increase by 1 when we undo it...also there is a tag Reverted assigned to the undone edit

matmarex added a project: MW-Interfaces-Team.Fri, Dec 20, 6:34 PM
matmarex added a subscriber: daniel.
matmarex subscribed.
Pppery edited projects, added MediaWiki-Patrolling; removed MediaWiki-General.Fri, Dec 20, 7:04 PM
Bugreporter merged a task: T382761: editcount do not increase in some cases.Wed, Dec 25, 1:41 PM
Bugreporter added subscribers: Ahmad_Kanik, MdsShakil, Nahian.
Ciencia_Al_Poder subscribed.Wed, Dec 25, 2:02 PM
Nemoralis subscribed.Wed, Dec 25, 3:16 PM
Pppery merged a task: T382798: Edit count not updating.Fri, Dec 27, 9:07 PM
Pppery added a subscriber: Airtransat236.
Aklapper renamed this task from [REGRESSION] Rollbacks are not counted in user edit counts to Rollbacks are not counted in user edit counts.Mon, Dec 30, 12:57 PM
ToBeFree subscribed.Fri, Jan 3, 11:22 PM

I just confirmed this on enwiki in case it needed confirmation. @Randomdude121 had asked about it and I'm pretty sure my rollbacks were counted in the years before. Past rollbacks are still part of my edit count, new ones are not counted.

ToBeFree awarded a token.Fri, Jan 3, 11:23 PM
daniel added a comment.Sun, Jan 5, 1:46 PM

Should have been fixed by T381299: Emit PageUpdatedEvents on all occasion the page content changes.. It's possible that the patch didn't make it into production over the holidays. I'll have a look tomorrow.

daniel claimed this task.Sun, Jan 5, 1:46 PM
daniel triaged this task as High priority.
daniel moved this task from Incoming (Needs Triage) to MWI-Sprint-1 (2025-01-07 to 2025-01-21) on the MW-Interfaces-Team board.
daniel edited projects, added MW-Interfaces-Team (MWI-Sprint-1 (2025-01-07 to 2025-01-21)); removed MW-Interfaces-Team.
gerritbot added a comment.Mon, Jan 6, 9:18 AM

Change #1108393 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] RollbackAction: do not mark rollbacks as internal

https://gerrit.wikimedia.org/r/1108393

gerritbot added a project: Patch-For-Review.Mon, Jan 6, 9:18 AM
daniel moved this task from Committed to Code Review on the MW-Interfaces-Team (MWI-Sprint-1 (2025-01-07 to 2025-01-21)) board.Mon, Jan 6, 9:23 AM

Turns out that the problem was different what what I originally suspected. The change that I thought might fix this issue actually caused it: r1099368 introduced a check into ChangeTrackingEventIngress that would prevent updates with EDIT_INTERNAL from being counted as user edits. Since rollbacks have this flag set, we are no longer counting them.

EDIT_INTERNAL is used for imports and for things like changing the page's content model. It's also used for dummy revisions and atomatic redirect creation, which should not count as edits. I think it shouldn't be set for rollbacks. The flag doesn't seem to have other effects, so I made a patch that removed it from rollbacks.

Safwansayeed added a comment.Mon, Jan 6, 9:27 AM

What is to be fixed now?

Aklapper added a comment.Mon, Jan 6, 9:44 AM

@Safwansayeed: See previous comments in this task.

daniel added a comment.EditedMon, Jan 6, 11:13 AM
In T382592#10431722, @Safwansayeed wrote:

What is to be fixed now?

The fix I made needs to be reviewed and merged, and will probably go live next week with the regular deployment train.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits