Page MenuHomePhabricator

move geoIP lookup back to the head
Closed, ResolvedPublic

Description

Now that we can use http://bits.wikimedia.org/geoiplookup, we should move the geoIP lookup back to the head of the page so that the Geo var is available to all scripts immediately.


Version: unspecified
Severity: normal

Details

Reference
bz37727

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:23 AM
bzimport set Reference to bz37727.
bzimport added a subscriber: Unknown Object (MLST).

pgehres wrote:

Awesome! This should reduce the "banner bump," yes?

Yes, although this is only the first step of eliminating the banner bump. Some other changes will be necessary as well.

Looks like this might be rather difficult as there is no longer any way to add scripts to the head other than through ResourceLoader (which only works for local scripts). Might have to get creative and hack this into core.