Page MenuHomePhabricator

Clicking on region rapidly, multiple times, causes severe lag
Closed, DeclinedPublic

Description

Click five times, quickly, on "America". It's slow as all get out. What's more, it halts the browser (tested in FF 14.0.1)

There are several options I can think of:

  1. Make it faster, so multiple clicks won't matter (much). This is hackish and unreliable.
  1. Use proper callbacks combined with caching and tracking of requests--if a request already exists for the resource you're trying to get, don't start another one.
  1. Remove the click event after the first click is fired, and replace it only after the user switches away from that region. This may work best, because it means no other handling, but it's complicated because you'll need to save the function definition, an anonymous function won't work here.

I report this bug knowing nothing about the structure of this extension, so don't think that these are the only options.


Version: master
Severity: normal

Details

Reference
bz39386

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 12:52 AM
bzimport set Reference to bz39386.
bzimport added a subscriber: Unknown Object (MLST).

Can you clarify the use case of the described scenario?

It's not really a use case, it's just something that might happen, and the software shouldn't die when it does.

Can you confirm whether it fixed now?

We are caching the region filter results now and there were multiple optimizations in the code.

The performance fixes did in ULS seems to fix this and not able to reproduce in latest version.