Page MenuHomePhabricator
Create Task
Maniphest T42304

Reupload/overwriting of old version of a file fails, multiple files are uploaded under same title, old revisions are lost
Open, Stalled, LowPublicBUG REPORT
Actions

Description

I have a report from a user that https://commons.wikimedia.org/wiki/File:Chiesetta_a_Fénis_1.JPG and https://commons.wikimedia.org/wiki/File:Castello_Jocteau_5.JPG were actually two images each (for unknown reasons), but uploading a reverted (non-current) version under a new title failed, presumably being considered a reupload/duplicate by unauthorised user.
When I tried with the UW I got an unknown error in the first step but normal upload worked: https://commons.wikimedia.org/wiki/File:Chiesetta a Fénis 2.JPG, https://commons.wikimedia.org/wiki/File:Castello_Jocteau_7.JPG .

Note that reverting the file to the first version resulted in the first file in file history being lost: related to T41615 comment 5? Another byproduct of bug T41221?

In summary:

  1. Upload two files A and B
  2. Expect they are uploaded as files A and B
  3. Find that A is uploaded as A, then B is uploaded with A's title (as a new version)
  4. Try to upload A under a non-A title (or B with its own title after reverting A's title to A file)
  5. Find that you can't upload the file, or history gets lost in the process, or both

Version: master
Severity: major
URL: https://commons.wikimedia.org/w/index.php?title=Commons:Bar_italiano&oldid=78411173#Ho_salvato_due_file_con_lo_stesso_nome

Details

Reference
bz40304

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:57 AM
• bzimport added a project: UploadWizard.
• bzimport set Reference to bz40304.
• bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Sep 17 2012, 5:46 PM
Nischayn22 added a comment.Mar 8 2013, 5:41 PM

I tried the following locally but couldn't reproduce the bug.

Upload Penguins1.jpg, now upload Penguins2.jpg as a new version (under the same file name). Then tried to upload Penguins1.jpg again using UW.. it gave no error except 'title exists' (expected) .. after changing the title upload worked.

Am I doing something wrong?

Nischayn22 added a comment.Mar 8 2013, 5:43 PM

Also didn't lose any file on reverting..

Nemo_bis added a comment.Mar 8 2013, 6:57 PM

I don't know, maybe when the two files were saved by UW under the same title another mistake was that the saved hash for the file was the one of the older version? But then why would the normal upload work, does UW have additional checks?

If this works under normal conditions, I guess we can lower priority: the original error (uploading two files in one) was probably only WMF's Swift weirdness.

Nischayn22 added a comment.Mar 10 2013, 5:06 PM

I don't think so, but I am not really sure. I think we should lower priority and come back to this only with pure reproducible ways.
Also marking as Unconfirmed as it worked for me.

Nemo_bis added a comment.Sep 30 2013, 6:41 AM

I'm sorry for the confusing bug report but the issue is quite confusing in itself. I'm adding all the three different issues in the bug summary and raising severity; bug 54776 suggests this may be causing a few hundreds lost files per month.

Nemo_bis added a comment.Oct 11 2013, 8:36 AM

Recent example: https://commons.wikimedia.org/wiki/File:Sternwarte_Bogenhausen-Teleskopkupel-01.JPG

https://commons.wikimedia.org/w/index.php?title=Commons:Upload_Wizard_feedback&oldid=106815121#Fehlermeldung

• Gilles added a project: Multimedia.Nov 24 2014, 3:34 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:40 PM
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:40 PM
MarkTraceur closed this task as Declined.Dec 3 2015, 6:04 PM
MarkTraceur claimed this task.

I can only barely follow the description of this bug, but I'm pretty sure it's what we call "expected behaviour", at least for now, and at least for UploadWizard. That said, I don't understand what happened here. So I guess we've learned not to do this again.

Nemo_bis reopened this task as Open.Dec 5 2015, 9:19 AM

No, it's definitely not expected.

Nemo_bis updated the task description. (Show Details)Dec 5 2015, 9:22 AM
Nemo_bis set Security to None.
MarkTraceur unsubscribed.Jan 27 2017, 10:16 PM
MarkTraceur removed MarkTraceur as the assignee of this task.Mar 18 2020, 4:45 PM
MarkTraceur subscribed.
Aklapper changed the task status from Open to Stalled.Jul 16 2020, 8:51 AM
Aklapper lowered the priority of this task from Medium to Low.
Aklapper updated the task description. (Show Details)
Aklapper removed a subscriber: • wikibugs-l-list.

No clear steps to reproduce and five years ago, hence lowering and stalling.

Aklapper changed the subtype of this task from "Task" to "Bug Report".Feb 15 2022, 9:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits