Page MenuHomePhabricator

InfoAction should have canonical HTML IDs (not localization-dependent)
Closed, ResolvedPublic

Description

It is possible to get ids for the header and table, which are not changed across languages?

And please remove the # from the current id of the header. It is more confusing, than helping (Linking works, but javascript selection is complicated)

Thanks.


See Also:
T46989: InfoAction header ids malformed (starts with #)

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:11 AM
bzimport set Reference to bz42629.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

And please remove the # from the current id of the header. It is more
confusing, than helping (Linking works, but javascript selection is
complicated)

db is referring to this:


<h2><span class="mw-headline" id="#Basic_information">Basic information</span></h2>

The "#" in the CSS id attribute is wrong.

I'm not sure if the ID should be canonical (similar to file description pages) or if it should use the value of the h2. I guess having both would be best, if possible?

content hidden as private in Bugzilla

(In reply to comment #0)

It is possible to get ids for the header and table, which are not changed
across languages?

I agree, they shouldn't be dependent on localisation (both English and non-English). If "Basic information" is ever changed to "General data" or whatever, the anchors should stay as-is, just like we have #mw-portal, #toc, footer, #file etc.

And please remove the # from the current id of the header. It is more
confusing, than helping (Linking works, but javascript selection is
complicated)

The leading # is fixed (bug 44989).

Change 361942 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Add canonical id to header on action=info

https://gerrit.wikimedia.org/r/361942

Change 361942 merged by jenkins-bot:
[mediawiki/core@master] Add canonical id to header on action=info

https://gerrit.wikimedia.org/r/361942

Umherirrender claimed this task.
Umherirrender removed a subscriber: wikibugs-l-list.