Page MenuHomePhabricator

VisualEditor: Race condition between "Beginning of Line" and "New Line" operations
Closed, ResolvedPublic

Description

Here is normal behavior:

  1. In VisualEditor, type a line of text.
  2. Position your cursor at the beginning of that line.
  3. Press the Home key on your keyboard, to move the cursor to the beginning of the line.
  4. Wait a moment.
  5. Press Enter, and the current text is pushed downward one line. This is correct and expected.

Here is the buggy behavior:

  1. In VisualEditor, type a line of text.
  2. Position your cursor at the beginning of that line.
  3. VERY QUICKLY, press the Home key followed by the Enter key.
  4. The cursor moves down one line, so it is positioned below the line of text. The text did not move. This is incorrect behavior. The line of text should have been pushed downward.

Version: unspecified
Severity: normal

Details

Reference
bz43082

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:12 AM
bzimport set Reference to bz43082.

Crap... I made a mistake in my report.

In line (2) of both examples, change "beginning of the line" to "end of the line." The cursor needs to be at the END of the line.

Sounds like a polling issue. "Very quickly" probably means "before the polling loop gets a chance to run"; it runs every 200ms.

Inez added a comment.Jun 12 2013, 1:35 AM

This issue is not browser specific.

Inez added a comment.Jun 12 2013, 1:58 AM

I've just created a test that covers this problem: https://github.com/inez/VE-tests/commit/4c1a444b207b37f90dc5d5ce969b5af00ee893ef (solution still not pushed).

Related URL: https://gerrit.wikimedia.org/r/68300 (Gerrit Change I35c892581943057acbf9ddd638576e998cc82c1a)

https://gerrit.wikimedia.org/r/68300 (Gerrit Change I35c892581943057acbf9ddd638576e998cc82c1a) | change APPROVED and MERGED [by jenkins-bot]

Fixed and will go out with wmf8, from Thursday 20 June.