Page MenuHomePhabricator

mustBePosted unchecked for query modules
Closed, ResolvedPublic

Description

Although the autogenerated checkuser API documentation says that it accepts POST request only, it appears to accept GET requests as well. I clicked on one of the demo links, which should have failed since it's GET, and instead it actually ran the check and generated an entry in the CU log.


Version: unspecified
Severity: normal

Details

Reference
bz45017

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:28 AM
bzimport set Reference to bz45017.
bzimport added a subscriber: Unknown Object (MLST).

In api/ApiQueryCheckUser.php L204:

public function mustBePosted() {

		return true;

}

Yet I'm able to confirm this on my testwiki. This may be due to some recent changes in how the query/list module works in core, I'm looking into it a bit more.