Page MenuHomePhabricator
Create Task
Maniphest T48594

PostgreSQL syntax error: LOCK IN SHARE MODE when running Category
Closed, ResolvedPublic
Actions

Description

Author: darkcircle.0426

Description:
This patch is for getting rid of "LOCK IN SHARE MODE" related warning message.

Warning: pg_query() [function.pg-query]: Query failed: ERROR: syntax error at or near "LOCK" LINE 1: ... in ${MEDIAWIKI_HOME}/includes/db/DatabasePostgres.php on line 254 when category page is called.

as below commit message
https://gerrit.wikimedia.org/r/#/c/53554/
"LOCK IN SHARE MODE" is a MySQL extension not supported by another SQL Engine.

so I suggest very simple patch for eliminating this issue.

Version: 1.22.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47055

Attached:

postgres_related_patch.patch603 BDownload

Details

Reference
bz46594

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
InvalidNoneT2384 [REPLACED BY TAG] PostgreSQL/pgsql support (tracking)
ResolvedNoneT48594 PostgreSQL syntax error: LOCK IN SHARE MODE when running Category
· · ·

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:21 AM
• bzimport added projects: MW-1.22-release, MediaWiki-libs-Rdbms.
• bzimport set Reference to bz46594.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Mar 27 2013, 9:45 AM
Aklapper added a comment.Mar 27 2013, 10:06 AM

Hi Seong-ho! Thanks for your patch!

You are welcome to use Developer access

https://www.mediawiki.org/wiki/Developer_access

to submit this as a Git branch directly into Gerrit:

https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly.
Thanks again! We appreciate your contribution.

saper added a comment.Jul 17 2013, 3:12 PM

I think PostgreSQL has "FOR SHARE" SELECT option. By then, issues listed in bug 47055 apply.

valhallasw added a comment.Oct 15 2013, 8:44 PM

Hi Seong-ho Cho,

I tried to apply your patch, but unfortunately it did not apply cleanly. To submit a patch, you can now also use the on-line patch uploader at https://tools.wmflabs.org/gerrit-patch-uploader/ . Of course, you can also submit it directly using git.

Nemo_bis added a comment.Dec 30 2013, 9:29 AM

Update per https://www.mediawiki.org/w/index.php?title=MediaWiki_1.22/Known_issues&oldid=847749 which seems to be the master list.

Umherirrender added a comment.Feb 3 2014, 8:10 PM

Was already fixed with bug 39635, thats why the provided patch cannot apply to current master.

  • This bug has been marked as a duplicate of bug 39635 ***
Jdforrester-WMF added a project: PostgreSQL.Nov 2 2016, 8:16 PM
Jdforrester-WMF subscribed.

Migrating from the old tracking task to a tag for PostgreSQL-related tasks.

MarkAHershberger unsubscribed.Nov 3 2016, 3:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits