Page MenuHomePhabricator

VisualEditor: Delete contents of slugged paragraph results in double line break visible
Closed, ResolvedPublic

Description

  • Create a page starting with a list ('* list' is sufficient)
  • Enter some text into the slugged paragraph above the list, then delete it with backspaces
  • The paragraph now doubles in height, inspecting the DOM you see a <br> has appeared from nowhere: <p><br><span slug></span></p>

Also this paragraph gets sent to Parsoid resulting in an extra line break.

Removing the text by using undo doesn't result in this bug.


Version: unspecified
Severity: normal

Details

Reference
bz48385

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:30 AM
bzimport set Reference to bz48385.

We are not placing slugs around lists anymore so this bug can't be reproduced, however I know what was root cause of it (native handling of deletion) and I'm working on it now.

(In reply to comment #1)

We are not placing slugs around lists anymore so this bug can't be
reproduced, however I know what was root cause of it (native handling of
deletion) and I'm working on it now.

Is this bug still valid? I can't reproduce now, using a thumb image (rather than a list) to create the block item.

This is fixed with my refactor to handleDelete method.