Page MenuHomePhabricator

API siteinfo skins should use English skin names in * instead of the value in $wgValidSkinNames
Closed, ResolvedPublic

Description

Currently the siteinfo API's skins output uses the value of the relevant $wgValidSkinNames entry. However this is not really a skin name at all. It's a key used to determine the class name of the class that implements the skin.

  • Right now that means names like "CologneBlue" instead of "Cologne Blue".
  • If someone implements a skin system that uses a single class and simple templates for each skin that means you'll start seeing completely useless names like "FooSkinSystem" for "This is my skin", "That is his skin", and "She made this skin" names.
  • If one of my other changes gets merged you may also start seeing things like "{ThisIsMyClassName}".

We should start outputting the English i18n for the skin instead of this.


Version: 1.22.0
Severity: enhancement

Details

Reference
bz48953

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz48953.

Change 157275 had a related patch set uploaded by Bartosz Dziewoński:
ApiQuerySiteinfo: Use proper localised skin display names if available

https://gerrit.wikimedia.org/r/157275

Change 157275 merged by jenkins-bot:
ApiQuerySiteinfo: Use proper localised skin display names if available

https://gerrit.wikimedia.org/r/157275