Page MenuHomePhabricator

Wikibase Client cause ULS cog hidden for anonymous users
Closed, ResolvedPublic

Description

In the beta instance, visiting a random article like
http://en.wikipedia.beta.wmflabs.org/wiki/Marching_arts as anonymous user does not show ULS cog in the interlanguages position($wgULSPosition = 'interlanguage')

This happens only for articles without inter language links.

The #p-lang element is hidden by Wikibase extensions wikibase.client.nolanglinks modules css:

#p-lang {
display: none;
}

This was injected by Wikibase Clients onBeforePageDisplay hook and happens when no language links to be shown.

Cannot say this as a bug from Wikibase Client, it is done for a purpose, but we need to find a way to make both extensions work together.


Version: unspecified
Severity: major

Details

Reference
bz49005

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:44 AM
bzimport set Reference to bz49005.
santhosh created this task.May 31 2013, 4:47 AM

Related URL: https://gerrit.wikimedia.org/r/66226 (Gerrit Change I4cc238f87fdce0c5813b82516599ba3c0d3bf44c)

(In reply to comment #1)

Related URL: https://gerrit.wikimedia.org/r/66226 (Gerrit Change
I4cc238f87fdce0c5813b82516599ba3c0d3bf44c)

This is a simple patch assuming making the languages section visible from ULS side wont have any side effects for Wikibase Client

(In reply to comment #2)

This is a simple patch assuming making the languages section visible from ULS
side wont have any side effects for Wikibase Client

To clarify, will this also make the "Add links" button visible to anons (who do have item-create on wikidata, but are probably less interested)?

To clarify, will this also make the "Add links" button visible to anons (who
do
have item-create on wikidata, but are probably less interested)?

No.

(In reply to comment #4)

To clarify, will this also make the "Add links" button visible to anons (who
do
have item-create on wikidata, but are probably less interested)?

No.

Confirmed on URL.
Of course there's the bogus (un)collapsing arrow now, but that's a separate ULS bug, already filed IIRC.

Verified in Wikidata demo sprint 22-6

Just for the record, this was removed in https://gerrit.wikimedia.org/r/#/c/195077/1, but that didn't seem to cause any regressions.