Gerrit side-by-side diff view does not mark a removed "space" in a string (example given) (intraline different doesn't work with spaces)
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Wikinaut
	May 31 2013, 6:50 AM

Description

see https://gerrit.wikimedia.org/r/#/c/66229/1/AJAXPoll_body.php line 418

in line 418 I changed

<div style='width: "

to ==>

<div style='width:"

The removed space is *not* marked in the right diff window.

Version: unspecified
Severity: normal

Details

Reference: bz49006

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T51006 Gerrit side-by-side diff view does not mark a removed "space" in a string (example given) (intraline different doesn't work with spaces)
		Resolved		• demon	T146350 Update gerrit to 2.13.3

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:45 AM

• bzimport added a project: Gerrit.

• bzimport set Reference to bz49006.

• bzimport added a subscriber: Unknown Object (MLST).

Wikinaut created this task.May 31 2013, 6:50 AM

It's marked at an incorrect place...

"<" in <div style='width: hasn't been changed but is marked as removal.

The whole diff and highlighting is a mess, which is why it's being yanked out and replaced upstream.

• demon unsubscribed.Dec 8 2014, 6:33 PM

hashar renamed this task from Gerrit side-by-side diff view does not mark a removed "space" in a string (example given) to Gerrit side-by-side diff view does not mark a removed "space" in a string (example given) (intraline different doesn't work with spaces).Sep 10 2015, 11:46 AM

hashar set Security to None.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2015, 11:46 AM

In T40700#459065, @demon wrote:

Is this possibly it? http://code.google.com/p/gerrit/issues/detail?id=1062

Also potentially related: http://code.google.com/p/gerrit/issues/detail?id=892