Page MenuHomePhabricator

MobileFrontend: Inline code tags styled very large in articles
Closed, ResolvedPublic

Description

See http://en.wikipedia.org/w/index.php?title=ggplot2&oldid=551167896
(Comparison with base graphics and other packages section)

The problem is vertical padding.


Version: unspecified
Severity: normal
Whiteboard: design

Details

Reference
bz49033

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:40 AM
bzimport set Reference to bz49033.
  • Bug 53031 has been marked as a duplicate of this bug. ***
  • Bug 53347 has been marked as a duplicate of this bug. ***

Created attachment 13169
Side-by-side comparison of proposed change

To fix: Move padding declaration out of "pre, code" ruleset. The approach "p > code" doesn't make sense since code is always inline and pre always block.

Then add:
pre { padding: 1em }
code { padding: 0.2em 0.5em; }

or something like that

Attached:

Change 81114 had a related patch set uploaded by Jdlrobson:
Bug 49033: Style pre and code tags properly

https://gerrit.wikimedia.org/r/81114

Change 81114 had a related patch set uploaded by Krinkle:
Bug 49033: Style pre and code tags properly

https://gerrit.wikimedia.org/r/81114

Change 81114 merged by jenkins-bot:
Style pre and code tags properly

https://gerrit.wikimedia.org/r/81114

Are you sure this got fixed fully? I'm still seeing <code> tags rendering weirdly - for example https://en.m.wikipedia.org/wiki/LibreSSL#Changes - which is even worse in the Android mobile app. (reported in https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7720246 )

Yeah, same here.

https://meta.m.wikimedia.org/wiki/Tech/News/2014/41/en features a ridiculously large "phab" code tag.

  • Bug 72354 has been marked as a duplicate of this bug. ***

Change 168606 had a related patch set uploaded by Florianschmidtwelzow:
Add handling of code tags in content

https://gerrit.wikimedia.org/r/168606

Change 168606 merged by jenkins-bot:
Add handling of code tags in content

https://gerrit.wikimedia.org/r/168606